[1.12.2][SOLVED] Issue with update() in tile entity

[uncleofbob]

7 hours ago, jabelar said:

Well it is a "cheat" in the sense that ITickable should not need any such silliness. Think about it -- a furnace happily cooks something as an ITickable and any animated tile entity is happily updated every tick. You should really find the root cause of the problem. But if it works I guess use it. Something is still wrong with your implementation in my opinion though and it might bite you later.

 When I get deeper in to modding, I'll probably be able to find the root cause of my problem. Now i just want to continue my mod development.

 

Thank you all for help !

[uncleofbob]

Can it be ? Have I solved my problem ?!

I've added the following method to my tile entity, and update() hasn't failed yet!

 

@Override
public void onLoad() {
		 posB = this.getPos();
	 }

 

This code changes the way I get the BlockPos, which i used to get from a set method in tile entity i called from onBlockPlacedBy.

 @diesieben07 ? 

 

 

 

[Draco18s]

1 hour ago, uncleofbob said:

Can it be ? Have I solved my problem ?!

I've added the following method to my tile entity, and update() hasn't failed yet!

 

@Override
public void onLoad() {
		 posB = this.getPos();
	 }

 

This code changes the way I get the BlockPos, which i used to get from a set method in tile entity i called from onBlockPlacedBy.

 @diesieben07 ?

Why the hell are you storing your TE's position? TEs already do this, that's what getPos() does.

[uncleofbob]

1 hour ago, Draco18s said:

Why the hell are you storing your TE's position? TEs already do this, that's what getPos() does.

Because Im obviously a n00b ?.

[KittenKoder]

7 hours ago, uncleofbob said:

Because Im obviously a n00b ?.

You can also access it with TileEntity::pos, so be careful using that as a variable in your TE.

[jabelar]

I really don't get why this isn't working for you. I have tile entities in my mods and I simply implement the ITickable interface and I can watch them process things per tick exactly as expected. I don't do any of this scheduling updates stuff. You can try my example mod and look at the TileEntityCompactor here: https://github.com/jabelar/ExampleMod-1.12/blob/master/src/main/java/com/blogspot/jabelarminecraft/examplemod/tileentities/TileEntityCompactor.java

[uncleofbob]

Hi again! It's working now! It was all related to how I used the position wrong.

Somehow update() ran when the block was placed in certain quadrants related to the first block i placed. This made me change the way I get my Tile entity pos.

Now I just access "this.getPos()" in methods that need it. The onLoad() wasn't necessary either.

 

And yes, I scrapped the scheduleBlockUpdate workaround!

 

Again, thank you all for replies and using your time on my problem!

 

Edited January 17, 2018 by uncleofbob

[jabelar]

Cool. Sometimes when something just doesn't seem right it is worth continuing to dig in even if you think you've got a work around. Feels a lot better to fix it properly!

[KittenKoder]

1 hour ago, uncleofbob said:

Hi again! It's working now! It was all related to how I used the position wrong.

Somehow update() ran when the block was placed in certain quadrants related to the first block i placed. This made me change the way I get my Tile entity pos.

Now I just access "this.getPos()" in methods that need it. The onLoad() wasn't necessary either.

 

And yes, I scrapped the scheduleBlockUpdate workaround!

 

Again, thank you all for replies and using your time on my problem!

 

I don't understand what you mean by this? I was testing with just System.out messages and got nothing in the logs (junk or server). Could you please show us the code involved?

[uncleofbob]

I know the names of block and tile entity class is a bit odd. And my use of variables could be less. It will be changed.

 

Block:

public class JdwBlockBitumen extends Block implements IHasModel, ITileEntityProvider{
	
	public JdwBlockBitumen(String name, Material material) 
	{
		super(material);
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.MISC);
		setHarvestLevel("pick_axe", 1);
		
	}
	
	@Override
	public boolean hasTileEntity(IBlockState state) {
		return true;
	}
	
	@Override
	public TileEntity createNewTileEntity(final World worldIn, int meta) {
		return new JdwOSDigger();
	}
	
	@Override
	public void onBlockAdded(World worldIn, BlockPos pos, IBlockState state) {
	}
	

	@Override
	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
    {
        if (!worldIn.isRemote )
        {
            final JdwOSDigger tileEntity = (JdwOSDigger) worldIn.getTileEntity(pos);
            
            if(tileEntity != null) {

            	tileEntity.toggleActive();  	
            }      
        }

            return true;
        
    }
	@Override
	public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
	
	}
  
	@Override
	public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
		super.breakBlock(worldIn, pos, state);
	}
	
	
	//registers model
	@Override
	public void registerModels() 
	{
		DerpWorld.proxy.registerItemRenderer(Item.getItemFromBlock(this), 0, "inventory");
	}


}

Tile Entity:

public class JdwOSDigger extends TileEntity implements ITickable{

	
	private boolean aktivitas;
	private List<BlockPos> AREA = new ArrayList<BlockPos>();
	private int radi;
	private int index;
	private int tickCounter;
	
	public JdwOSDigger() {
		radi = 0;
		index = 0;
		tickCounter = 0;
		aktivitas = false;		
	}

	
	public void toggleActive() {
		if (aktivitas) {
			aktivitas = false;
			System.out.println("Activated: " + aktivitas + ",   Is valid?: " + !this.isInvalid());
		}
		else {
			aktivitas = true;
			System.out.println("Activated: " + aktivitas + " ,   Is valid? " + !this.isInvalid());
			mapQuarry(6, this.getPos());  //here is where I call the Tile Entity pos
			
		}
	}
	
	
	public void mapQuarry (int radi, BlockPos pos) {
	
		List<BlockPos> l = new ArrayList<BlockPos>();
		int[] squares = new int[radi];
		BlockPos qC = null; 
		int bx, by, bz = 0;

		for(int k = 0; k<4; k++) {

			switch(k){
			case 0: qC = pos.add(radi+1, 0, radi+1); 
					break;
			case 1: qC = pos.add(-(radi+1), 0, radi+1); 
					break;
			case 2: qC = pos.add(radi+1, 0, -(radi+1)); 
					break;
			case 3: qC = pos.add(-(radi+1), 0, -(radi+1)); 
					break;
			}
			
			for(int e = 0; e<radi/2; e++) {
				for(int i = -radi+e; i <= radi-e; i++) {
					for (int j = -radi+e; j<=radi-e; j++) {
						bx = qC.getX() + i;
						bz = qC.getZ() + j;
						by = qC.getY() - 1 - e;
						
						BlockPos pos2 = new BlockPos( bx , by, bz );
						l.add(pos2);

					}
				}
			}
		}
		
		AREA.addAll(l);	
		System.out.println("map quarry finished, Testing AREA[4] : " + AREA.get(4));
	}	
  
	public void readFromNBT(NBTTagCompound compound)
    {
        super.readFromNBT(compound);
        aktivitas = compound.getBoolean("hore");
       tickCounter = compound.getInteger("kuse");
       index = compound.getInteger("lespe");
    }
	
    public NBTTagCompound writeToNBT(NBTTagCompound compound)
    {
        super.writeToNBT(compound);
        //compound.setByte();
       compound.setInteger("lespe", index);
       compound.setInteger("kuse", tickCounter);
       compound.setBoolean("hore", aktivitas);
        return compound;
    }

    @Override
	public void update() 
	{
		if (!world.isRemote){
			if(aktivitas)  {
				tickCounter++;
				if (tickCounter==20) {
					world.destroyBlock(AREA.get(index), false);
					System.out.println("Destroyed block at:  " + AREA.get(index) );
					index++;
					tickCounter = 0;
				}
			}
		}
	}

 

 

 

[KittenKoder]

34 minutes ago, uncleofbob said:

@Override public void update() { if (!world.isRemote){ if(aktivitas) { tickCounter++; if (tickCounter==20) { world.destroyBlock(AREA.get(index), false); System.out.println("Destroyed block at: " + AREA.get(index) ); index++; tickCounter = 0; } } } }

This was the part I was interested in. But after reading your post again I think I understood and replaced everything with the get methods in my update method. I'm getting it to work with the classes now as well. If your's breaks again, try replacing the world member with the getWorld method too.

 

Thanks for keeping on this, I had to write almost a hundred recipe files today so I haven't had time to dig more on it. lol It didn't occur to me to look at the members being referenced in the functions.