Smelting

[leosavi25]

I'm creating a mod for 1.12 and I add the Copper Ore and the Ingot Copper, but when I put the Copper Ore in the Furnace nothing happen.

Here's the code:

 

  Reveal hidden contents

@Mod(modid = Reference.MOD_ID, version = Reference.VERSION, name = Reference.NAME)
public class Modding{

    @Instance
    public Modding instance;
    
    @SidedProxy(clientSide = Reference.CLIENT_PROXY, serverSide = Reference.COMMON_PROXY)
    public static CommonProxy proxy;
    
    @EventHandler
    public static void preInit(FMLPreInitializationEvent event){
        GameRegistry.addSmelting(BlockInit.ORE_COPPER_BLOCK, new ItemStack(ItemInit.COPPER_INGOT), 0.2f);
    }
    @EventHandler
    public static void init(FMLInitializationEvent event){}
    @EventHandler
    public static void postInit(FMLPostInitializationEvent event){}
}

 

Please help me!!!

Edited January 15, 2018 by leosavi25

[leosavi25]

  Reveal hidden contents

 

public class BlockInit {

    public static final List<Block> BLOCKS = new ArrayList<Block>();

    public static final Block ORE_COPPER_BLOCK = new Ore("ore_copper");

}

 

 

  Reveal hidden contents

public class ItemInit {

    public static final List<Item> ITEMS = new ArrayList<Item>();
    
    public static final Item COPPER_INGOT = new ItemBase("copper_ingot", CreativeTabs.MATERIALS);

}

  Reveal hidden contents

@EventBusSubscriber

public class RegistryHandler{

@SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event){
        event.getRegistry().registerAll(ItemInit.ITEMS.toArray(new Item[0]));
    }
    
    @SubscribeEvent
    public static void onBlockRegister(RegistryEvent.Register<Block> event){
        event.getRegistry().registerAll(BlockInit.BLOCKS.toArray(new Block[0]));
    }

}

 

[leosavi25]

I saw it in a tutorial on Internet and if I run the code it work(I don't know how it works) : I have the copper block and the copper ingot, but when i put the copper ore in the furnace, it didn't work. I try to change the code to GameRegistry.addSmelting(ItemInit.COPPER_INGOT, new ItemStack(ItemInit.COPPER_INGOT), 0.2f); and it work because if I smelt a copper ingot it makes a Copper Ingot, I try to change also with Blocks.DIRT and it work but with BlockInit.ORE_COPPER_ORE it doesn't work

[leosavi25]

Yes and I don't know beacuse it work, but in the game I can play with the copper ore and the copper ingot, the problem is smelting the copper ore

[leosavi25]

I found where I add the ore copper and the copper ingot

  Reveal hidden contents

public class Ore{

  public Ore(String name){
        setRegistryName(name);
        setUnlocalizedName(name);
        
        BlockInit.BLOCKS.add(this);
        ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
    }

}

  Reveal hidden contents

public ItemBase(String name, CreativeTabs tab){
        setUnlocalizedName(name);
        setRegistryName(name);
        setCreativeTab(tab);

ItemInit.ITEMS.add(this);

}

 

Edited January 15, 2018 by leosavi25

[leosavi25]

But if it isn't static I can't have access of it in other classes

[ModMCdl]

  On 1/15/2018 at 3:48 PM, leosavi25 said:

But if it isn't static I can't have access of it in other classes

Expand  

How are you structuring your mod overall? Are you registering each item in their specific class, or do you have a main class like "ModItem" or "ModBlocks" where you list them all? It's unclear from the code you've given us.

[leosavi25]

  On 1/15/2018 at 3:08 PM, leosavi25 said:

  Reveal hidden contents

 

public class BlockInit {

    public static final List<Block> BLOCKS = new ArrayList<Block>();

    public static final Block ORE_COPPER_BLOCK = new Ore("ore_copper");

}

 

 

  Reveal hidden contents

public class ItemInit {

    public static final List<Item> ITEMS = new ArrayList<Item>();
    
    public static final Item COPPER_INGOT = new ItemBase("copper_ingot", CreativeTabs.MATERIALS);

}

  Reveal hidden contents

@EventBusSubscriber

public class RegistryHandler{

@SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event){
        event.getRegistry().registerAll(ItemInit.ITEMS.toArray(new Item[0]));
    }
    
    @SubscribeEvent
    public static void onBlockRegister(RegistryEvent.Register<Block> event){
        event.getRegistry().registerAll(BlockInit.BLOCKS.toArray(new Block[0]));
    }

}

A Block/Item Init class where I put all blocks and Items and a RegistryHandler that register all Block and Item.

Expand  

 

Edited January 15, 2018 by leosavi25

[leosavi25]

  On 1/15/2018 at 3:45 PM, diesieben07 said:

Do not create your items in a static initializer.

Expand  

What does it mean this? Sorry I am Italian

[leosavi25]

ok but what I have to do exactly?

[Draco18s]

  On 1/15/2018 at 4:29 PM, leosavi25 said:

ok but what I have to do exactly?

Expand  

Follow these steps and everything will work out:

1) Go learn Java

2) Come back and look at your code

3) Profit

[leosavi25]

I know the basic of java, like variable method classes subclasses superclasses...I know java only for hobby

I don't understand what I have to do and I'm asking for it

Edited January 15, 2018 by leosavi25

[Draco18s]

This is what you need to do:

  On 1/15/2018 at 3:45 PM, diesieben07 said:

Do not create your items in a static initializer.

Expand  

[leosavi25]

  On 1/15/2018 at 6:03 PM, Draco18s said:

This is what you need to do:

Expand  

I dont't think that this is the problem: if I change BlockInit.ORE_COPPER_BLOCK with ItemInit.COPPER_INGOT and I put the Copper Ingot in the furnace it works and if I change it with Blocks.DIRT and I put a dirt block in the furnace it works. It doesn't work with BlockInit.ORE_COPPER_BLOCK. I try also to create another block and it doesn't work too. Could it be the BlockInit class that have some problem?

[Draco18s]

  On 1/15/2018 at 3:08 PM, leosavi25 said:

public class BlockInit {

    public static final List<Block> BLOCKS = new ArrayList<Block>();

    public static final Block ORE_COPPER_BLOCK = new Ore("ore_copper");

}

Expand  

 

  On 1/16/2018 at 4:54 PM, leosavi25 said:

Could it be the BlockInit class that have some problem?

Expand  

Yes.

Specifically:

  On 1/15/2018 at 3:45 PM, diesieben07 said:

Do not create your items in a static initializer.

Expand  

 

[leosavi25]

  Reveal hidden contents

public class BlockInit {

    public static final List<Block> BLOCKS = new ArrayList<Block>();

    public static final Block ORE_COPPER_BLOCK = new Ore("ore_copper");

}

  Reveal hidden contents

public class Ore extends BlockOre{
    
    public Ore(String name){
        setRegistryName(name);
        setUnlocalizedName(name);
        
        BlockInit.BLOCKS.add(this);
        ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
    }

what mustn't be static? If BLOCKS or ORE_COPPER_BLOCK are not static it give me error in Ore class

[Draco18s]

That is not what D7 said.

Do not create your items in a static initializer.

 

He said nothing about having static fields. He said static initializer.

[leosavi25]

  On 1/15/2018 at 4:11 PM, diesieben07 said:

https://docs.oracle.com/javase/tutorial/java/javaOO/initial.html

Expand  

From here I undersatnd that a static initializer is "static{code}", right?

[leosavi25]

Ok, but I don't understand: I must create an init() method and initialize all Item there?

[leosavi25]

Can you send me an example code please?

Edited January 17, 2018 by leosavi25

[leosavi25]

  On 1/17/2018 at 3:47 PM, diesieben07 said:

Preferably in the registry event. It must not happen in a static initializer because then Forge will not be able to detect that the code belongs to your mod and won't be able to set the registry name properly.

Expand  

 

 

  On 1/17/2018 at 5:08 PM, diesieben07 said:

What for?

Expand  

I did this but when I try to enter in a world it says that ore copper block and ore copper item miss

[ChronosWS]

I'll take a stab at this - sorry I'm pretty new to modding but I can answer the Java-ish related question for you.

 

When they say don't register in the static initializer, they mean that you shouldn't be creating the items as part of static initialization, which is what happens when you assign static fields a value as part of the declaration.  In your code:

 public class BlockInit {
    public static final List<Block> BLOCKS = new ArrayList<Block>();

    public static final Block ORE_COPPER_BLOCK = new Ore("ore_copper");
} 

 

Both of those fields are static initializer fields.  Now, if you want to be able to access them statically but not initialize them statically, do something like this (which you can find by examining a number of mods source code on Github; see for example Vazkii's relatively clean Psi mod here):

public class BlockInit {
	public static final List<Block> BLOCKS = new ArrayList<Block>();
    public static final Block ORE_COPPER_BLOCK;  // DO NOT ASSIGN HERE!
      
    public static void preInit() {
      ORE_COPPER_BLOCK = new Ore("ore_copper");
      BLOCKS.add(ORE_COPPER_BLOCK); // Not sure why you are keeping the list, but if you want to add, you can do so here.
    }
  
    public static void init() {
      OreDictionary.registerOre("<your block ore dict id here>", new ItemStack(ORE_COPPER_BLOCK, 1, 0));
    }
}

 

Then, when handling the FMLPreInitializationEvent , call BlockInit.preInit().  When handling the FMLInitializationEvent , call BlockInit.init().

 

Hope this helps more than harms.  I strongly recommend following one of the other mods' patterns rather than rolling your own Vazkii's more or less follows the Forge documentation recommended guidelines, and it will help your future questions here if you have followed the documentation patterns so you won't have to explain yourself

[leosavi25]

public static final Block ORE_COPPER_BLOCK;

 

You can't do this because it is a costant

[ChronosWS]

  On 1/17/2018 at 5:42 PM, leosavi25 said:

public static final Block ORE_COPPER_BLOCK;

 

You can't do this because it is a costant

Expand  

Sorry, remove the 'final' from it

[leosavi25]

  On 1/17/2018 at 5:47 PM, ChronosWS said:

Sorry, remove the 'final' from it

Expand  

If I remove final when I try to enter in a world it says that ore_copper block and ore_copper item missing