[1.12.2] Test if Inventory contains multiple Items

[BrainFace]

I'm having the following problem, i'm trying to create a Witchery like cauldron and i need to check wether multiple Items (saved in a list) are contained in another list.

List<ItemStack> items = new ArrayList<ItemStack>();
for (int i = 0; i < tile.getInventory().getSlots(); i++){
    if (tile.getItem().getStackInSlot(i) != new ItemStack(Items.AIR)){
       items.add(tile.getItem().getStackInSlot(i));
    }
}

if (items.containsAll(recipe.catalysator)) {

    // TODO

}

The recipe.catalysator is a list that contains one item and the same item is also in the inventory.

[loordgek]

use itemstack.isEmpty not

 != new ItemStack(Items.AIR)

[Differentiation]

9 minutes ago, BrainFace said:

List<ItemStack> items = new ArrayList<ItemStack>(); for (int i = 0; i < tile.getInventory().getSlots(); i++){ if (tile.getItem().getStackInSlot(i) != new ItemStack(Items.AIR)){ items.add(tile.getItem().getStackInSlot(i)); } } if (items.containsAll(recipe.catalysator)) { // TODO }

List<ItemStack> items = new ArrayList<ItemStack>();
for (int i = 0; i < tile.getInventory().getSlots(); i++){
    if (!tile.getItem().getStackInSlot(i).isEmpty()){
       items.add(tile.getItem().getStackInSlot(i));
    }
}

if (items.containsAll(recipe.catalysator)) {

    // TODO

}

[loordgek]

@Differentiation that code block is a bit hard to read

[Differentiation]

14 minutes ago, BrainFace said:

I'm having the following problem, i'm trying to create a Witchery like cauldron and i need to check wether multiple Items (saved in a list) are contained in another list.

List<ItemStack> items = new ArrayList<ItemStack>();
for (int i = 0; i < tile.getInventory().getSlots(); i++){
    if (tile.getItem().getStackInSlot(i) != new ItemStack(Items.AIR)){
       items.add(tile.getItem().getStackInSlot(i));
    }
}

if (items.containsAll(recipe.catalysator)) {

    // TODO

}

The recipe.catalysator is a list that contains one item and the same item is also in the inventory.

List<ItemStack> items = new ArrayList<ItemStack>();

for (int i = 0; i < tile.getInventory().getSlots(); ++i)
{
    if (!tile.getItem().getStackInSlot(i).isEmpty())
    {
        items.add(tile.getItem().getStackInSlot(i));
    }
}

if (items.containsAll(recipe.catalysator)) 
{

}

 

Edited January 24, 2018 by Differentiation

[Differentiation]

1 minute ago, loordgek said:

@Differentiation that code block is a bit hard to read

Purge the page (reload)

[BrainFace]

So i tried this change and my inventory list doesnt contain air anymore but it still doesnt work.

[loordgek]

can you put all your code on https://github.com/

so we can have a look