Jump to content

[1.12] Forcing the refresh of chest contents client-side


Kinniken

Recommended Posts

Hi all,

 

I have a GUI whose displayed information depends on the content of various chests (a trading screen, where the supply of goods comes from N chests in a building). I'm having issues in 1.12 I did not have in 1.7 where actions taken by the player (buying/selling goods) don't seem to be applied client-side immediately in the building's chest, only in his inventory. For example, if he buys a stack of stone, it will immediately appear in his inventory, but it won't disappear immediately in the building's chests, so it might show in my GUI as still available even though the stock is gone.

 

I'd happily post code but the full setup covers multiple complicated classes.

 

Is there any particular way to force Minecraft to immediately update a tile entity's data on a given client?

 

BTW, all this happens in SSP, not just MP.

 

Thanks

Link to comment
Share on other sites

The problem is that the client doesn't know what the contents of a chest are until the player opens it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

15 hours ago, diesieben07 said:

"SSP" and "MP" are exactly the same, both use a server and a client.

How are you performing these buying/selling actions? Code is indeed required.

SSP and MP are mostly the same, since 1.3 IIRC (god was that update a main to deal with). However for a problem like the one I'm having the difference can be significant, if only due to the reduced lag.

 

There are too many classes to all list, but the gist of it is:

 

In ContainerTrade that extends Container, in slotClick(), in the case of the player buying goods and hence taking them from the building's chests:

 

while ((taken < toTake) && (i < resManager.chests.size())) {
			final TileEntityChest chest = resManager.chests.get(i).getMillChest(world);

			if (chest != null) {
				taken += WorldUtilities.getItemsFromChest(chest, item, meta, toTake - taken);
			}

			i++;
		}

 

You can ignore how I get that list of chest positions, that's not really relevant. Then for each chest:

 

static public int getItemsFromChest(final IInventory chest, final Item item, final int meta, final int toTake) {
		if (chest == null) {
			return 0;
		}

		int nb = 0;

		int maxSlot = chest.getSizeInventory() - 1;

		for (int i = maxSlot; (i >= 0) && (nb < toTake); i--) {
			final ItemStack stack = chest.getStackInSlot(i);

			if ((stack != null) && (stack.getItem() == item) && ((stack.getItemDamage() == meta) || (meta == -1))) {
				if (stack.getCount() <= (toTake - nb)) {
					nb += stack.getCount();
					chest.setInventorySlotContents(i, ItemStack.EMPTY);
				} else {
					chest.decrStackSize(i, toTake - nb);
					nb = toTake;
				}
			}

		return nb;
	}

 

Simplifying the code a bit. For me the only part that seems like it could be relevant is that I take items via either setInventorySlotContents (if I'm taking a whole stack) or decrStackSize (if only part of it). Is there something else I should do to get Forge to update the chest client-side ASAP?

 

Thanks

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.