Registering Items

[_Bedrockbreaker_]

I was updating my mod from 1.12 to 1.12.2, not thinking that anything would break. As it turns out, GameRegistry.register() doesn't seem to work anymore. I was reading up on how to actually register the items/blocks, and I just got incredibly confused and lost (I got really used to the old way, and I don't entirely understand the newer one). The method I am now trying to use is

Spoiler

@SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {

        final Item[] items = {
                
            //Misc + crafting
            //Jello
            itemliquidmeat,
            itemfilterpart,
            itemfilter,
            itemgelatinewet,
            itemgelatine,
            itemjellomix,
            itemjellohot,
            //Cat Hair
            itemcathair,
            
            //Foods
            //Ramen
            foodpeppers,
            foodramencold,
            foodramencooked,
            foodramenspicy,
            foodramensweet,
            foodramenjello,
            foodramenhairy,
            foodramenmeaty,
            foodramenramen,
            foodramenprimal,
            foodramenelectronic,
            foodramenmysterious,
            foodramenbalanced,
            //Bologna
            foodbologna,
            //Jello
            foodjello,
        
        };
        
        final IForgeRegistry<Item> registry = event.getRegistry();
        
        for (final Item item : items) {
            
            registry.register(item);
            
        }
        
    }

My full mod is on Github: https://github.com/Bedrockbreaker/rtap/tree/master

Relevant files in src/main/java/com/bedrockbreaker/rtap/ and src/main/java/com/bedrockbreaker/rtap/init

[_Bedrockbreaker_]

I don't understand the context of the first bullet point. Anyways, ModBlocks.registerItems was me copy/pasting code before actually seeing if it worked. I am also assuming bullet points 2 and 3 are given for almost every thread as they can fix 90% of the problems asked here. The only thing I see that I should do from those links is to add @Override to anything overridden. However, as far as I can tell, I am not overriding anything when creating an item. I am just registering an item to a list.

As to fixing my problem, I am thinking I should wrap

Spoiler

@SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {

        final Item[] items = {
                
            //Misc + crafting
            //Jello
            itemliquidmeat,
            itemfilterpart,
            itemfilter,
            itemgelatinewet,
            itemgelatine,
            itemjellomix,
            itemjellohot,
            //Cat Hair
            itemcathair,
            
            //Foods
            //Ramen
            foodpeppers,
            foodramencold,
            foodramencooked,
            foodramenspicy,
            foodramensweet,
            foodramenjello,
            foodramenhairy,
            foodramenmeaty,
            foodramenramen,
            foodramenprimal,
            foodramenelectronic,
            foodramenmysterious,
            foodramenbalanced,
            //Bologna
            foodbologna,
            //Jello
            foodjello,
        
        };
        
        final IForgeRegistry<Item> registry = event.getRegistry();
        
        for (final Item item : items) {
            
            registry.register(item);
            
        }
        
    }

with public class RegistererOfItems { ... } and put MinecraftForge.EVENT_BUS.register(ModItems.RegistererOfItems.class) in the preInit phase of my main class.

 

EDIT:

After doing that, my game no longer crashes, but no items are registered. Don't even appear in jei and I can't /give them to me. I should probably read even more on events

Edited February 18, 2018 by _Bedrockbreaker_
edit

[Draco18s]

Quote

I don't understand the context of the first bullet point.

package names are intended to mirror the owner's Web presence. Google uses the com.google prefix because they are Google.com

 

You are not this company: http://bedrock.com

Edited February 18, 2018 by Draco18s

[jabelar]

In terms of your general problem with registering items, it is understandable if you've modded before to be confused that there is now an entirely different method of doing so which uses special registry events together with a new "object holder" annotation.

 

In your InitBlocks and InitItems classes you should actually initialize them to null. Then you should give each class the @ObjectHolder annotation. What this does is during mod loading there are several passes after each registry event to "inject" the actual instance into the fields. The fields are matched up by the field name matching the registry name (or you can add additional annotation if you want a different field name).

 

Next you need methods that handle the registry events. I personally put those in an inner class of the class that has the @ObjectHolder instances. Those require methods regular event handling meaning the class needs the @EventBusSubscriber annotation and the methods need to be static and have the @SubscribeEvent annotation.

 

The registry events are generic so you have to handle each valid type. Such as RegistryEvent.Register<Block> and RegistryEvent.Register<Item>.  (Note you should also be using this for entities, biomes and some other things.)

 

Lastly you do the actual constructing of your singleton instances in the registry handling event.

 

You can see my example mod classes for ideas on how to put it all together: 

• https://github.com/jabelar/ExampleMod-1.12/blob/master/src/main/java/com/blogspot/jabelarminecraft/examplemod/init/ModBlocks.java
• https://github.com/jabelar/ExampleMod-1.12/blob/master/src/main/java/com/blogspot/jabelarminecraft/examplemod/init/ModItems.java

 

Hope that helps.

 

 

[_Bedrockbreaker_]

2 hours ago, Draco18s said:

package names are intended to mirror the owner's Web presence. Google uses the com.google prefix because they are Google.com

 

You are not this company: http://bedrock.com

Okay. What should I do then, If I don't intend on owning a website dedicated to my mod? When I first started modding, the tutorials I followed always had com.something.examplemod. So I didn't know anything was wrong.

As for @jabelar, I finally understood what to do after looking through your code and got my mod working again. Thanks for the help!

[Cadiboo]

30 minutes ago, _Bedrockbreaker_ said:

Okay. What should I do then, If I don't intend on owning a website dedicated to my mod? When I first started modding, the tutorials I followed always had com.something.examplemod. So I didn't know anything was wrong.

Just name your mod after you, not a website that doesn't belong to you/exist

Name it something like bedrockbreaker.rtap

[Draco18s]

Better idea:

 

mod.bedrockbreaker

 

"mod" is not a top level domain (and even if it was, this is a reference to it being a mod)