[SOLVED] [1.12.2] Recipes with RegistryEvents instead of JSON

[Cadiboo]

I'm currently trying to use @SubscribeEvent -  RegistryEvent.Register<IRecipe> event to create and register my recipes instead of using JSON, allowing my registration to take place in a minimal amount of files and make my registration much more ordered. My problem is that I don't understand the system and even though I've looked at the docs, other peoples problems, examples (Choonster's TestMod3, ShadowsOfFire's approach to the problem), I still don't understand how to create a list of Recipes each created with a list of Ingredients to event.getRegistry().registerAll(ModRecipes.RECIPES);

My classes if it helps:

RegistryEventHandler.java

Spoiler

package cadiboo.wiptech;

 

import cadiboo.wiptech.init.ModBlocks;

import cadiboo.wiptech.init.ModItems;

import cadiboo.wiptech.init.ModRecipes;

import net.minecraft.block.Block;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;

import net.minecraft.item.Item;

import net.minecraft.item.ItemBlock;

import net.minecraft.item.ItemStack;

import net.minecraft.item.crafting.IRecipe;

import net.minecraftforge.client.event.ModelRegistryEvent;

import net.minecraftforge.client.model.ModelLoader;

import net.minecraftforge.event.RegistryEvent;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

import net.minecraftforge.fml.common.registry.ForgeRegistries;

 

@Mod.EventBusSubscriber

public class RegistryEventHandler

{

    @SubscribeEvent

    public static void registerBlocks(RegistryEvent.Register<Block> event)

    {    

        event.getRegistry().registerAll(ModBlocks.BLOCKS);

        Utils.getLogger().info("Registered blocks");

    }

    

    @SubscribeEvent

    public static void registerItems(RegistryEvent.Register<Item> event)

    {    

        event.getRegistry().registerAll(ModItems.ITEMS);

        

        for (Block block : ModBlocks.BLOCKS)

        {

            event.getRegistry().register(new ItemBlock(block).setRegistryName(block.getRegistryName()));

        }

        

        Utils.getLogger().info("Registered items");

    }

    

    @SubscribeEvent

    public static void registerModels(ModelRegistryEvent event)

    {

        for (Block block: ModBlocks.BLOCKS)

        {

            ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(block.getRegistryName(), "inventory"));

        }

        

        for (Item item: ModItems.ITEMS)

        {

            ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));

        }

        

        Utils.getLogger().info("Registered models");

    }

    

    @SubscribeEvent

    public static void registerRecipies(RegistryEvent.Register<IRecipe> event)

    {    

        for (IRecipe recipe: ModRecipes.RECIPES) {

            event.getRegistry().register(recipe);

        }

        Utils.getLogger().info("Registered Recipies");

    }

}

 

ModRecipes.java

Spoiler

package cadiboo.wiptech.init;

import java.util.ArrayList;
import java.util.List;

import cadiboo.wiptech.Reference;
import cadiboo.wiptech.Utils;
import cadiboo.wiptech.item.ItemCopperIngot;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.IRecipe;
import net.minecraft.item.crafting.Ingredient;
import net.minecraft.item.crafting.ShapedRecipes;
import net.minecraft.util.NonNullList;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.oredict.OreIngredient;

//http://gist.github.com/Shadows-of-Fire/8f164e07d63ec9b7f43a804137455025

public class ModRecipes {
    
    public static final List<IRecipe> RECIPES = new ArrayList<IRecipe>(
            
            //new genShaped("copper_ingot")
            );
    
    
    /*
     * This adds the recipe to the list of crafting recipes.  Since who cares about names, it adds it as recipesX, where X is the current recipe you are adding.
     */
    /*public static void addRecipe(int j, IRecipe rec) {
        if (rec.getRegistryName() == null)
            RECIPES.add(rec.setRegistryName(new ResourceLocation(Reference.ID, "recipes" + j)));
        else
            RECIPES.add(rec);
    }*/
    
    public static ShapedRecipes genShaped(String group, ItemStack output, int l, int w, Object[] input) {
        if (input[0] instanceof List)
            input = ((List<?>) input[0]).toArray();
        else if (input[0] instanceof Object[])
            input = (Object[]) input[0];
        if (l * w != input.length)
            throw new UnsupportedOperationException(
                    "Attempted to add invalid shaped recipe.  Complain to the author of " + Reference.NAME);
        NonNullList<Ingredient> inputL = NonNullList.create();
        for (int i = 0; i < input.length; i++) {
            Object k = input;
            if (k instanceof String) {
                inputL.add(i, new OreIngredient((String) k));
            } else if (k instanceof ItemStack && !((ItemStack) k).isEmpty()) {
                inputL.add(i, Ingredient.fromStacks((ItemStack) k));
            } else if (k instanceof Item) {
                inputL.add(i, Ingredient.fromStacks(new ItemStack((Item) k)));
            } else if (k instanceof Block) {
                inputL.add(i, Ingredient.fromStacks(new ItemStack((Block) k)));
            } else {
                inputL.add(i, Ingredient.EMPTY);
            }
        }

        return new ShapedRecipes(group, l, w, inputL, output);
    }

    public static NonNullList<Ingredient> createInput(Object[] input) {
        if (input[0] instanceof List)
            input = ((List<?>) input[0]).toArray();
        else if (input[0] instanceof Object[])
            input = (Object[]) input[0];
        NonNullList<Ingredient> inputL = NonNullList.create();
        for (int i = 0; i < input.length; i++) {
            Object k = input;
            if (k instanceof String) {
                inputL.add(i, new OreIngredient((String) k));
            } else if (k instanceof ItemStack) {
                inputL.add(i, Ingredient.fromStacks((ItemStack) k));
            } else if (k instanceof Item) {
                inputL.add(i, Ingredient.fromStacks(new ItemStack((Item) k)));
            } else if (k instanceof Block) {
                inputL.add(i, Ingredient.fromStacks(new ItemStack((Block) k)));
            } else {
                throw new UnsupportedOperationException(
                        "Attempted to add invalid shapeless recipe.  Complain to the author of " + Reference.NAME);
            }
        }
        return inputL;
    }

 

Any Help appreciated, even if its just something like "read the docs again"

 

I've also redone my mod structure completely (in the same style as TwilightForrest, TestMod3 & this post) if anyone thinks it could be that

Edited May 14, 2018 by Cadiboo
Reformatted

[Draco18s]

You should be using the JSON system. The reason not to ("minimize the number of files") directly contradicts the reason for the JSON system: to allow recipes to be modified via data resource packs.