[1.12.2] Generating New crops in Villages

[_Bedrockbreaker_]

I have a crop that works, (only problem is that is that is outputs Exception loading model for variant rtap:croppeppers#inventory for item "minecraft:air" on load time)  I want it generate in the village farm land module-thingies though. I know Actually Additions does this, and its code seems to generate an entirely "new" building for their crops. I was wondering if I could just replace some of the existing crops with my crops. (Honestly, generating a new building isn't something I wouldn't do, and I am wondering if it would be the better option.) I don't know how to begin starting on this type of thing, so any help is appreciated. Bonus points if the plant can only generate in desert villages.

[Cadiboo]

Look at net.minecraft.world.gen.structure.StructureVillagePieces.class

Specifically at Field1 and Field2, I don't know how (you might need to make a coremod) but you could add another crop to the list of crops to pick from.
 

You should also look at how Binnies Extra Trees adds their hops.

 

You could create another field too that would only spawn in desert villages

[_Bedrockbreaker_]

Taking a look at Binnies Trees, seems to do almost the same think Actually Additions does. The only difference is that binnie creates a building, then populates the crops with any of the vanilla crops, or theirs. Actually additions just populates it with their own crops, because they have about 4 different types.

 

So I am thinking, that overriding any crops on world gen isn't going to be the answer, but generating a new building. Both mod's code provides enough detail on how to create a farm module, and register it. However, I don't see a reference to how that building is generated. There is a class in each mod that implements VillagerRegistry.IVillageCreationHandler . But none of the classes seem to be called by anything. Are they called from VillagerRegistry.IVillageCreationHandler , or is there something that I am missing?

 

What would be the "correct" way of spawning the structures only in deserts?

Edited February 24, 2018 by _Bedrockbreaker_

[jabelar]

So to make your own crop generation you should make a StructureVillagePieces.Village subclass like the vanilla Field1 or Field2 class and add your crop. Then use the IVillageCreationHandler to add it to the generation.

 

The IVillageCreationHandler is supposed to be registered to the village registry with VillageRegistry.instance().registerVillageCreationHandler() method. I'm not sure exactly when it should be registered, but I kinda feel it should be in init loading phase because you'd want it after your blocks are registered (in case you have custom blocks used in your village piece).

 

You also need to register your structure component with MapGenStructureIO.registerStructureComponent() method.

 

To make sure it is only in certain biome, I think in your the buildComponent() method of your IVillageCreationHandler you will get parameters for the mixX, minY and minZ (they call them p1, p2, and p3 in the interface declaration). You can use the position to query what biome you're in and check for desert.

 

I'm not super familiar with the above, but based on inspecting the classes I think it should work.

 

Note that you need to register your village with a "weight" that makes sense. You can learn about how that works here: https://minecraft.gamepedia.com/Village/Structures

 

I have an example of a "cloud house" that uses my cloud blocks for walls here: https://github.com/jabelar/ExampleMod-1.12/blob/master/src/main/java/com/blogspot/jabelarminecraft/examplemod/worldgen/structures/villages/VillageHouseCloud.java 

Edited February 25, 2018 by jabelar

[_Bedrockbreaker_]

On 2/24/2018 at 5:57 PM, jabelar said:

The IVillageCreationHandler is supposed to be registered to the village registry with VillageRegistry.instance().registerVillageCreationHandler()

My main class doesn't seem to be liking that. Keeps saying that it cannot be resolved or is not a field. The MapGenStructureIO thing seems to work though. And I think this works for checking the biome. world.getBiome(new BlockPos(sBoundingBox.minX, sBoundingBox.minY, sBoundingBox.minZ) . I think.

 

I did get a bit lost in your example code, as I didn't realize that you had both a "cloud house" and "cloud village". Kept getting confused.

 

Still confused, I will post links to my github, with links to related files.

Spoiler

Main Class - https://github.com/Bedrockbreaker/rtap/blob/master/src/main/java/mod/bedrock/rtap/RTAP.java

References (line 25) - https://github.com/Bedrockbreaker/rtap/blob/master/src/main/java/mod/bedrock/rtap/Reference.java

Village Creation Handler - https://github.com/Bedrockbreaker/rtap/blob/master/src/main/java/mod/bedrock/rtap/init/ModVillageRegister.java

Village File - https://github.com/Bedrockbreaker/rtap/blob/master/src/main/java/mod/bedrock/rtap/misc/villageCropPeppers.java

Nothing is printed to the console, which means that villageCropPeppers is never even being ran. This leads me to believe that is is VillagerRegistry.instance().registerVillageCreationHandler(Reference.MODVILLAGEREGISTER); 's fault, (I have commented it out, as it errors), because that part needs to be ran. Otherwise, I think I am good. think

[jabelar]

My example code goes further than just adding a piece. But I've been writing some tutorials on world generation and now have one for village stuff. See: http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-villages.html

 

Note that one section on that page is specifically related to adding a piece to vanilla villages. Follow that part. 

 

 

[_Bedrockbreaker_]

Alright, got my code to work, and after several hours of debugging, I realized that the second for loop in the double for loop in the addComponentParts section was checking the first variable, meaning that it would get stuck trying to increase j to basically infinity. much fun was had. After that was done, I finally got it to generate, and now I just have to get the numbers right on where the crops actually spawn.

 

The only problem now is that beet roots don't seem to like the "age" property, and the game crashes if I try to set their age. Is there a solution, or am I going to have to not spawn beetroots at all?

[Draco18s]

BlockBeetroot.BEETROOT_AGE

[_Bedrockbreaker_]

Okay, got the structure working exactly how I wanted it to.

Thanks for the help!