Jump to content

Bug in FMLClientHandler if entity.getParts() != null


bewi

Recommended Posts

Hi,

 

The spawnEntityIntoClientWorld() function in FMLClientHandler does not work properly for multi-part entities (Entity.getParts() != null).

 

entity.entityId will be set before the offsets are calculated for the parts. This leads to getEntityByID() in NetServerHandler always returning a wrong entity (or null in most cases) for those parts.

 

A simple solution is to move the assignment of the entity ID after the assignments of the parts' ids.

 

public Entity spawnEntityIntoClientWorld(EntityRegistration er, EntitySpawnPacket packet){
/*snip*/
            entity = (Entity)(cls.getConstructor(World.class).newInstance(wc));
            entity.entityId = packet.entityId;
/*snip*/
            Entity parts[] = entity.getParts();
            if (parts != null)
            {
                int i = packet.entityId - entity.entityId; //<- will always be 0
                for (int j = 0; j < parts.length; j++)
                {
                    parts[j].entityId += i;
                }
            }
/*snip*/
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.