Jump to content

Recommended Posts

Posted

Hey,

 

If I want to create an enchantment that will make the player change dirt to grass when he has it on his shoes, where should I write that behaviour? Right now I check in the LivingUpdateEvent if the entity has the enchantment, but it feels strange to do it there.

Is that the best way or should I do it another way?

 

@Mod.EventBusSubscriber(modid=Reference.MODID)
public class ModEnchantments {

	public static final Enchantment GRASSNESS = new EnchantmentGrassness();

	
	@SubscribeEvent
	public static void registerEnchantments(Register<Enchantment> event) {
		event.getRegistry().registerAll(GRASSNESS);
	}
	
	@SubscribeEvent
	public static void growGrassness(LivingUpdateEvent event) {			
		int level = EnchantmentHelper.getMaxEnchantmentLevel(GRASSNESS, event.getEntityLiving());
		if(level>0) {
			World w = event.getEntity().world;
			if(!w.isRemote) {
				int r = level+1;
				BlockPos pos = event.getEntity().getPosition();
				for(int x = -r; x <= r; x++) {
					for(int z = -r; z <= r; z++) {
						BlockPos blockpos = pos.add(x,-1,z);
						if(blockpos.distanceSq(pos.getX(), pos.getY(), pos.getZ())>r*r) {
							continue;
						}
						
						IBlockState iblockstate = w.getBlockState(blockpos);
						if (iblockstate.getBlock() == Blocks.DIRT && iblockstate.getValue(BlockDirt.VARIANT) == BlockDirt.DirtType.DIRT && w.getLightFromNeighbors(blockpos.up()) >= 4)
                        {
                            w.setBlockState(blockpos, Blocks.GRASS.getDefaultState());
                        }
					}
				}
			}
		}
	}
	
}

 

Posted
  On 3/2/2018 at 7:22 PM, suppergerrie2 said:

int level = EnchantmentHelper.getMaxEnchantmentLevel(GRASSNESS, event.getEntityLiving());

Expand  

I'd get the boots equipment stack directly, rather than asking for the "best version in all of the player's gear"

But that's just me.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/minecraft@1.21.4/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/minecraft@1.21.4/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/shotgunmod@1.0.0/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/shotgunmod@1.0.0/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/net.minecraftforge.forge@54.1.0/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
    • It just randomly stop working after a rebooted my dedicated server PLEASE HELP!   com.google.gson   Failed to start the minecraft server com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonPrimitive; at path $  
    • It was working perfectly fine last night but now I'm getting an exit code -1 with the textbox: The game crashed: rendering overlay Error: net.minecraftforge.fml.ModLoadingException: Supplementaries (supplementaries) encountered an error during the done event phase Here's the crash log: https://pastebin.com/KmesArYS Any help is apricated
    • Link to Crashlog: https://pastebin.com/bKqH9fx2 Trying to set up a custom mod pack, was going smoothly up until recently as the WorldLoader screen, (the one that appears when you select "create new world" in Singleplayer), was clicked to test that it was running fine. Most Recent Few mods added were; - Create (+ its addons) - Immersive Weathering [Forge] I've tried all I could think of since loading up the game worked fine and I've never had this issue before.  Any help is appreciated.  
    • Digging in to the source, in this case net.minecraft.world.item.Item.Properties, I see these functions are the error source:         protected String effectiveDescriptionId() {             return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));         }         public ResourceLocation effectiveModel() {             return this.model.get(Objects.requireNonNull(this.id, "Item id not set"));         } Can anyone share more information on how to set the Id properly? Is this something I have to do explicitly by calling the setId() function? My understanding is the ID is set implictly with these calls:       public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, ShotgunMod.MODID);     private static final Item.Properties p = new Item.Properties().durability(100).stacksTo(1);     public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); From net.minecraft.world.item.Item.Properties;  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } Thank you for your help
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.