Custom fluid rendering in world as water. [1.11.2]

[Zeher_Monkey]

Hi all, i have added 3 new fluids to my mod. I have their textures working in GUIs, My FluidTank, Forges Universal Bucket and JEI. However when i place down the fluid, it renders as water in world. All 3 fluids have this issue. Im unsure as to why this is happening. I have tried custom MaterialLiquid(MapColor.color), to see if that helps but that doesnt affect the texture at all. Any help is appreciated.

 

BlockState.json

Spoiler

{
    "forge-marker": 1,
    "variants": {
        "coolant": {
             "model": "forge:fluid",
             "custom": { "fluid": "coolant" }
        },
        "energized_redstone": {
             "model": "forge:fluid",
             "custom": { "fluid": "energized_redstone" }
        },
        "glowstoneinfused_magma": {
             "model": "forge:fluid",
             "custom": { "fluid": "glowstoneinfused_magma" }
        }
    }
}

 

BlockHandler.java

Spoiler

public static void registerFluidBlock(TRZBlockFluid block){
        GameRegistry.register(block);
        registerFluidModelLocation(block);
}

 

public static void registerFluidModelLocation(TRZBlockFluid fluid_block){
        Item item = Item.getItemFromBlock(fluid_block);
        
        ModelBakery.registerItemVariants(item);

        final ModelResourceLocation modelResourceLocation = new ModelResourceLocation(OreCraft.mod_id + ":" +  "block_fluids", fluid_block.getFluid().getName());
        
        ModelLoader.setCustomMeshDefinition(item, TRZMeshDefinitionFix.create(stack -> modelResourceLocation));

        ModelLoader.setCustomStateMapper((Block) fluid_block, new StateMapperBase() {
            @Override
            protected ModelResourceLocation getModelResourceLocation(IBlockState p_178132_1_) {
                return modelResourceLocation;
            }
        });
        
        GameRegistry.register(item);
    }

 

Thanks! If you need any more code, just ask and ill post it  

Edited March 4, 2018 by Zeher_Monkey

[Zeher_Monkey]

Bump

[Zeher_Monkey]

Im sorry for bumping so soon but ive been at this for hours .

Would something like this work:

 

Spoiler

public static void registerFluidModelLocation(TRZBlockFluid block) {
        Item item = Item.getItemFromBlock(block);
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(OreCraft.mod_id + ":" + "block_fluids", block.getFluid().getName()));
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(OreCraft.mod_id + block.getFluid().getName(), "normal"));
    }

 

Which could i use? If its the second one, how would i structure the .json file?

[Zeher_Monkey]

I have read that documentation. I dont fully understand it in terms of forge fluids though. 

So this for ModelLoaderRegistryEvent:

Spoiler

@SubscribeEvent
    public static void modelLoader(ModelRegistryEvent event) {
        ModelResourceLocation coolant = new ModelResourceLocation(BlockHandler.block_fluid_coolant.getFluid().getName(), "coolant");
        ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(BlockHandler.block_fluid_coolant), 0, coolant);
    }

 

And for the .json:

Spoiler

{
    "variants": {
        "coolant": { 
        "model": "forge:fluid",
            "custom": {
                "fluid": "coolant"
            }
        }
    }
}

 

Also heads up i havent started using @SubscribeEvent yet. So not entirely familiar.

Edited March 4, 2018 by Zeher_Monkey

[Zeher_Monkey]

Ok so those lines of code have caused the game to crash on startup.

 

Crash:

Spoiler

[23:23:21] [Client thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.client.event.ModelRegistryEvent@4b5ca45b:
java.lang.NullPointerException
    at com.zeher.orecraft.OreCraft.modelLoader(OreCraft.java:125) ~[OreCraft.class:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1_OreCraft_modelLoader_ModelRegistryEvent.invoke(.dynamic) ~[?:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) [EventBus.class:?]
    at net.minecraftforge.fml.client.FMLClientHandler.fireSidedRegistryEvents(FMLClientHandler.java:1105) [FMLClientHandler.class:?]
    at net.minecraftforge.fml.common.FMLCommonHandler.fireSidedRegistryEvents(FMLCommonHandler.java:762) [FMLCommonHandler.class:?]
    at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:646) [Loader.class:?]
    at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:276) [FMLClientHandler.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:478) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:387) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
[23:23:21] [Client thread/ERROR] [FML]: Index: 1 Listeners:
[23:23:21] [Client thread/ERROR] [FML]: 0: NORMAL
[23:23:21] [Client thread/ERROR] [FML]: 1: ASM: class com.zeher.orecraft.OreCraft modelLoader(Lnet/minecraftforge/client/event/ModelRegistryEvent;)V
[23:23:21] [Client thread/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:600]: ---- Minecraft Crash Report ----

 

[Zeher_Monkey]

If i change the code to this:

 

Spoiler

@SubscribeEvent
    public static void modelLoader(ModelRegistryEvent event) {
        ModelResourceLocation coolant = new ModelResourceLocation("fluid_coolant", "coolant");
        ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(BlockHandler.block_fluid_coolant), 0, coolant);
    }

 

It literally breaks all my blocks, and stops them from being registered.

[Zeher_Monkey]

Can anyone else help?

 

[Zeher_Monkey]

Im registering blocks using

GameRegistry#register(object);

In my mods

#preInit();

Function.

Would having an individual .json file fix the issue? Or is it more complicated than that?

Edited March 7, 2018 by Zeher_Monkey

[Zeher_Monkey]

1 minute ago, diesieben07 said:

Problematic code, issue 1.

Yeah i know. I haven't changed over yet because i still don't understand the registry system. I will get around to it.  

[Zeher_Monkey]

13 minutes ago, diesieben07 said:

Problematic code, issue 1.

So is that my issue? Because if so, i can wait until i update to use registry events.

[Zeher_Monkey]

7 minutes ago, diesieben07 said:

No, your issue is this:

Okay. This any better?

I still don't fully understand the .json format. I've just gleamed from open source mods and tutorials. The forge documentation is lacking imo.

Spoiler

{
    "forge-marker": 1,
    "defaults": {
        "model": "forge:fluid"
    },
    "variants": {
        "coolant": [
            {
                "custom": {
                    "fluid": "coolant"
                }
            }
        ],
        "energized_redstone": [
            {
                "custom": {
                    "fluid": "energized_redstone"
                }
            }
        ],
        "glowstoneinfused_magma": [
            {
                "custom": {
                    "fluid": "glowstoneinfused_magma"
                }
            }
        ]
    }
}

[Zeher_Monkey]

I should clarify. I understand how to lay out .json files, but all of the 

forge#'blockstate'

For example:

forge:fluid

 

A list of all forges blockstates would be nice. I havent managed to fin one yet, but if one exists ill definitely take a look.

[Zeher_Monkey]

The updated

block_fluid.json

Has caused this error:

Spoiler

[22:55:03] [Client thread/ERROR] [FML]: Exception loading model for variant orecraft:block_fluids#energized_redstone for blockstates ["orecraft:energized_redstone[level=0]", "orecraft:energized_redstone[level=1]", "orecraft:energized_redstone[level=2]", "orecraft:energized_redstone[level=3]", "orecraft:energized_redstone[level=4]", "orecraft:energized_redstone[level=5]", "orecraft:energized_redstone[level=6]", "orecraft:energized_redstone[level=7]", "orecraft:energized_redstone[level=8]", "orecraft:energized_redstone[level=9]", "orecraft:energized_redstone[level=10]", "orecraft:energized_redstone[level=11]", "orecraft:energized_redstone[level=12]", "orecraft:energized_redstone[level=13]", "orecraft:energized_redstone[level=14]", "orecraft:energized_redstone[level=15]"]
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model orecraft:block_fluids#energized_redstone with loader VariantLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:153) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader.registerVariant(ModelLoader.java:264) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadBlock(ModelBakery.java:153) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:252) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:159) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:122) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:541) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:387) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: net.minecraft.client.renderer.block.model.ModelBlockDefinition$MissingVariantException
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition.getVariant(ModelBlockDefinition.java:78) ~[ModelBlockDefinition.class:?]
    at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1257) ~[ModelLoader$VariantLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:149) ~[ModelLoaderRegistry.class:?]
    ... 21 more

[22:55:03] [Client thread/ERROR] [FML]: Exception loading blockstate for the variant orecraft:block_fluids#energized_redstone: 
java.lang.Exception: Could not load model definition for variant orecraft:block_fluids
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:297) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadBlock(ModelBakery.java:121) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:252) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:159) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:122) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:541) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:387) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.RuntimeException: Encountered an exception when loading model definition of 'orecraft:block_fluids' from: 'orecraft:blockstates/block_fluids.json' in resourcepack: 'FMLFileResourcePack:OreCraft'
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModelBlockDefinition(ModelBakery.java:246) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadMultipartMBD(ModelBakery.java:223) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:208) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:293) ~[ModelLoader.class:?]
    ... 20 more
Caused by: com.google.gson.JsonSyntaxException: Missing model, expected to find a string
    at net.minecraft.util.JsonUtils.getString(JsonUtils.java:102) ~[JsonUtils.class:?]
    at net.minecraft.client.renderer.block.model.Variant$Deserializer.getStringModel(Variant.java:130) ~[Variant$Deserializer.class:?]
    at net.minecraft.client.renderer.block.model.Variant$Deserializer.deserialize(Variant.java:93) ~[Variant$Deserializer.class:?]
    at net.minecraft.client.renderer.block.model.Variant$Deserializer.deserialize(Variant.java:87) ~[Variant$Deserializer.class:?]
    at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[TreeTypeAdapter.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:803) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:868) ~[Gson.class:?]
    at com.google.gson.Gson$1.deserialize(Gson.java:126) ~[Gson$1.class:?]
    at net.minecraft.client.renderer.block.model.VariantList$Deserializer.deserialize(VariantList.java:69) ~[VariantList$Deserializer.class:?]
    at net.minecraft.client.renderer.block.model.VariantList$Deserializer.deserialize(VariantList.java:51) ~[VariantList$Deserializer.class:?]
    at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[TreeTypeAdapter.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:803) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:868) ~[Gson.class:?]
    at com.google.gson.Gson$1.deserialize(Gson.java:126) ~[Gson$1.class:?]
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition$Deserializer.parseMapVariants(ModelBlockDefinition.java:164) ~[ModelBlockDefinition$Deserializer.class:?]
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition$Deserializer.deserialize(ModelBlockDefinition.java:141) ~[ModelBlockDefinition$Deserializer.class:?]
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition$Deserializer.deserialize(ModelBlockDefinition.java:135) ~[ModelBlockDefinition$Deserializer.class:?]
    at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[TreeTypeAdapter.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:803) ~[Gson.class:?]
    at com.google.gson.Gson.fromJson(Gson.java:741) ~[Gson.class:?]
    at net.minecraftforge.client.model.BlockStateLoader.load(BlockStateLoader.java:105) ~[BlockStateLoader.class:?]
    at codechicken.lib.model.loader.blockstate.CCBlockStateLoader.handleLoad(CCBlockStateLoader.java:42) ~[CCBlockStateLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition.parseFromReader(ModelBlockDefinition.java) ~[ModelBlockDefinition.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadModelBlockDefinition(ModelBakery.java:242) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadMultipartMBD(ModelBakery.java:223) ~[ModelBakery.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:208) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:293) ~[ModelLoader.class:?]
    ... 20 more

 

Edited March 7, 2018 by Zeher_Monkey

[Draco18s]

25 minutes ago, Zeher_Monkey said:

Caused by: com.google.gson.JsonSyntaxException: Missing model, expected to find a string

 

[Zeher_Monkey]

Yeah i dont know what thats pointing to. I have 

Spoiler

"forge-marker": 1,
    "defaults": {
        "model": "forge:fluid"
    },

So why is it saying expected string...