Getting a block's smelting recipe? (1.12)

[ThatBenderGuy]

I am currently in a conundrum where I need to get a smelting recipe for a block. The simplest way to put it is I have an item and it holds data for a block (modID and unlocalized name) as nbt tags. I want to gather what those blocks will smelt into. I have no clue if this is a job for the CraftingManager or for the OreDictionary. I have googled all over but can't find an answer. I want this to be compatible with other mods as well (at least the ones that have "ore" in their unlocalized name)

 

An example is lets say that my item has the nbt tags for "minecraft" and "tile.iron_ore". With those two pieces of data how can I obtain what a "tile.iron_ore" will smelt into?

Edited March 7, 2018 by ThatBenderGuy

[jabelar]

Can't you use FurnaceRecipes.getSmeltingList() which actually returns a Map and then just look for a key that is same as your block?

[ThatBenderGuy]

Okay several things

1. Does the FurnaceRecipes.instance().getSmeltingList() return recipes from other mods?

2. I still need to get an ItemStack object from the nbt of my item (Which is currently stores strings of the modid and the unlocalized name)

 

I figured out the for-loop to go through the FurnaceRecipes map but I need to convert the string I have on my item's NBT to a ItemStack object and I have no clue how to look up tile names and return with a ItemStack.

 

 

[jabelar]

Yes, other mods are supposed to add their recipes using FurnaceRecipes#addSmeltingRecipe() method, so I think the list should contain them all.

 

You should store the registry name not the unlocalized name (there is no guarantee they are the same). Then you can just read in the registry name and look it up in the ForgeRegistries.BLOCKS.

[ThatBenderGuy]

Alright should I use getRegistryName().toString() ?

Edited March 7, 2018 by ThatBenderGuy

[jabelar]

6 minutes ago, ThatBenderGuy said:

Alright should I use getRegistryName().toString() ?

I think so. That should include the modid automatically. When you read it back, just pass the string to a new ResourceLocation() constructor.

[ThatBenderGuy]

20 minutes ago, jabelar said:

I think so. That should include the modid automatically. When you read it back, just pass the string to a new ResourceLocation() constructor.

Okay so how does this look.

// This is when the item is generated in a different class
NBTTagCompound nbt = new NBTTagCompound();
nbt.setString("parentBlock", e.getState().getBlock().getRegistryName().toString());
ore.setTagCompound(nbt);

//This is the method to get the smelting result
private ItemStack getSmeltResult(String registryName){
	Map<ItemStack, ItemStack> smeltingRecipes = FurnaceRecipes.instance().getSmeltingList();
	ResourceLocation rLoc = new ResourceLocation(registryName);
	Block block = ForgeRegistries.BLOCKS.getValue(rLoc);
	ItemStack ISBlock = new ItemStack(block);
	for (Entry<ItemStack, ItemStack> entry : smeltingRecipes.entrySet()){
		if(entry.getKey() == ISBlock){
			return entry.getValue();
		}
	}

	return new ItemStack(Items.AIR);
}

// Then what I pass into the above method
ItemStack myItem = (ItemStack)this.inventory.get(0);
ItemStack result = getSmeltResult(myItem.getTagCompound().getString("parentBlock"));

 

Edited March 7, 2018 by ThatBenderGuy

[jabelar]

Yeah, the general idea looks correct. You might need to trace through to make sure there aren't any detailed bugs, but conceptually yes -- you take the smelting list, you grab the block from the block recipe, and iterate through the smelting list to find a match. For storing in NBT, store the registry name (and anything additional you care about like metadata) then read the NBT to restore it from registry (and restore any additional info you care about).

Edited March 7, 2018 by jabelar

[Draco18s]

8 hours ago, ThatBenderGuy said:

if(entry.getKey() == ISBlock){

This won't work. ItemStacks do not override Equals (or the == operator). You need to check
 

Item bitem = Item.getFromBlock(block);
if(entry.getKey().getIem() == bitem) {
}

 

[jabelar]

Yeah, Draco18s is right as usual -- best to compare the Item not the stack.

 

To original poster, if you do want to compare item stacks the ItemStack class has a number of methods for comparing, some that include NBT, some don't etc. There is areItemsEqual(), areItemsEqualIgnoreDurability(), areItemEqualUsingNBT() and so forth.

[ThatBenderGuy]

Alright thank you guys for all the help.

 

In order to test that the underlying mechanic is working I added a right click event to my item and used this code to see if it gets the smelt result:

String rLoc = new ResourceLocation(nbt.getString("parentBlock")).toString();
String itemResultStr = OreRefinerRecipes.getInstance().getSmeltResult(rLoc).getDisplayName();
player.sendMessage(new TextComponentString("Stored Block Smelt Result: " + itemResultStr)); 

and it returned the proper ingots  So assuming all my code elsewhere is correct then my main mechanic to my mod should work. Haven't been this excited to finish a mod in a while. Thank you all so very much

Edited March 7, 2018 by ThatBenderGuy