[1.12.2] Mod Crashes on Server, but Not Client

[RileyTheFox]

Hello there! It's been a decent time since I've worked on my mod, seeing as the changes in 1.12 broke almost everything in it. At this point, I was ecstatic as it seemed I had gotten it running again! However, I've been encountering a game-breaking issue that I can't wrap my head around enough to solve.

Whenever I start my mod within a server- even a server with only my mod- it crashes with a java.lang.NoClassDefFoundError. From what I have seen in the crash report (https://pastebin.com/ru6U5zhH) and from what I have seen browsing for an answer here on the Forge Forums, it seems as though I have made a mistake by rendering my entities server-side rather than client-side. Though I've seen that I need to render my own entities through the client proxy, I can't seem to find out exactly how I am supposed to do so due to the changes to coding in 1.12 and my own taking a break which has made me rusty. 

 

All I am asking for is some advice on what I am doing wrong, or what I should do. I am by no means "new" to coding, and I've coded this mod much further before, but I am terribly rusty and need help trying to figure out this error. 

 

The class that's giving the error according to the log is as follows.

package riley.fallenstars.utils.handlers;

import net.minecraft.client.renderer.entity.Render;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraftforge.fml.client.registry.IRenderFactory;
import net.minecraftforge.fml.client.registry.RenderingRegistry;
import riley.fallenstars.entities.EntityChinchilla;
import riley.fallenstars.entities.EntityFox;
import riley.fallenstars.entities.EntityShepherd;
import riley.fallenstars.entities.render.RenderChinchilla;
import riley.fallenstars.entities.render.RenderFox;
import riley.fallenstars.entities.render.RenderShepherd;

public class RenderHandler
{
    public static void registerEntityRenders()
    {
        RenderingRegistry.registerEntityRenderingHandler(EntityFox.class, new IRenderFactory<EntityFox>()
        {
            @Override
            public Render<? super EntityFox> createRenderFor(RenderManager renderManager)
            {
                return new RenderFox(renderManager);
            }
        });
        RenderingRegistry.registerEntityRenderingHandler(EntityChinchilla.class, new IRenderFactory<EntityChinchilla>()
        {
            @Override
            public Render<? super EntityChinchilla> createRenderFor(RenderManager renderManager)
            {
                return new RenderChinchilla(renderManager);
            }
        });
        RenderingRegistry.registerEntityRenderingHandler(EntityShepherd.class, new IRenderFactory<EntityShepherd>()
        {
            @Override
            public Render<? super EntityShepherd> createRenderFor(RenderManager renderManager)
            {
                return new RenderShepherd(renderManager);
            }
        });
    }
}

If there is anything else I should link according to the crash report or other needed info; I am more than willing to do so. A huge thank you for any help in advance, and I look forward to finding an answer so that I may finally work on restoring my little mod to it's former state.

[Draco18s]

And where do you call this code from?

[RileyTheFox]

  On 3/12/2018 at 5:33 PM, Draco18s said:

And where do you call this code from?

Expand  

Apologies. I call the RenderHandler from my Registry Handler here:
 

package riley.fallenstars.utils.handlers;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import riley.fallenstars.init.FallenStarsBlocks;
import riley.fallenstars.init.FallenStarsEntities;
import riley.fallenstars.init.FallenStarsItems;
import riley.fallenstars.utils.IHasModel;

@Mod.EventBusSubscriber
public class RegistryHandler
{
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event)
    {
        event.getRegistry().registerAll(FallenStarsItems.ITEMS.toArray(new Item[0]));
    }

    @SubscribeEvent
    public static void onBlockRegister(RegistryEvent.Register<Block> event)
    {
        event.getRegistry().registerAll(FallenStarsBlocks.BLOCKS.toArray(new Block[0]));
    }

    @SubscribeEvent
    public static void onModelRegister(ModelRegistryEvent event)
    {
        for (Item item : FallenStarsItems.ITEMS)
        {
            if (item instanceof IHasModel)
            {
                ((IHasModel)item).registerModels();
            }
        }

        for (Block block : FallenStarsBlocks.BLOCKS)
        {
            if (block instanceof IHasModel)
            {
                ((IHasModel)block).registerModels();;
            }
        }
    }

    public static void preInitRegistries()
    {
        FallenStarsEntities.registerEntities();
        RenderHandler.registerEntityRenders();
    }

    public static void initRegistries()
    {
        SoundsHandler.registerSounds();
    }
}

 

Which the "preInitRegistries()" method is then called from my main class under it's preInit. Here's the main class as well, just in case:
 

package riley.fallenstars;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import riley.fallenstars.init.FallenStarsTab;
import riley.fallenstars.proxy.CommonProxy;
import riley.fallenstars.utils.Reference;
import riley.fallenstars.utils.handlers.RegistryHandler;

@Mod(modid = Reference.MODID, name = Reference.NAME, version = Reference.VERSION)
public class FallenStars
{
    @Mod.Instance
    public static FallenStars instance;

    public static final CreativeTabs fallenstarstab = new FallenStarsTab("fallenstarstab");

    @SidedProxy(clientSide = Reference.CLIENT, serverSide = Reference.COMMON)
    public static CommonProxy proxy;

    @Mod.EventHandler
    public static void preInit(FMLPreInitializationEvent event)
    {
        RegistryHandler.preInitRegistries();
    }

    @Mod.EventHandler
    public static void init(FMLInitializationEvent event)
    {
        RegistryHandler.initRegistries();
    }

    @Mod.EventHandler
    public static void postInit(FMLPostInitializationEvent event) {}
}

 

I've been following some videos to somewhat refresh myself and to learn the changes in forge different from 1.10.2. So apologies if it's at all wrong. That's why I'm here to see, I assume I did something wrong here and I kinda understand what I did wrong but am unsure how to fix it.

[Draco18s]

You call this from common code:

  On 3/12/2018 at 5:44 PM, RileyTheFox said:

RegistryHandler.preInitRegistries();

Expand  

This calls:

  On 3/12/2018 at 5:44 PM, RileyTheFox said:

RenderHandler.registerEntityRenders();

Expand  

This calls

  On 3/12/2018 at 5:12 PM, RileyTheFox said:

RenderingRegistry.registerEntityRenderingHandler(EntityFox.class, new IRenderFactory<EntityFox>()

Expand  

which is a class located at

  On 3/12/2018 at 5:12 PM, RileyTheFox said:

import net.minecraftforge.fml.client.registry.RenderingRegistry;

Expand  

Oops, that's client side only. Server has crashed.

Edited March 12, 2018 by Draco18s

[RileyTheFox]

  On 3/12/2018 at 5:46 PM, Draco18s said:

You call this from common code:

This calls:

This calls

which is a class located at

Oops, that's client side only. Server has crashed.

Expand  

Alright, thank you so much. That actually helps me understand it a whole lot better than I was. So to fix it, would I have to change the fact that in the main class it's calling for common proxy? Or is there a better solution to this?

[RileyTheFox]

I'm very sorry for the double post. I tried fixing the issue by calling it from my ClientProxy instead though now I am met with this crash:
https://pastebin.com/bnfCpfNj

My client proxy looks like this now:

package riley.fallenstars.proxy;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;
import riley.fallenstars.utils.handlers.RenderHandler;

public class ClientProxy implements CommonProxy
{
    @Override
    public void registerItemRenderer(Item item, int meta, String id)
    {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
    }

    @Override
    public void init()
    {
        RenderHandler.registerEntityRenders();
    }
}

 

I moved the RenderHandler.registerEntityRenders() from the RegistryHandler (which from what I understand from your response was being called to the common rather than to the client) to the ClientProxy instead. I'm still unsure and am baffled as to what I'm doing wrong as I referenced my old code from 1.10 this time just to try and get an idea. I feel like that idea is wrong, unless I'm getting closer? I really can't tell at this point. 

 

Again, apologies for double-posting. Just wanted to update on what I did/tried.

[Draco18s]

No, that is correct.

[RileyTheFox]

Yes! I looked up the issue I'm having now and stupid me, I had my CommonProxy abstract by mistake! It's working perfectly now. Thank you so much for explaining it to me Draco. It was probably a stupid error on my part but it really was a lot of help.