[1.12.1] Help with 2 small errors that i dont know how to solve.

[Anonymous1611]

Hey guys,

 

I am quite unexperienced but i am learning what i can. But i cant seem to solve two errors maybe you guys can help me?

 

private boolean hasArmor(EntityPlayer player)
{
net.minecraft.item.ItemStack[] armor = player.inventory.armorInventory;
if ((armor != null) && (
	(armor[0] != null) || (armor[1] != null) || (armor[2] != null) || (armor[3] != null))) {
	return true;
}

 

net.minecraft.item.ItemStack[] armor = player.inventory.armorInventory; is giving me the following error >: cannot convert from NonNullList<ItemStack> to ItemStack[]

 

Next error

 

/*     */   public float[] getRotationsNeeded(Entity entity) {
/* 197 */     if (entity == null)
/* 198 */       return null;
/* 199 */     double diffX = entity.posX - this.mc.player.posX;
/*     */     double diffY;
/*     */     ;//double diffY;
/* 202 */     if ((entity instanceof EntityLivingBase)) {
/* 203 */       EntityLivingBase entityLivingBase = (EntityLivingBase)entity;
/*     */       
/*     */ 
/*     */ 
/*     */ 
/*     */ 
/* 209 */       diffY = entityLivingBase.posY + entityLivingBase.getEyeHeight() * 0.9D - (this.mc.player.posY + Minecraft.getMinecraft().player.getEyeHeight());
/*     */ 
/*     */     }
/*     */     else
/*     */     {
/*     */ 		
/* 215 */       diffY = (entity.boundingBox.minY + entity.boundingBox.maxY) / 2.0D - (this.mc.player.posY + Minecraft.getMinecraft().player.getEyeHeight()); }
/* 216 */     double diffZ = entity.posZ - this.mc.player.posZ;
/* 217 */     double dist = MathHelper.sqrt(diffX * diffX + diffZ * diffZ);
/*     */     
/* 219 */     float yaw = (float)(Math.atan2(diffZ, diffX) * 180.0D / 3.141592653589793D) - 90.0F;
/* 220 */     float pitch = (float)-(Math.atan2(diffY, dist) * 180.0D / 3.141592653589793D);
/* 221 */     return new float[] {this.mc.player.rotationYaw + 
/*     */     
/* 223 */       MathHelper.wrapDegrees(yaw - this.mc.player.rotationYaw), this.mc.player.rotationPitch + 
/*     */       
/*     */ 
/* 226 */       MathHelper.wrapDegrees(pitch - this.mc.player.rotationPitch) };
/*     */   }

diffY = (entity.boundingBox.minY + entity.boundingBox.maxY) / 2.0D - (this.mc.player.posY + Minecraft.getMinecraft().player.getEyeHeight()); } is giving me "The field Entity.boundingBox is not visible".

 

Thanks!

 

 

[jabelar]

I know is sometimes sounds mean to tell people "learn Java". But your problems really are simple Java things that have not much to do with modding specifically. So I really suggest learning Java more solidly. I suggest a very good, simple book called Java In Easy Steps. I like the book because it is very short but still covers the major topics. So you can get through it quickly, and it isn't boring or "scary" like some of those "Java for Dummies" types of books.

 

Your first problem is very clear, you're trying to assign a type to a value that is not of that type. The return type of the armor inventory is a NonNullList<ItemStack> and you're trying to put that value into an ItemStack[] (an array of ItemStack). If you really need an array you can convert -- in fact the NonNullList probably has a method to help you do that. But you can also just keep it as a NonNullList and use list type of methods for looping through and checking values.

 

Your second problem is also very clear, you are trying to use a field or method which does not have public scope. That means you cannot access it from outside the class (or package or hierarchy depending on what the scope actually is). You really need to study the concept of scope in programming. In particular Java has public, protected, private (plus some other cases like local) that can control "visibility". To fix this problem, the first thing you need to do is see if there is a public "getter" method for the private field. For example, maybe there is a getBoundingBox() or similar method available. 

[Draco18s]

3 hours ago, Anonymous1611 said:

Entity.boundingBox is not visible

This used to be a public value and now it's private. There should be a getter function, if not, you can use reflection.

3 hours ago, Anonymous1611 said:

cannot convert from NonNullList<ItemStack> to ItemStack[]

The type changed from one version to another when ItemStacks were made to never be allowed to be null (instead using .isEmpty() so that zero-size stacks weren't treated as items, but rather nothing). You'll need to update your code to match the new system.