Having trouble getting item textures to work

[Xeraster]

I'm having a lot of trouble getting item textures to work. I'm on McForge for 1.12.2. It's for a record, the kind that goes in a jukebox, to be exact. I am able to use console logging to see that my unlocalized name is "item.record.starrecord" and registry name is "supertnt:record.starrecord". The problem is that it shows the purple and black "untextured" texture instead of what I'm trying to display.

 

I thought it was a json problem at first but after trying a lot of stuff, it might be a code problem. It would be easier to narrow it down if I knew the correct json file arrangement for 1.12.2 for items but here is what I have right now:

record.starrecord.json located in supertnt/models/item

{
    "parent": "item/generated",
    "textures": {
        "layer0": "supertnt:items/record.starrecord"
    }
}

Here is the file located in supertnt/blockstates/record.starrecord.json. Note that I have tried it both with and without this file present and niether of them work.

{
	"forge_marker": 1,
	"defaults": {
		"model": "supertnt:item/record.starrecord"
	},
	"variants": {
		"normal": [ { } ],
		"inventory": [
			{
				"transform": "supertnt:item/record.starrecord"
			}
		]
	}
}

 

Here is my item initialization code:

 

Here is where I initialize the model resource location for my item

@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public static void onRegisterModels(ModelRegistryEvent event) {	
		ModelLoader.setCustomModelResourceLocation(Items.STARRECORD, 0, new ModelResourceLocation("starrecord", "inventory"));
		System.out.println("record registry name is = " + Items.STARRECORD.getRegistryName());
		System.out.println("record unlocalized name is = " + Items.STARRECORD.getUnlocalizedName());
}

 

Here is where I set up the item:

@ObjectHolder(SuperTNTMod.MODID)
public class Items {
	
	public static final StarRecord STARRECORD = new StarRecord("starrecord", SoundHandler.ACROSSTHESTARS2);


	@Mod.EventBusSubscriber(modid = SuperTNTMod.MODID)
	public static class RegistrationHandler {
		public static final StarRecord STARRECORD = new StarRecord("starrecord", SoundHandler.ACROSSTHESTARS2);
		public static final Set<Item> ITEMS = new HashSet<>();

		/**
		 * Register this mod's {@link Item}s.
		 *
		 * @param event The event
		 */
		
		@SubscribeEvent
		public static void registerItems(final RegistryEvent.Register<Item> event) {


			final IForgeRegistry<Item> registry = event.getRegistry();
			final Item[] items = {STARRECORD};
			registry.registerAll(items);

		}
	}
	@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public static void onRegisterModels(ModelRegistryEvent event) {
		ModelLoader.setCustomModelResourceLocation(STARRECORD, 0, new ModelResourceLocation("starrecord", "inventory"));
		System.out.println("record registry name is = " + STARRECORD.getRegistryName());
		System.out.println("record unlocalized name is = " + STARRECORD.getUnlocalizedName());
}
}

And then here is the class file for my item just in case:

ublic class StarRecord extends ItemRecord
{
    private static final Map<SoundEvent, ItemRecord> RECORDS = Maps.<SoundEvent, ItemRecord>newHashMap();
    private final SoundEvent sound;
    private final String displayName;

    public StarRecord(String p_i46742_1_, SoundEvent soundIn)
    {
    	super(p_i46742_1_, soundIn);
        this.displayName = "record." + p_i46742_1_;
        this.setRegistryName(displayName);
        this.setUnlocalizedName(displayName);
        this.sound = soundIn;
        this.maxStackSize = 1;
        this.setCreativeTab(CreativeTabs.MISC);
        RECORDS.put(this.sound, this);
    }

    /**
     * Called when a Block is right-clicked with this Item
     */
    public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
    {
        IBlockState iblockstate = worldIn.getBlockState(pos);

        if (iblockstate.getBlock() == Blocks.JUKEBOX && !((Boolean)iblockstate.getValue(BlockJukebox.HAS_RECORD)).booleanValue())
        {
            if (!worldIn.isRemote)
            {
                ItemStack itemstack = player.getHeldItem(hand);
                ((BlockJukebox)Blocks.JUKEBOX).insertRecord(worldIn, pos, iblockstate, itemstack);
                worldIn.playEvent((EntityPlayer)null, 1010, pos, Item.getIdFromItem(this));
                itemstack.shrink(1);
                player.addStat(StatList.RECORD_PLAYED);
            }

            return EnumActionResult.SUCCESS;
        }
        else
        {
            return EnumActionResult.PASS;
        }
    }

    /**
     * allows items to add custom lines of information to the mouseover description
     */
    @SideOnly(Side.CLIENT)
    public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn)
    {
        tooltip.add(this.getRecordNameLocal());
    }

    @SideOnly(Side.CLIENT)
    public String getRecordNameLocal()
    {
        return I18n.translateToLocal(this.displayName);
    }

    /**
     * Return an item rarity from EnumRarity
     */
    public EnumRarity getRarity(ItemStack stack)
    {
        return EnumRarity.RARE;
    }

    @Nullable
    @SideOnly(Side.CLIENT)
    public static ItemRecord getBySound(SoundEvent soundIn)
    {
        return RECORDS.get(soundIn);
    }

    @SideOnly(Side.CLIENT)
    public SoundEvent getSound()
    {
        return this.sound;
    }
}

If someone can find the problem and point it out and how to fix it, I would greatly appreciate the help.

Thanks in advance.

[DaemonUmbra]

Haven't made items in a while but I think your issue is you should be using "supertnt:starrecord" rather than just "starrecord", if I'm wrong someone else please correct me.

Edit: I recommend using hardcoded values as little as possible getRegistryName() is preferable.

Edit 2: I can't test at the moment but the tip from my first edit may require use of the @ObjectHolder annotation

Edited April 4, 2018 by DaemonUmbra

[hiotewdew]

@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public static void onRegisterModels(ModelRegistryEvent event) {	
		ModelLoader.setCustomModelResourceLocation(Items.STARRECORD, 0, new ModelResourceLocation("starrecord", "inventory"));
		System.out.println("record registry name is = " + Items.STARRECORD.getRegistryName());
		System.out.println("record unlocalized name is = " + Items.STARRECORD.getUnlocalizedName());
}

This needs to be new ModelResourceLocation("record.starrecord", "inventory").

Edited April 4, 2018 by hiotewdew

[hiotewdew]

Also, I would heavily suggest embedding an InitModel function within your block classes.

@SideOnly(Side.CLIENT)
	public void initModel() {
		ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(this), 0, new ModelResourceLocation(getRegistryName(), "inventory"));
	}

That way when you run onRegsiterModels, you can just call

Items.STARRECORD.initModel();

 

 

Also, blockstates aren't used for items! Only models are nessecary. Don't worry about a blockstate json.

[Xeraster]

On 4/4/2018 at 12:04 AM, DaemonUmbra said:

Haven't made items in a while but I think your issue is you should be using "supertnt:starrecord" rather than just "starrecord", if I'm wrong someone else please correct me.

Edit: I recommend using hardcoded values as little as possible getRegistryName() is preferable.

Edit 2: I can't test at the moment but the tip from my first edit may require use of the @ObjectHolder annotation

You are right. It was a typo and I needed to change my item registration to:

ModelLoader.setCustomModelResourceLocation(STARWARSRECORD, 0, new ModelResourceLocation("supertnt:record.starrecord", "inventory"));

rather than

ModelLoader.setCustomModelResourceLocation(STARWARSRECORD, 0, new ModelResourceLocation("record.starrecord", "inventory"));

 

And thanks for pointing out the stuff about @SideOnly and @SidedProxy. I'll look into changing that when I get a chance to.

Edited April 9, 2018 by Xeraster