I have an entity that tries to find a block, in this case wood, to mine and use for other purposes. I thought of checking every single block in a 5x5x5* area (above ground), but I quickly noticed it would slow my game to a snail's pace. How could I optimize my block-checking?

 

EDIT: *4x4x4

Edited April 12, 20187 yr by OBCLetter

Something is very wrong with your code if a 5x5x5 region (125 blocks) takes that long to scan. It should take less than 400,000 nanos (0.4 ms) to scan 20,000 blocks (and do nothing).

 

Show your code.

Edited April 12, 20187 yr by Draco18s

I think I may have done something completely wrong:

	@Override
	public boolean shouldExecute() {
		boolean output = false;
		BlockPos position = soldier.getPosition();
		for (int i = position.getX() + 2; i > position.getX() - 2; i--) {
			for (int j = position.getZ() + 2; i > position.getZ() - 2; j--) {
				for (int k = position.getY() + 2; i > position.getY() - 2; k--) {
					BlockPos foundBlockPos = new BlockPos(i + position.getX(), k + position.getY(),
							j + position.getZ());
					if (world.getBlockState(foundBlockPos).equals(stateToFind)) {
						output = true;
						soldier.wantsToGoTo = foundBlockPos;
					}
				}
			}
		}
		return output;
	}

 

Edited April 12, 20187 yr by OBCLetter

you made a typo in your loop. when you cut and pasted you left the second limit as "i" in all the loops, when it should be "j" and "k".

Also:

 

BlockPos.getAllInBox(...) is a thing.

Just now, Draco18s said:

Also:

 

BlockPos.getAllInBox(...) is a thing.

 

5 minutes ago, jabelar said:

you made a typo in your loop. when you cut and pasted you left the second limit as "i" in all the loops, when it should be "j" and "k".

You guys are life-savers.