[1.8] [Event] KeyBinding is not working

[SkelletonX]

I'm trying to do that when a player presses the Key_P and Key_H button do something.

Events are being correctly registered (keyBindings).

 

KeybindHandler.java:

package com.skelletonx.MacroSK.handler;

import org.lwjgl.input.Keyboard;

import com.skelletonx.MacroSK.util.LogHelper;

import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.client.registry.ClientRegistry;

public class KeybindHandler {
	
	public static KeyBinding[] keyBindings;
	
    public static void init() {
        
    	keyBindings = new KeyBinding[2]; 
    	  
    	// instantiate the key bindings
    	keyBindings[0] = new KeyBinding("MacroSK Shop", Keyboard.KEY_P, "key.magicbeans.category");
    	keyBindings[1] = new KeyBinding("MacroSK Shop2", Keyboard.KEY_H, "key.magicbeans.category");
    	  
    	// register all the key bindings
    	for (int i = 0; i < keyBindings.length; ++i) 
    	{
    	    ClientRegistry.registerKeyBinding(keyBindings[i]);
    	    LogHelper.info("KeyBinding register OK");
    	}
    }

}

ButtonClickEvent.java:

package com.skelletonx.MacroSK.handler;

import com.skelletonx.MacroSK.util.LogHelper;
import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.InputEvent.KeyInputEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.fml.common.eventhandler.EventPriority;

public class ButtonClickEvent {
	
	@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority= EventPriority.NORMAL, receiveCanceled=true)
	public static void onEvent(KeyInputEvent event) {
		
	    KeyBinding[] keyBindings = KeybindHandler.keyBindings;
	    
	    if (keyBindings[0].isKeyDown()) 
	    {
	        // DEBUG
	        LogHelper.info("Key binding ="+keyBindings[0].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	        Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	    if (keyBindings[1].isKeyDown()) 
	    {
	        // DEBUG
	    	LogHelper.info("Key binding ="+keyBindings[1].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	    	Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	}
}

ClientProxy.java:

package com.skelletonx.MacroSK.proxy;

import com.skelletonx.MacroSK.handler.ButtonClickEvent;
import com.skelletonx.MacroSK.handler.KeybindHandler;
import net.minecraftforge.common.MinecraftForge;


public class ClientProxy extends CommonProxy{

    public void registerClient(){
    	KeybindHandler.init();
        MinecraftForge.EVENT_BUS.register(ButtonClickEvent.class);
    }
}

my class Main:

 

package com.skelletonx.MacroSK;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import com.skelletonx.MacroSK.proxy.*;


@Mod(modid = MacroSK.MODID, version = MacroSK.VERSION)
public class MacroSK
{
    public static final String MODID = "MacroSK";
    public static final String VERSION = "1.0";
    public static final String COMMON_PROXY ="com.skelletonx.MacroSK.proxy.CommonProxy";
    public static final String CLIENT_PROXY ="com.skelletonx.MacroSK.proxy.ClientProxy";
    
    @SidedProxy(clientSide=CLIENT_PROXY, serverSide=COMMON_PROXY)
    public static CommonProxy proxy;
    
    @Mod.EventHandler
    public void PreInit(FMLInitializationEvent event) {
    	
    	
    }
    @Mod.EventHandler
    public void init(FMLInitializationEvent event) {
        proxy.registerClient();
        proxy.globalRegister();
    }

    @Mod.EventHandler
    public void postInit(FMLPostInitializationEvent event) {
    	
    }
}

When I press the buttons nothing happens.

it looks like the event does not work... , What did I do wrong ?

I'm using the tutorial from @jabelar

 

[Draco18s]

Why did you start a new thread?

[SkelletonX]

@Draco18s I asked the staff to delete the old one it is disorganized

Can you help me with this?

[jabelar]

In my tutorial I said that the KeyInputEvent was fired on the FML event bus. You can see based on your import that it is from the FML packages. So you need to register your event handling class to that bus, not the main bus which you registered to.

Edited April 16, 2018 by jabelar

[SkelletonX]

@jabelar I can not create a class for the registerKeyBinding and call it on the ClientProxy?

[SkelletonX]

@jabelar my new KeybindHandler

package com.skelletonx.MacroSK.handler;

import org.lwjgl.input.Keyboard;

import com.skelletonx.MacroSK.util.LogHelper;
import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.InputEvent.KeyInputEvent;
import net.minecraftforge.fml.client.registry.ClientRegistry;
import net.minecraftforge.fml.common.eventhandler.EventPriority;

public class KeybindHandler {
	
	public static KeyBinding[] keyBindings;
	private final Minecraft mc;

	public KeybindHandler(Minecraft mc) {
		this.mc = mc;
		
		keyBindings = new KeyBinding[2]; 
		  
		// instantiate the key bindings
		keyBindings[0] = new KeyBinding("key.structure.desc", Keyboard.KEY_P, "key.magicbeans.category");
		keyBindings[1] = new KeyBinding("key.hud.desc", Keyboard.KEY_H, "key.magicbeans.category");
		  
		// register all the key bindings
		for (int i = 0; i < keyBindings.length; ++i) 
		{
		    ClientRegistry.registerKeyBinding(keyBindings[i]);
		    LogHelper.info("Register KeyBindings >> " + keyBindings[i]);
		}
	}
	
	@SubscribeEvent(priority= EventPriority.HIGH)
	public void onEvent(KeyInputEvent event) {
		
		LogHelper.info("onEvent");
	    KeyBinding[] keyBindings = KeybindHandler.keyBindings;
	    
	    if (keyBindings[0].isPressed()) 
	    {
	        // DEBUG
	        LogHelper.info("Key binding ="+keyBindings[0].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	        Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	    if (keyBindings[1].isKeyDown()) 
	    {
	        // DEBUG
	    	LogHelper.info("Key binding ="+keyBindings[1].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	    	Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	}
}

register my Handler in pre int (my main class)

    @Mod.EventHandler
    public void PreInit(FMLInitializationEvent event) {
    	
    	MinecraftForge.EVENT_BUS.register(new KeybindHandler(mc));
    }

When I go to test, it does not work again ...