Jump to content

[1.8] [Event] KeyBinding is not working


SkelletonX

Recommended Posts

I'm trying to do that when a player presses the Key_P and Key_H button do something.

Events are being correctly registered (keyBindings).

 

KeybindHandler.java:

package com.skelletonx.MacroSK.handler;

import org.lwjgl.input.Keyboard;

import com.skelletonx.MacroSK.util.LogHelper;

import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.client.registry.ClientRegistry;

public class KeybindHandler {
	
	public static KeyBinding[] keyBindings;
	
    public static void init() {
        
    	keyBindings = new KeyBinding[2]; 
    	  
    	// instantiate the key bindings
    	keyBindings[0] = new KeyBinding("MacroSK Shop", Keyboard.KEY_P, "key.magicbeans.category");
    	keyBindings[1] = new KeyBinding("MacroSK Shop2", Keyboard.KEY_H, "key.magicbeans.category");
    	  
    	// register all the key bindings
    	for (int i = 0; i < keyBindings.length; ++i) 
    	{
    	    ClientRegistry.registerKeyBinding(keyBindings[i]);
    	    LogHelper.info("KeyBinding register OK");
    	}
    }

}

ButtonClickEvent.java:

package com.skelletonx.MacroSK.handler;

import com.skelletonx.MacroSK.util.LogHelper;
import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.InputEvent.KeyInputEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.fml.common.eventhandler.EventPriority;

public class ButtonClickEvent {
	
	@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority= EventPriority.NORMAL, receiveCanceled=true)
	public static void onEvent(KeyInputEvent event) {
		
	    KeyBinding[] keyBindings = KeybindHandler.keyBindings;
	    
	    if (keyBindings[0].isKeyDown()) 
	    {
	        // DEBUG
	        LogHelper.info("Key binding ="+keyBindings[0].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	        Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	    if (keyBindings[1].isKeyDown()) 
	    {
	        // DEBUG
	    	LogHelper.info("Key binding ="+keyBindings[1].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	    	Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	}
}

ClientProxy.java:

package com.skelletonx.MacroSK.proxy;

import com.skelletonx.MacroSK.handler.ButtonClickEvent;
import com.skelletonx.MacroSK.handler.KeybindHandler;
import net.minecraftforge.common.MinecraftForge;


public class ClientProxy extends CommonProxy{

    public void registerClient(){
    	KeybindHandler.init();
        MinecraftForge.EVENT_BUS.register(ButtonClickEvent.class);
    }
}

my class Main:

 

package com.skelletonx.MacroSK;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import com.skelletonx.MacroSK.proxy.*;


@Mod(modid = MacroSK.MODID, version = MacroSK.VERSION)
public class MacroSK
{
    public static final String MODID = "MacroSK";
    public static final String VERSION = "1.0";
    public static final String COMMON_PROXY ="com.skelletonx.MacroSK.proxy.CommonProxy";
    public static final String CLIENT_PROXY ="com.skelletonx.MacroSK.proxy.ClientProxy";
    
    @SidedProxy(clientSide=CLIENT_PROXY, serverSide=COMMON_PROXY)
    public static CommonProxy proxy;
    
    @Mod.EventHandler
    public void PreInit(FMLInitializationEvent event) {
    	
    	
    }
    @Mod.EventHandler
    public void init(FMLInitializationEvent event) {
        proxy.registerClient();
        proxy.globalRegister();
    }

    @Mod.EventHandler
    public void postInit(FMLPostInitializationEvent event) {
    	
    }
}

When I press the buttons nothing happens.

it looks like the event does not work... , What did I do wrong ?

I'm using the tutorial from @jabelar

 

Link to comment
Share on other sites

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

In my tutorial I said that the KeyInputEvent was fired on the FML event bus. You can see based on your import that it is from the FML packages. So you need to register your event handling class to that bus, not the main bus which you registered to.

Edited by jabelar
  • Thanks 1

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

@jabelar my new KeybindHandler

package com.skelletonx.MacroSK.handler;

import org.lwjgl.input.Keyboard;

import com.skelletonx.MacroSK.util.LogHelper;
import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.InputEvent.KeyInputEvent;
import net.minecraftforge.fml.client.registry.ClientRegistry;
import net.minecraftforge.fml.common.eventhandler.EventPriority;

public class KeybindHandler {
	
	public static KeyBinding[] keyBindings;
	private final Minecraft mc;

	public KeybindHandler(Minecraft mc) {
		this.mc = mc;
		
		keyBindings = new KeyBinding[2]; 
		  
		// instantiate the key bindings
		keyBindings[0] = new KeyBinding("key.structure.desc", Keyboard.KEY_P, "key.magicbeans.category");
		keyBindings[1] = new KeyBinding("key.hud.desc", Keyboard.KEY_H, "key.magicbeans.category");
		  
		// register all the key bindings
		for (int i = 0; i < keyBindings.length; ++i) 
		{
		    ClientRegistry.registerKeyBinding(keyBindings[i]);
		    LogHelper.info("Register KeyBindings >> " + keyBindings[i]);
		}
	}
	
	@SubscribeEvent(priority= EventPriority.HIGH)
	public void onEvent(KeyInputEvent event) {
		
		LogHelper.info("onEvent");
	    KeyBinding[] keyBindings = KeybindHandler.keyBindings;
	    
	    if (keyBindings[0].isPressed()) 
	    {
	        // DEBUG
	        LogHelper.info("Key binding ="+keyBindings[0].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	        Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	    if (keyBindings[1].isKeyDown()) 
	    {
	        // DEBUG
	    	LogHelper.info("Key binding ="+keyBindings[1].getKeyDescription());
	            
	        // do stuff for this key binding here
	        // remember you may need to send packet to server
	    	Minecraft.getMinecraft().thePlayer.sendChatMessage(" TEST ");
	    }
	}
}

register my Handler in pre int (my main class)

    @Mod.EventHandler
    public void PreInit(FMLInitializationEvent event) {
    	
    	MinecraftForge.EVENT_BUS.register(new KeybindHandler(mc));
    }
When I go to test, it does not work again ...

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • file:///C:/Users/Danie/Downloads/Capture.JPG I keep experiencing this error, does anyone know how to fix it here is the report: file:///C:/Users/Danie/AppData/Roaming/.minecraft/crash-reports/Bug_report1.txt
    • Hi, i am unable to join a multiplayer server my friend and i created. We started it with some mods then decided to add some others and this is when the error appeared. We are using Curseforge, the server is in 1.20.1 . The full error message is "Internal Exception: io.netty.handler.codec.DecoderException: java.lang.ArrayIndexOutOfBoundsException: Index 17196645 out of bounds for length 13" I am the only one with that issue, my friends can log in and out no problem. I have tried switching minecraft account but that doesn't help so i guess the bug is on my side. We use the same mod profile so i know the error doesn't come from there. Here is the latest.log file https://pastebin.com/X6J9Fnnf. If you need more informations to try and investigate, please let me know. Big thanks to anyone that will try to help
    • [00:02:07] [main/ERROR]: Missing or unsupported mandatory dependencies:     Mod ID: 'kotlinforforge', Requested by: 'flightlib', Expected range: '[4.3.0,)', Actual version: '[MISSING]'     Mod ID: 'terrablender', Requested by: 'biomesoplenty', Expected range: '[2.2.0.154,)', Actual version: '[MISSING]'     Mod ID: 'geckolib', Requested by: 'cakescosmetics', Expected range: '[4.4,)', Actual version: '[MISSING]'     Mod ID: 'balm', Requested by: 'waystones', Expected range: '[7.2.0,)', Actual version: '[MISSING]'     Mod ID: 'oculus', Requested by: 'irisflw', Expected range: '[1.6.15,)', Actual version: '[MISSING]'     Mod ID: 'cupboard', Requested by: 'betterfpsdist', Expected range: '[1.20.1-1.5,)', Actual version: '[MISSING]' [00:02:53] [main/WARN]: Mod file C:\Users\ezkid\AppData\Roaming\.minecraft\libraries\net\minecraftforge\fmlcore\1.20.1-47.2.32\fmlcore-1.20.1-47.2.32.jar is missing mods.toml file [00:02:54] [main/WARN]: Mod file C:\Users\ezkid\AppData\Roaming\.minecraft\libraries\net\minecraftforge\javafmllanguage\1.20.1-47.2.32\javafmllanguage-1.20.1-47.2.32.jar is missing mods.toml file [00:02:54] [main/WARN]: Mod file C:\Users\ezkid\AppData\Roaming\.minecraft\libraries\net\minecraftforge\lowcodelanguage\1.20.1-47.2.32\lowcodelanguage-1.20.1-47.2.32.jar is missing mods.toml file [00:02:54] [main/WARN]: Mod file C:\Users\ezkid\AppData\Roaming\.minecraft\libraries\net\minecraftforge\mclanguage\1.20.1-47.2.32\mclanguage-1.20.1-47.2.32.jar is missing mods.toml file [00:02:65] [main/ERROR]: Skipping early mod setup due to previous error
    • Guns and more cool stuff
    • nvm i did it, turn out i just needed to install a drive or smth
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.