Item Drop from Block

[xTekBlue]

I have been working on a glowstone like block but i cant seem to get the block to drop the item i want it to when its broken. Also i cant seem to control the amount of that item to be dropped when its broken. I would like for the block to drop 2-4 of the item when broken randomly.

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import xtekblue.mod.init.ItemInit;

public class BlockRGLit extends BlockBase {

	private final int dropAmount = 1;

	public BlockRGLit(String name) {
		super(name, Material.REDSTONE_LIGHT);
		
		setSoundType(SoundType.GLASS);
		setHardness(0.5F);
		setLightLevel(8.0F);
		setResistance(1.5F);
	}

	//No idea if these even works because i haven't seemed to figure out how to get the items to be dropped when the block is broken.
	public int quantityDropped(Random random)
	{
	            return dropAmount;
	}

}

 

[Draco18s]

You probably want to override another method. One that says "this is the item that's dropped." Like how Glowstone and Redstone Ore do.

[xTekBlue]

1 hour ago, Draco18s said:

You probably want to override another method. One that says "this is the item that's dropped." Like how Glowstone and Redstone Ore do.

I've tried that but i've seen in other posts that override does not work and is actually recommended to no do it.

[xTekBlue]

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import xtekblue.mod.init.ItemInit;

public class BlockRGLit extends BlockBase {

	public BlockRGLit(String name) {
		super(name, Material.REDSTONE_LIGHT);
		
		setSoundType(SoundType.GLASS);
		setHardness(0.5F);
		setLightLevel(8.0F);
		setResistance(1.5F);
	}

	/**
	* Returns the quantity of items to drop on block destruction.
	*/
	public int quantityDropped(Random p_149745_1_)
	{
		return 4;
	}

	public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
	{
		return Item.getItemFromBlock(this);
	}
	

}

This is the code i am currently testing but i have noticed that the quantityDropped is working but the getItemDropped is not exactly. I have tried setting the Item.getItemFromBlock() to ItemInit.MIX_REDSTONE_GLOWSTONE but that doesnt seem to change the item being dropped. 

[Draco18s]

Put @override on the method you are overriding. If Eclipse says "this isn't overriding anything" then you have the wrong method signature. The fix is not to remove the annotation, but to fix the method signature so it DOES override something.

 

As for Item.getItemFromBlock(this);, that will make the block drop itself. If you want it to drop a different thing, you tell it to drop a different thing. ItemInit.MIX_REDSTONE_GLOWSTONE sounds like your custom drop, so use that.

[xTekBlue]

That's just it, when i @override on the method i'm using it doesn't say "this isn't overriding anything" it says to add it to my blockbase class. but if i do this, it will drop that item for all the blocks i have created. Correct?

Should i be overriding this?

//This says to override this method you need to implement a supertype
@Override	
public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
	{
		return ItemInit.MIX_REDSTONE_GLOWSTONE;
	}

 

Edited April 16, 2018 by xTekBlue

[Draco18s]

1 hour ago, xTekBlue said:

//This says to override this method you need to implement a supertype

That would be "your method signature is wrong" as I said.

[xTekBlue]

2 hours ago, Draco18s said:

That would be "your method signature is wrong" as I said.

Okay so i changed a few things and i have no idea what i'm doing so bare with me

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import xtekblue.mod.Main;
import xtekblue.mod.init.ItemInit;
import xtekblue.mod.util.IHasExtra;
import xtekblue.mod.util.IHasModel;

public class BlockRGLit extends BlockBase implements IHasExtra{


	public BlockRGLit(String name) {
		super(name, Material.REDSTONE_LIGHT);
		
		setSoundType(SoundType.GLASS);
		setHardness(0.5F);
		setLightLevel(8.0F);
		setResistance(1.5F);
	}

	/**
	* Returns the quantity of items to drop on block destruction.
	*/
	public int quantityDropped(Random p_149745_1_)
	{
		return 4;
	}

	@Override
	public Item getItemDropped(int par1, Random rand, int par2) {
		return ItemInit.MIX_REDSTONE_GLOWSTONE;
	}
	

}

So i implemented IHasExtra (Interface) which looks like this to remove the @Override ERROR

package xtekblue.mod.util;

import java.util.Random;

import net.minecraft.item.Item;

public interface IHasExtra {

	Item getItemDropped(int par1, Random rand, int par2);

}

Still does not seem to work. I have tried about 100 different combinations of moving stuff to different places, i'm new with java and used to doing Lua. I am trying to learn java the same way i learned Java (Self taught with help of the internet) Thanks for helping me thus far.

Edited April 17, 2018 by xTekBlue

[Draco18s]

 

Jesus Christ

 

YOU NEED TO OVERRIDE THE CORRECT METHOD FROM THE BLOCK CLASS.

[DaemonUmbra]

Would you mind posting your BlockBase class or possibly putting your mod on github and linking it?

Took me too long to boot up my own IDE and notice the signature disparity

Edited April 17, 2018 by DaemonUmbra

[xTekBlue]

I am so bad at this xD. Figured it out and from this i will learn. Thank you so much with struggling to help me do this. Especially without just saying the right code. <3

	@Override
	public Item getItemDropped(IBlockState state, Random rand, int fortune) {
	    return ItemInit.MIX_REDSTONE_GLOWSTONE;
	}