[SOLVED] Playing sounds causes ConcurrentModificationException

[leduyquang753]

So I am making a Forge 1.12 mod that can play note block song (.nbs) files. But when I tried to play note block sounds to the client:

 

String name = Instrument.getInstrument(note.getInstrument()); // One of "block.note.harp", "block.note.bass", "block.note.basedrum",...
float pitch = (float)Math.pow(2.0D, (double)(note.getKey - 45) / 12.0D);  // Ranges from 1 to 2.
Minecraft.getMinecraft().player.playSound(new SoundEvent(new ResourceLocation("minecraft", name)), 1F, pitch);

 

it throws ConcurrentModificationException:

[8 | 22/4/2018 14h07:55] [main/FATAL]: Unreported exception thrown!
java.util.ConcurrentModificationException: null
	at com.google.common.collect.HashBiMap$Itr.hasNext(HashBiMap.java:401) ~[guava-21.0.jar:?]
	at net.minecraft.client.audio.SoundManager.updateAllSounds(SoundManager.java:272) ~[SoundManager.class:?]
	at net.minecraft.client.audio.SoundHandler.update(SoundHandler.java:297) ~[SoundHandler.class:?]
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1983) ~[Minecraft.class:?]
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1186) ~[Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:441) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:25) [start/:?]

 

Another thing to note is the mod plays multiple sounds at once.

Is this the right way to play multiple sounds in Forge? Or is there another way to handle this?

Edited April 24, 2018 by leduyquang753
Solved thanks to @diesieben07.

[diesieben07]

You are most likely reaching across logical sides.

[leduyquang753]

So I need to do the stuff in SidedProxy to prevent this?

[jabelar]

32 minutes ago, leduyquang753 said:

So I need to do the stuff in SidedProxy to prevent this?

Yes

[diesieben07]

38 minutes ago, leduyquang753 said:

So I need to do the stuff in SidedProxy to prevent this?

No. @SidedProxy is for differentiating between physical sides. You have a problem with logical sides.

[leduyquang753]

So when I called EntityPlayerSP#playSound, it was run on both logical sides?

[Cadiboo]

4 minutes ago, leduyquang753 said:

So when I called EntityPlayerSP#playSound, it was run on both logical sides?

pretty much, you should be able to just surround your code with an world.isRemote check

[leduyquang753]

I tried surrounding my code with World#isRemote on both Minecraft.player.world and Minecraft.world but it still crashes... Super confused.

[Draco18s]

13 minutes ago, leduyquang753 said:

I tried surrounding my code with World#isRemote on both Minecraft.player.world and Minecraft.world but it still crashes... Super confused.

Both of those are client side only. As soon as the server tries to load the Minecraft class, it fails to find it.

You're already being passed a world object, somewhere. Post more of your code.

[leduyquang753]

Here is the whole source with a slightly modified version of xxmicloxx's Note Block API.

NBS-Player.zip

The classes worth seeing are cf.leduyquang753.nbsplayer.Main, com.xxmicloxx.NoteBlockAPI.SongPlayer / NoteBlockSongPlayer / SongPlayer, the class NoteBlockSongPlayer is the class that is making errors...

[Draco18s]

I am not downloading a zip file.

Post your code on GitHub.

[leduyquang753]

Were you serious? You won't read my code just because it's in a ZIP?

[diesieben07]

2 minutes ago, leduyquang753 said:

Were you serious? You won't read my code just because it's in a ZIP?

Yes. Post your code properly, not as a download.

[leduyquang753]

Uhhh here is its repo:

https://github.com/leduyquang753/NBS-Player

Somehow my router reset thrice while I was doing this... :(((

Edited April 23, 2018 by leduyquang753

[Draco18s]

https://github.com/leduyquang753/NBS-Player/blob/master/src/main/java/com/xxmicloxx/NoteBlockAPI/SongPlayer.java#L85

 

You're creating your own threads?

Yeah, that won't create problems, ever.

[diesieben07]

• You can't do this. Your class file is now invalid, since it contains unimplemented abstract methods.
• You cannot interact with most of Minecraft's code from different threads. You must use the main thread.
• Do not use a sleeping thread for delays, count ticks instead.