Jump to content

Recommended Posts

Posted (edited)

So I am making a Forge 1.12 mod that can play note block song (.nbs) files. But when I tried to play note block sounds to the client:

 

String name = Instrument.getInstrument(note.getInstrument()); // One of "block.note.harp", "block.note.bass", "block.note.basedrum",...
float pitch = (float)Math.pow(2.0D, (double)(note.getKey - 45) / 12.0D);  // Ranges from 1 to 2.
Minecraft.getMinecraft().player.playSound(new SoundEvent(new ResourceLocation("minecraft", name)), 1F, pitch);

 

it throws ConcurrentModificationException:

[8 | 22/4/2018 14h07:55] [main/FATAL]: Unreported exception thrown!
java.util.ConcurrentModificationException: null
	at com.google.common.collect.HashBiMap$Itr.hasNext(HashBiMap.java:401) ~[guava-21.0.jar:?]
	at net.minecraft.client.audio.SoundManager.updateAllSounds(SoundManager.java:272) ~[SoundManager.class:?]
	at net.minecraft.client.audio.SoundHandler.update(SoundHandler.java:297) ~[SoundHandler.class:?]
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1983) ~[Minecraft.class:?]
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1186) ~[Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:441) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:25) [start/:?]

 

Another thing to note is the mod plays multiple sounds at once.

Is this the right way to play multiple sounds in Forge? Or is there another way to handle this?

Edited by leduyquang753
Solved thanks to @diesieben07.
Posted
4 minutes ago, leduyquang753 said:

So when I called EntityPlayerSP#playSound, it was run on both logical sides?

pretty much, you should be able to just surround your code with an world.isRemote check

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
13 minutes ago, leduyquang753 said:

I tried surrounding my code with World#isRemote on both Minecraft.player.world and Minecraft.world but it still crashes... Super confused.

Both of those are client side only. As soon as the server tries to load the Minecraft class, it fails to find it.

You're already being passed a world object, somewhere. Post more of your code.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Here is the whole source with a slightly modified version of xxmicloxx's Note Block API.

NBS-Player.zip

The classes worth seeing are cf.leduyquang753.nbsplayer.Maincom.xxmicloxx.NoteBlockAPI.SongPlayer / NoteBlockSongPlayer / SongPlayer, the class NoteBlockSongPlayer is the class that is making errors...

Posted

I am not downloading a zip file.

Post your code on GitHub.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

https://github.com/leduyquang753/NBS-Player/blob/master/src/main/java/com/xxmicloxx/NoteBlockAPI/SongPlayer.java#L85

 

You're creating your own threads?

Yeah, that won't create problems, ever.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • im new to minecraft java modding and I am looking for some help on adding a custom dimension to minecraft java version 1.21.1   I haven't managed to find a good 1.21.1 minecraft dimension turtorial for intellij modding.  all I could find online is how to make the json files for the custom dimension but not how to setup the custom dimension in the game.    im using forge's recommended version for minecraft 1.21.1, any help would be appreciated
    • Thank you for the suggestion if figure that it should be able to support around 40 based on my previous experiences hosting but no one really seems to have a concrete way of figuring it out. You have been alot more helpful than most people and i will probably set up Linux tomorrow.
    • https://mclo.gs/e8nuqSA My friend and I are having the same issue with this pack. We're trying to play on BMC4 with a bunch of extra mods. The game loads up to 'mod gathering' and then crashes. Mod list changes beyond the modpack: Added mods: alexscaves-2.0.2.jar alexsmobsinteraction-5.4-all.jar Apotheosis-1.20.1-7.4.8.jar ApothicAttributes-1.20.1-1.3.7.jar ApothicCombat-1.20.1-1.1.0.jar ApothicCurios-1.20.1-1.0.3e.jar ArmorPoser-forge-1.20.1-2.2.2.jar ars_nouveau-1.20.1-4.12.7-all.jar attributizer-2.1.jar bendy-lib-forge-4.0.0.jar betterarcheology-1.2.1-1.20.1.jar bettercombat-forge-1.8.6+1.20.1.jar BetterThirdPerson-Forge-1.20-1.9.0.jar born_in_chaos_[Forge]1.20.1_1.7.jar cataclysm_ut_lite-AT - 1.20.1.jar celestisynth-1.20.1-1.3.1.jar cobweb-forge-1.20.1-1.0.1.jar common-networking-forge-1.0.5-1.20.1.jar Critters n' Crawlers-2.2.2-mc1.20.1.jar crittersandcompanions-forge-2.2.2.jar domesticationinnovation-1.7.1-1.20.1.jar dummmmmmy-1.20-2.0.6.jar emotecraft-for-MC1.20.1-2.2.7-b.build.50-forge.jar EmoteTweaks-4.0.2.27-forge.jar exposure-1.20.1-1.7.14-forge.jar faunify-forge-1.20.1-1.1.2.jar hallucinatory_plants-2.3.0-1.20.1-forge.jar Icarus-Forge-2.12.0.jar integrated_api-1.5.1+1.20.1-forge.jar irons_spellbooks-1.20.1-3.4.0.9.jar iwannaskate-1.2.0.jar l2library-2.5.1.jar letsdo-API-forge-1.2.15-forge.jar letsdo-bakery-forge-2.0.5.jar letsdo-brewery-forge-2.0.3.jar letsdo-brewery-forge-2.0.5.jar letsdo-candlelight-forge-2.0.2.jar letsdo-farm_and_charm-forge-1.0.4.jar letsdo-herbalbrews-forge-1.0.12.jar letsdo-nethervinery-forge-1.2.17.jar letsdo-vinery-forge-1.4.39.jar modulargolems-2.5.19.jar mutil-1.20.1-6.2.0.jar Pehkui-3.8.2+1.20.1-forge.jar Placebo-1.20.1-8.6.3.jar player-animation-lib-forge-1.0.2-rc1+1.20.jar Powah-5.0.10.jar productivebees-1.20.1-12.6.0.jar Rats-1.20.1-8.1.3.jar refinedstorage-1.12.4.jar refinedstorageaddons-0.10.0.jar RSInfinityBooster-1.20.1-1.0+41.jar rsjukeboxes-1.20.1-1.0.1.0.jar ScorchedGuns-0.4.1-1.20.1.jar simplyswords-forge-1.56.0-1.20.1.jar sophisticatedbackpacks-1.20.1-3.23.23.1281.jar sophisticatedcore-1.20.1-1.2.75.1033.jar soul-fire-d-forge-1.20.1-4.0.11.jar supermartijn642configlib-1.1.8-forge-mc1.20.jar the_bumblezone-7.7.1+1.20.1-forge.jar the_dirty_stuff-2.1-forge-1.20.1.jar traveloptics-4.4.0-1.20.1.jar unusualprehistory-1.5.0.3.jar voicechat-forge-1.20.1-2.5.30.jar wits-1.1.0+1.20.1-forge.jar xercapaint-1.20.1-1.0.1.jar Updated mods: azurelib (3.0.8 > 3.0.9) lithostitched-forge-1.20.1-1.4.10.jar > lithostitched-forge-1.20.1-1.4.11.jar  
    • Graphics are irrelevant for a server. According to google, it should support 20-40. I literally asked it "how many players on a lightly modded minecraft server will a ryzen 5 2600 with 32GB ram support?" Maybe someone with some real world experience has further input. I can say without a doubt that if you run Linux as opposed to windows for the server operating system, you will get better performance and have more resources available to your server.
    • Could someone help me to figure out what's the problem?  I get this crash when I try to enter to a world in forge 1.12.2:  The game crashed: exception in server tick loop Error: java.lang.NullPointerException: Exception in server tick loop Error code: -1 here is the crash report crash-2025-07-15_20.44.02-server333.txt
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.