Model Bug with Ores

[xTekBlue]

Bug Demonstration

Spoiler

 

 

Code of Ore

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraft.util.NonNullList;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.World;
import xtekblue.mod.Main;
import xtekblue.mod.init.BlockInit;
import xtekblue.mod.init.ItemInit;
import xtekblue.mod.objects.blocks.item.ItemBlockVariants;
import xtekblue.mod.util.IHasModel;
import xtekblue.mod.util.handlers.EnumHandler;
import xtekblue.mod.util.handlers.EnumHandler.EnumType;
import xtekblue.mod.util.interfaces.IMetaName;

public class OreBase extends Block implements IHasModel, IMetaName {

	public static final PropertyEnum<EnumHandler.EnumType> VARIANT = PropertyEnum.<EnumHandler.EnumType>create("variant", EnumHandler.EnumType.class);
	
	private String name, dimension;
	
	public OreBase(String name, String dimension) {
		
		super(Material.ROCK);
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(Main.xtrablocks);
		setHardness(3);
		setHarvestLevel("pickaxe", 2);
		setResistance(15);
		
		setDefaultState(this.blockState.getBaseState().withProperty(VARIANT, EnumType.RUBY));
		
		this.name = name;
		this.dimension = dimension;
		
		BlockInit.BLOCKS.add(this);
		ItemInit.ITEMS.add(new ItemBlockVariants(this).setRegistryName(this.getRegistryName()));
		
	}
	
	@Override
	public void dropXpOnBlockBreak(World worldIn, BlockPos pos, int amount) {
		super.dropXpOnBlockBreak(worldIn, pos, 10);
	}
	
	@Override
	protected ItemStack getSilkTouchDrop(IBlockState state) {
		return super.getSilkTouchDrop(state);
	}
	
	@Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune) {
		if(getMetaFromState(state) == 0) {
			return ItemInit.RUBY_GEM;
		}else if(getMetaFromState(state) == 1){
			return ItemInit.SAPPHIRE_GEM;
		}else {
			return ItemInit.RUBY_GEM;
		}

    }
	
	@Override
    public int quantityDropped(Random random) {
		return random.nextInt(1) + 1;
	}
	
	@Override
	public int damageDropped(IBlockState state) {
		return ((EnumHandler.EnumType)state.getValue(VARIANT)).getMeta();
	}
	
	@Override
	public int getMetaFromState(IBlockState state) {
		return ((EnumHandler.EnumType)state.getValue(VARIANT)).getMeta();
	}
	
	@Override
	public IBlockState getStateFromMeta(int meta) {
		return this.getDefaultState().withProperty(VARIANT, EnumHandler.EnumType.byMetadata(meta));
	}
	
	/*@Override
	public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player) {
		return new ItemStack(Item.getItemFromBlock(this), 1, getMetaFromState(world.getBlockState(pos)));
	}*/
	
	@Override
	public void getSubBlocks(CreativeTabs itemIn, NonNullList<ItemStack> items) {
		for(EnumHandler.EnumType variant : EnumHandler.EnumType.values()) {
			items.add(new ItemStack(this, 1, variant.getMeta()));
		}
	}
	
	@Override
	protected BlockStateContainer createBlockState() {
		return new BlockStateContainer(this, new IProperty[] {VARIANT});
	}
	
	@Override
	public String getSpecialName(ItemStack stack) {
		return EnumHandler.EnumType.values()[stack.getItemDamage()].getName();
	}
	
	@Override
	public void registerModels() {

		for(int i = 0; i < EnumHandler.EnumType.values().length; i++) {
			Main.proxy.registerVariantRenderer(Item.getItemFromBlock(this), i, "ore_" + this.dimension + "_" + EnumHandler.EnumType.values()[i].getName(), "inventory");
		}
	}

}

 

Code of Gems

package xtekblue.mod.objects.items;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Item.ToolMaterial;
import xtekblue.mod.Main;
import xtekblue.mod.init.ItemInit;
import xtekblue.mod.tabs.XtraItemsTab;
import xtekblue.mod.util.IHasModel;

public class ItemBase extends Item implements IHasModel {

	public ItemBase(String name) {
		
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(Main.xtraitems);
		
		ItemInit.ITEMS.add(this);
	}

	@Override
	public void registerModels() {
		
		Main.proxy.registerItemRenderer(this, 0, "inventory");
	}

}

Sapphire Model JSON

{
    "parent": "item/generated",
    "textures": {
        "layer0": "xi:items/sapphire_gem"
    }
}

 

Additional things to say

• I also do not believe the EXP is dropping either, unless the amount is too low. 

 

[Draco18s]

2 hours ago, xTekBlue said:

	@Override
	public int damageDropped(IBlockState state) {
		return ((EnumHandler.EnumType)state.getValue(VARIANT)).getMeta();
	}

 

You are returning different items in your getItemDropped method. When your drop a sapphire, you also drop that sapphire with damage 1.

[xTekBlue]

Im silly, i should have saw that. Thanks