Jump to content

Recommended Posts

Posted

Hello! My mod items can register just fine but the renders have the purple and black thing. My code seems to be fine, please help.

package com.geometrically.prehistoricEclipse.items;


import com.geometrically.prehistoricEclipse.items.item.*;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.registry.ForgeRegistries;

public class PEItems {
    public static Item dakoArrow;
    public static Item dakoClaw;
    public static Item dakoFeather;
    public static Item dakoMeat;
    public static Item dakoBeef;
    public static Item dakoSkull;

    public static Item huntersBow;

    public static void init(){
        dakoArrow = new ItemDakotaraptorArrow();
        dakoClaw = new ItemDakotaraptorClaw();
        dakoFeather = new ItemDakotaraptorFeather();
        dakoMeat = new ItemDakotaraptorMeat();
        dakoBeef = new ItemDakotaraptorMeatCooked();
        dakoSkull = new ItemDakotaraptorSkull();

        huntersBow = new ItemHunterBow();
    }
    public static void registerItems(){
        registerItem(dakoArrow);
        registerItem(dakoClaw);
        registerItem(dakoFeather);
        registerItem(dakoMeat);
        registerItem(dakoBeef);
        registerItem(dakoSkull);

        registerItem(huntersBow);
    }
    private static void registerItem(Item item) {
        ForgeRegistries.ITEMS.register(item);
    }
    public static void registerRenders(){
        registerRender(dakoArrow);
        registerRender(dakoClaw);
        registerRender(dakoFeather);
        registerRender(dakoMeat);
        registerRender(dakoBeef);
        registerRender(dakoSkull);

        registerRender(huntersBow);
    }
    private static void registerRender(Item item){

        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));

    }

}

Items class

package com.geometrically.prehistoricEclipse.items.item;

import net.minecraft.item.Item;
import com.geometrically.prehistoricEclipse.PrehistoricEclipse;

public class ItemDakotaraptorClaw extends Item {
    public ItemDakotaraptorClaw(){
        setRegistryName("dakotaraptor_claw");
        setUnlocalizedName("dakotaraptor_claw");
        setCreativeTab(PrehistoricEclipse.creativeTab);
    }
}

Example class for an item

9ec7bfdcc5f2d79f1062a41d4f5861ac.png
https://gyazo.com/9ec7bfdcc5f2d79f1062a41d4f5861ac - Rescource Locations. 

There are no errors spit out at all.

Posted

Do you have a GitHub you can link?

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

also put

registerRender

in 

ModelRegistryEvent

using Subscribe Events so that it gets called at the proper time

 

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
12 minutes ago, Geometrically said:

public static void registerRenders(){

Where is this called?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
Just now, Geometrically said:

It's called in the ClientProxy, which is called from preInit

post both classes

Edited by Cadiboo

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
package com.geometrically.prehistoricEclipse.proxy;


import com.geometrically.prehistoricEclipse.items.PEItems;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.client.registry.RenderingRegistry;

public class ClientProxy extends CommonProxy
{	

	@Override
	public void registerRendering()
	{
		PEItems.registerRenders();

	}
}

 

Posted
package com.geometrically.prehistoricEclipse;

@Mod(modid = PrehistoricEclipse.MODID, name = PrehistoricEclipse.MODNAME, version = PrehistoricEclipse.VERSION)
public class PrehistoricEclipse
{

   public static final String MODID = "pe";
   public static final String MODNAME = "Prehistoric Eclipse";
   public static final String VERSION = "0.0.1";

   @Mod.Instance
   public static PrehistoricEclipse instance;

   @SidedProxy(serverSide = "com.geometrically.prehistoricEclipse.proxy.CommonProxy", clientSide = "com.geometrically.prehistoricEclipse.proxy.ClientProxy")
   public static CommonProxy proxy;

   public static CreativeTabs creativeTab = new PETab(CreativeTabs.getNextID(), "Prehistoric Eclipse");

   @Mod.EventHandler
   public void preInit(FMLInitializationEvent event)
   {     
      instance = this;

        PEItems.init();
        PEItems.registerItems();

      proxy.init();
   }

   @Mod.EventHandler
   public void init(FMLInitializationEvent event)
   {
      MinecraftForge.EVENT_BUS.register(new ObsidianEventHandler());
   }
    @Mod.EventHandler
    public void postInit(FMLPostInitializationEvent event)
    {
    }
}
Posted
21 minutes ago, Geometrically said:

public void registerRendering()

Where is this called?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

There you go then:

56 minutes ago, Cadiboo said:

put


registerRender

in 


ModelRegistryEvent

using Subscribe Events so that it gets called at the proper time

 

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.