[1.12.2] unable to remove itemstack from player inventory

[InterdimensionalCat]

project on github for referencing: https://github.com/InterdimensionalCat/ModTest/tree/master/java/com/benthom123/test

 

I am trying to program guns in minecraft. So far I have everything working except for one thing. I have a abstract class ItemGun as a template, and ItemAmmo for an ammo template. The idea is that when "reloading" the gun it uses up one of the specified ammo type. However, whenever I remove the item stack from the player inventory, the texture will disappear until something else updates the inventory, then reappears in the same quantity. I assume the game has some sort of failsafe checking, but I am unaware of what it might be.

 

I looked in the ItemBucket class of minecraft's source code and got no answers there.

 

Here is the class ItemGun:

package com.benthom123.test.items;

import com.benthom123.test.ModItems;
import com.benthom123.test.modClass;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.stats.StatList;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.world.World;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import com.benthom123.test.items.ItemAmmo;

public abstract class ItemGun extends Item {

	protected int clipSize;
	protected int currentClip;
	protected int maxDamage;
	protected boolean reloading;
	protected ItemStack ammo;
	protected final int fireRate;
	protected int fireCD;
	
	public ItemGun(String name, int clipSize, int reloadTime, ItemAmmo ammo, int fireRate) {
		setRegistryName(name);
        setUnlocalizedName(modClass.MODID + "." + name);
        this.setCreativeTab(ModItems.powerCrystal);
        this.currentClip = 0;
        this.clipSize = clipSize;
        
        this.setMaxDamage(reloadTime + 1);
		maxDamage = reloadTime;
		this.isDamageable();
		this.setMaxStackSize(1);
		
		this.ammo = new ItemStack(ammo, 1, 0);
		this.fireRate = fireRate;
		fireCD = 0;
    }
	
    public abstract void shoot(World worldIn, EntityPlayer playerIn, EnumHand handIn);
	
    @SideOnly(Side.CLIENT)
    public void initModel() {
       ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
	}
	
    
    /**
     * Called when the equipped item is right clicked.
     */
    
    public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
    	ItemStack itemstack = playerIn.getHeldItem(handIn);
    	if (!reloading&&fireCD == 0) {
			if(currentClip > 0) {
				shoot(worldIn, playerIn, handIn);
				if(!worldIn.isRemote) {
					currentClip--;
					System.out.println(currentClip);
					fireCD = fireRate;
				}
				playerIn.addStat(StatList.getObjectUseStats(this));
				//itemstack.setItemDamage(itemstack.getItemDamage() - (maxDamage*(clipSize - currentClip) / clipSize));
				itemstack.damageItem(maxDamage / clipSize, playerIn);
				System.out.println(itemstack.getItemDamage());
				return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, itemstack);
			} else {
				if(playerIn.inventory.hasItemStack(new ItemStack(ModItems.tttremington))) {
					reloading = true;
					//itemstack.setItemDamage(maxDamage);
					currentClip = clipSize;
						//playerIn.inventory.getStackInSlot(playerIn.inventory.getSlotFor(new ItemStack(ammo, 1))).shrink(1);
						for (int i = 0; i < playerIn.inventory.getSizeInventory(); i++) {
							if (playerIn.inventory.getStackInSlot(i).isItemEqual(new ItemStack(ModItems.tttremington))) {
								//ItemAmmo.remove(i, playerIn);
								//playerIn.inventory.deleteStack(playerIn.inventory.getStackInSlot(i));
								//playerIn.inventory.getStackInSlot(i).damageItem(1, playerIn);
								///playerIn.inventory.setInventorySlotContents(i, playerIn.inventory.getStackInSlot(i));
								ItemStack is = playerIn.inventory.getStackInSlot(i);
			                    if (!playerIn.capabilities.isCreativeMode)
			                    {
			                    	is.shrink(1);

			                        if (is.isEmpty())
			                        {
			                        	playerIn.inventory.deleteStack(is);
			                        }
			                    }

								break;
							}
						} 
	               playerIn.addStat(StatList.getObjectUseStats(this));
				}
			}
		}
    	
    	 return new ActionResult<ItemStack>(EnumActionResult.FAIL, itemstack);
    }
    
	@Override
	public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) {
		if (reloading) {
			if (stack.getItemDamage() > 0) {
				stack.setItemDamage(stack.getItemDamage() - 1);
				System.out.println(stack.getItemDamage());
			} else {
				reloading = false;
			}
		}
		
		if(fireCD > 0) {
			fireCD--;
		}
    }
}

 

 

and here is class itemammo:

 

package com.benthom123.test.items;

import com.benthom123.test.ModItems;
import com.benthom123.test.modClass;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ItemAmmo extends Item {
	
	
	public boolean used = false;
	

	public ItemAmmo(String name, int stackSize) {
		setRegistryName(name);
        setUnlocalizedName(modClass.MODID + "." + name);
        this.setCreativeTab(ModItems.powerCrystal);
        this.setMaxStackSize(1);
        this.setMaxDamage(1);
	}
	
	@SideOnly(Side.CLIENT)
    public void initModel() {
       ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
	}
	
	public static void remove(int i, EntityPlayer playerIn) { //this is currently unused, ignore it
		//ItemStack ii = playerIn.inventory.removeStackFromSlot(i);
		playerIn.inventory.deleteStack(playerIn.inventory.getStackInSlot(i));
		//playerIn.replaceItemInInventory(i, new ItemStack(Items.IRON_NUGGET, 1, 0));
		//ii = null;
	}
}

 

[Cadiboo]

look at how ItemBow does it

noticed that your already trying to do it the same way

can you post a GitHub? your ItemGun class is rather hard to read

Ignore this post

 

Edited April 25, 2018 by Cadiboo

[InterdimensionalCat]

I have also already looked in itembow, however I looked at it again just now and unless I am missing something I believe I am doing the same thing as in the ItemBow class. If I'm missing something please let me know

[Cadiboo]

public abstract class ItemGun extends Item

why abstract?

 

public abstract void shoot(World worldIn, EntityPlayer playerIn, EnumHand handIn);

 

why is it abstract and why doesn't it do anything?

Edited April 25, 2018 by Cadiboo

[InterdimensionalCat]

github link is on the top of the post but here it is: https://github.com/InterdimensionalCat/ModTest/tree/master/java/com/benthom123/test

 

EDIT: the class is abstract because I am using it as a template for multiple guns (eventually), the only current subclass is ArmaLite15, i can post the code for that here however it does not touch the itemstack at all.

 

Edited April 25, 2018 by InterdimensionalCat

[InterdimensionalCat]

5 minutes ago, Cadiboo said:

public abstract class ItemGun extends Item

why abstract?

 

public abstract void shoot(World worldIn, EntityPlayer playerIn, EnumHand handIn);

 

why is it abstract and why doesn't it do anything?

 

as I said I'm using it as a template for different types of guns, the current sublcass I am testing it on is here :

 

package com.benthom123.test.items;

import com.benthom123.test.ModItems;
import com.benthom123.test.entity.EntitySmokeShot;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumHand;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.math.MathHelper;
import net.minecraft.world.World;

public class ArmaLite15 extends ItemGun {

	public boolean firstTick = true;
	
	public ArmaLite15(String name) {
		super(name, 25, 100, ModItems.tttremington, 1);
		
	}

	@Override
	public void shoot(World worldIn, EntityPlayer playerIn, EnumHand handIn) {		
		if (!worldIn.isRemote) {
			
			EntitySmokeShot entitysmokeshot = new EntitySmokeShot(worldIn, playerIn);
			entitysmokeshot.shoot(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 1.5F, 10.0F);
			worldIn.spawnEntity(entitysmokeshot);
			worldIn.playSound((EntityPlayer) null, playerIn.posX, playerIn.posY, playerIn.posZ, SoundEvents.ENTITY_GENERIC_EXPLODE, SoundCategory.NEUTRAL, 0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
		}
		
		playerIn.rotationYaw += this.itemRand.nextGaussian()*1.5/**Math.signum(this.itemRand.nextDouble() - 0.5)*/;
		playerIn.rotationPitch -= Math.abs(this.itemRand.nextGaussian()*3.0);
	}

	@Override
	public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected) {
		if(firstTick) {
			ammo = new ItemStack(ModItems.tttremington, 1, 0);
			firstTick = false;
		}
		
		super.onUpdate(stack, worldIn, entityIn, itemSlot, isSelected);
	}
	
}

 

this overrides the abstract method shoot(), again, this should not have any effect on the current problem as far as i can tell.

[Cadiboo]

what is fireCD

[InterdimensionalCat]

Just now, Cadiboo said:

what is fireCD

the cooldown (in ticks) for firing the gun

[Cadiboo]

itemstack.damageItem(maxDamage / clipSize, playerIn);

 

what are you trying to do here??

[InterdimensionalCat]

I am using the gun's durability counter as a magazine indicator, this decrements the durability by the clip size every time the gun fires so that the counter is even each time. Note that this is being done to the gun and not the ammo.

[Draco18s]

You're on 1.12. You don't need to "delete" stacks. A stack with 0 size is already the same as air.

 

If "the inventory updates and the item comes back" thing is happening, that sounds to me like you're only subtracting 1 from the stack size on the client and not doing it on the server. So when "the inventory updates" (cough, gets an update packet from the server) the item "reappears" again because it was never gone in the first place.

[InterdimensionalCat]

Just now, Draco18s said:

You're on 1.12. You don't need to "delete" stacks. A stack with 0 size is already the same as air.

 

If "the inventory updates and the item comes back" thing is happening, that sounds to me like you're only subtracting 1 from the stack size on the client and not doing it on the server. So when "the inventory updates" (cough, gets an update packet from the server) the item "reappears" again because it was never gone in the first place.

 

Thank you for your help, I am unfamiliar with how to handle server packets, can you please elaborate on how to deal with them?

[Draco18s]

You don't need to do anything except reduce the stack size on the server.

[InterdimensionalCat]

Thanks for all your guys' help, the problem was with some counters screwing up the Server method call