Jump to content

If Statement Getting Ignored


tuunaa

Recommended Posts

https://pastebin.com/cbq10K42

Here's my class.

 

The issue I'm having is that the if statement 

if (neighborPos != oppPos || neighborPos != facingPos)

in the posCompare method seems to be getting ignored.  Here's an example of what the output would be for the System.out.printlns you see in the posCompare method if I was facing north:

Spoiler

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=206}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

As you can see, if the if statement in posCompare was followed correctly, the blocks at neighbor positions

Spoiler

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

and

Spoiler

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}

shouldn't be broken, but when I right click a crop in game it still does.

 

I also have another issue, being the beetroots won't break properly with this code.  This is because when I right click them, even though I'm using

((BlockCrops)block).getMaxAge())

it still wants to check for a max age of 7.  I've tried checking for whether it's trying to destroy beetroots specifically and using 3 instead of getting the max age but it still wants to check for 7.  Here's the error log:

Spoiler

[13:07:12] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:795) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:740) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:589) [MinecraftServer.class:?]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_171]
Caused by: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:204) ~[BlockStateContainer$StateImplementation.class:?]
    at tuunaa.stardew.items.ItemScythe.posCompare(ItemScythe.java:52) ~[ItemScythe.class:?]
    at tuunaa.stardew.items.ItemScythe.onItemUse(ItemScythe.java:72) ~[ItemScythe.class:?]
    at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:836) ~[ForgeHooks.class:?]
    at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:200) ~[ItemStack.class:?]
    at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:504) ~[PlayerInteractionManager.class:?]
    at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:757) ~[NetHandlerPlayServer.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
    ... 5 more

 

Edited by tuunaa
Link to comment
Share on other sites

  • 2 weeks later...
On 07/05/2018 at 6:11 AM, tuunaa said:

https://pastebin.com/cbq10K42

Here's my class.

 

The issue I'm having is that the if statement 


if (neighborPos != oppPos || neighborPos != facingPos)

in the posCompare method seems to be getting ignored.  Here's an example of what the output would be for the System.out.printlns you see in the posCompare method if I was facing north:

  Reveal hidden contents

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=206}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

As you can see, if the if statement in posCompare was followed correctly, the blocks at neighbor positions

  Reveal hidden contents

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

and

  Reveal hidden contents

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}

shouldn't be broken, but when I right click a crop in game it still does.

 

I also have another issue, being the beetroots won't break properly with this code.  This is because when I right click them, even though I'm using


((BlockCrops)block).getMaxAge())

it still wants to check for a max age of 7.  I've tried checking for whether it's trying to destroy beetroots specifically and using 3 instead of getting the max age but it still wants to check for 7.  Here's the error log:

  Reveal hidden contents

[13:07:12] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:795) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:740) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:589) [MinecraftServer.class:?]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_171]
Caused by: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:204) ~[BlockStateContainer$StateImplementation.class:?]
    at tuunaa.stardew.items.ItemScythe.posCompare(ItemScythe.java:52) ~[ItemScythe.class:?]
    at tuunaa.stardew.items.ItemScythe.onItemUse(ItemScythe.java:72) ~[ItemScythe.class:?]
    at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:836) ~[ForgeHooks.class:?]
    at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:200) ~[ItemStack.class:?]
    at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:504) ~[PlayerInteractionManager.class:?]
    at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:757) ~[NetHandlerPlayServer.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
    ... 5 more

 

== and != perform INSTANCE comparisons, use someobject.equals(otherobject) instead

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

  • Guest locked this topic
Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm opening the forge 1.8.9 installer properly I click install with the client option selected, it says it installs properly but when I go into my files and also when I go into the minecraft launcher, it's just not there.  JVM info: Oracle Corporation - 1.8.0_431 - 25.431-b10 java.net.preferIPv4Stack=true Found java version 1.8.0_431 Considering minecraft client jar Considering library net.minecraftforge:forge:1.8.9-11.15.1.2318-1.8.9: Not Downloading {Wrong Side} Considering library net.minecraft:launchwrapper:1.12: Not Downloading {Wrong Side} Considering library org.ow2.asm:asm-all:5.0.3: Not Downloading {Wrong Side} Considering library jline:jline:2.13: Not Downloading {Wrong Side} Considering library com.typesafe.akka:akka-actor_2.11:2.3.3 Considering library com.typesafe:config:1.2.1 Considering library org.scala-lang:scala-actors-migration_2.11:1.1.0 Considering library org.scala-lang:scala-compiler:2.11.1 Considering library org.scala-lang.plugins:scala-continuations-library_2.11:1.0.2 Considering library org.scala-lang.plugins:scala-continuations-plugin_2.11.1:1.0.2 Considering library org.scala-lang:scala-library:2.11.1 Considering library org.scala-lang:scala-parser-combinators_2.11:1.0.1 Considering library org.scala-lang:scala-reflect:2.11.1 Considering library org.scala-lang:scala-swing_2.11:1.0.1 Considering library org.scala-lang:scala-xml_2.11:1.0.2 Considering library lzma:lzma:0.0.1: Not Downloading {Wrong Side} Considering library net.sf.jopt-simple:jopt-simple:4.6: Not Downloading {Wrong Side} Considering library java3d:vecmath:1.5.2 Considering library net.sf.trove4j:trove4j:3.0.3 Extracting: /forge-1.8.9-11.15.1.2318-1.8.9-universal.jar To: C:\Users\Ian\AppData\Roaming\.minecraft\libraries\net\minecraftforge\forge\1.8.9-11.15.1.2318-1.8.9\forge-1.8.9-11.15.1.2318-1.8.9.jar That's the installer log and I have no idea if anything is wrong.
    • https://mclo.gs/NQ786zI   I don’t understand what I need to do.
    • I am wanting to give the armour in my mod special properties, but I have no idea how to do so.   For the first armour set I want it to be the case that when the full set is worn it has the properties of a carved pumpkin, making it so you won't aggravate endermen when you look at them.    The second, and presumably harder property is that for the second set I would like it to be the case that when the full set is worn, you can walk over the void without falling. (I was considering using the levitation to accomplish this but I wanted to check beforehand).   Would both of these specialities be achievable for each armour set and how exactly would they both be done? Help would be much appreciated. 
    • I finally got my Forge server up and running thanks to the help of the people on this forum and played fine for a day. Now since I started playing today, the server runs for 20-30 minutes then freezes and kicks everyone out but stays up and running but won't let anyone connect. Here is the latest debug log and crashlog from the server. Thank you for reading & helping   https://gist.github.com/Dwolfwoood/d0410e581c86772694f1d8007431c409   https://gist.github.com/Dwolfwoood/b5d521fd071dbfcc816949924757fef9
    • I got the infamous crash log that you get when you have a mod or multiple mods that are incompatible with the version being used. however.. I have no idea which ones are wrong. I was hoping the forums could help me figure it out. does the crsh report tell me and im just dumb?  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.