Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved]Generation Problem

Krevik

By Krevik
in Modder Support

 Share

Recommended Posts

Krevik Creeper Killer

Krevik

Posted
Posted (edited)

Hello! I have made a dimension and custom biomes. I want to have floating islands only in one biome so I copied code from ChunkGeneratorEnd, pasted it into my ChunkGenerator and code from ChunkGeneratorEnd is done only in FloatingIslands biome. Though I've got some problems on borders of the biome: https://i.imgur.com/vzFE1yl.png . So the goal is to somehow smooth these pieces, or maybe let chunkgenerator complete generation if it's out the biome border but basing on noise the stone should be generated here. Does anyone have any idea or can help me?
Here's my ChunkGenerator:
 

  Reveal hidden contents

 I thought of checking neighbour heightMap if the method is generating blocks on a border of chunk and if it is positive than generate neighbour chunk,but operating on this heightMap seems quite difficult.

Edited by Krevik
null Tree Puncher

null

Posted
Posted

I am no expert on this, but i would propose to get rid of the if(biome == KCore.instance.FloatingIslands) line. Floating islands will be created everywhere but there shouldn't be any chunk problems with chunk borders. If you really need to have a floating island biome at these positions then let the setBlocksInChunkIsland method return something telling you if there was at least one non-air block set, so you can fix the biome.

  • Like 1
Krevik Creeper Killer

Krevik

Posted
  • Author
Posted (edited)
  On 5/16/2018 at 2:53 PM, null said:

I am no expert on this, but i would propose to get rid of the if(biome == KCore.instance.FloatingIslands) line. Floating islands will be created everywhere but there shouldn't be any chunk problems with chunk borders. If you really need to have a floating island biome at these positions then let the setBlocksInChunkIsland method return something telling you if there was at least one non-air block set, so you can fix the biome.

Expand  

Hmm I think I understand what you've got on your mind, thanks, will try! Anyway I am not sure if it will work cause these non air block are generated exactly at the chunk border so the new chunk is just empty and has no floating stones to detect

Edited by Krevik
Matryoshika Dragon Slayer

Matryoshika

Posted
Posted

Biomes are not chunk-based. They are block-based, ignoring the y (meaning a single chunk can have 256 different biomes inside of it, each on a different x&z coord)
You need to use the biome-check on each block-position when placing the actual block, not just check it once per chunk.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 5/16/2018 at 3:57 PM, Matryoshika said:

Biomes are not chunk-based. They are block-based, ignoring the y (meaning a single chunk can have 256 different biomes inside of it, each on a different x&z coord)
You need to use the biome-check on each block-position when placing the actual block, not just check it once per chunk.

Expand  

Typically a chunk never has more than 2, and rarely 3, but yes.

I've played a custom map where every achievement expanded the world border by 1 block (starting with it being 1 block in size). Yes, there was a way to visit every biome.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Krevik Creeper Killer

Krevik

Posted
  • Author
Posted (edited)
  On 5/16/2018 at 3:57 PM, Matryoshika said:

Biomes are not chunk-based. They are block-based, ignoring the y (meaning a single chunk can have 256 different biomes inside of it, each on a different x&z coord)
You need to use the biome-check on each block-position when placing the actual block, not just check it once per chunk.

Expand  

I get something like that: https://i.imgur.com/OkOPOqJ.png . NOTHING :/
Here's updated code:
 

  Reveal hidden contents

Basically as you said I removed checking biome method from generateChunk method to setBlocksInChunkIsland method to make it check biome for every single biome. I think that even if it would work I would still be getting cut-outs like on the first image. 

EDIT:
With biome checking changed to  

                        	 Biome biome = world.getBiome(new BlockPos(x+k2,l2+upperScale,z+i3));

It still doesn't work

Edited by Krevik
null Tree Puncher

null

Posted
Posted (edited)

you write your blocks into the chunkprimer after you have copied it to the chunk, you call setBlocksInChunkIsland to late.

Put it directly after "this.setBlocksInChunk ..." or after "this.biomesForGeneration = ..." if you want to manipulate the biomes. 

 

Edit:

I am not shure if the world object has the biome information you need at this point, use biomesForGeneration instead, you have to calculate the coordinates manually since biomesForGeneration is an one dimensional array. 

 

Edit 2:

Also you should not check for the right biome and instead just update the biome information when a block is set.

  

[...]
primer.setBlockState(k2, l2+upperScale, i3, iblockstate);
if(iblockstate != Blocks.AIR.getDefaultState()) {
  this.biomesForGeneration[k2 + i3 * 16] = KCore.instance.FloatingIslands; //i am not shure about the coordinates it could be i3 + k2*16 instead
}
[...]

 

 

Edited by null
  • Like 1
Krevik Creeper Killer

Krevik

Posted
  • Author
Posted
  On 5/16/2018 at 4:42 PM, null said:

you write your blocks into the chunkprimer after you have copied it to the chunk, you call setBlocksInChunkIsland to late.

Put it directly after "this.setBlocksInChunk ..." or after "this.biomesForGeneration = ..." if you want to manipulate the biomes. 

 

Edit:

I am not shure if the world object has the biome information you need at this point, use biomesForGeneration instead, you have to calculate the coordinates manually since biomesForGeneration is an one dimensional array. 

 

Edit 2:

Also you should not check for the right biome and instead just update the biome information when a block is set.

  

[...]
primer.setBlockState(k2, l2+upperScale, i3, iblockstate);
if(iblockstate != Blocks.AIR.getDefaultState()) {
  this.biomesForGeneration[k2 + i3 * 16] = KCore.instance.FloatingIslands; //i am not shure about the coordinates it could be i3 + k2*16 instead
}
[...]

 

 

Expand  

Ahh you mean just change biome in this place? Great! Thanks will test it soon and tell you if it will be working!

Krevik Creeper Killer

Krevik

Posted
  • Author
Posted
  On 5/16/2018 at 4:42 PM, null said:

you write your blocks into the chunkprimer after you have copied it to the chunk, you call setBlocksInChunkIsland to late.

Put it directly after "this.setBlocksInChunk ..." or after "this.biomesForGeneration = ..." if you want to manipulate the biomes. 

 

Edit:

I am not shure if the world object has the biome information you need at this point, use biomesForGeneration instead, you have to calculate the coordinates manually since biomesForGeneration is an one dimensional array. 

 

Edit 2:

Also you should not check for the right biome and instead just update the biome information when a block is set.

  

[...]
primer.setBlockState(k2, l2+upperScale, i3, iblockstate);
if(iblockstate != Blocks.AIR.getDefaultState()) {
  this.biomesForGeneration[k2 + i3 * 16] = KCore.instance.FloatingIslands; //i am not shure about the coordinates it could be i3 + k2*16 instead
}
[...]

 

 

Expand  

https://i.imgur.com/ZpuIBSo.png It works perfect! Thank you so much null! Seems that you know something about noises. Could you give me some tips? E.g. how to operate density of these islands maybe?

null Tree Puncher

null

Posted
Posted

i don't understand much of minecrafts chunk generation code, i implemented my own version.

If you want to learn about manipulating noise in general you could dive into the subject of computer graphics, try the chapter about generative design from https://thebookofshaders.com/ .

  • Like 1

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TheGudBIAS
      Using Mixins, gone bad with @At INVOKE value.

      By TheGudBIAS · Posted

      I have used mixins once before, and it was with @At RETURN, so it worked fine. Now im trying to use it as INVOKE, and the compilation is successful, but the client crashes almost on startup (just a couple seconds after running runClient)   Im trying to inject the method finishConversion inside the ZombieVillager class. This is my Mixin class important stuff:   import net.minecraft.server.level.ServerLevel; import net.minecraft.world.entity.monster.ZombieVillager; import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; @Mixin(ZombieVillager.class) public class ZombieVillagerCures { @Inject(method = "finishConversion", at = @At(value = "INVOKE_ASSIGN", target = "Lnet/minecraft/world/entity/LivingEntity;addEffect(Lnet/minecraft/world/effect/MobEffectInstance;)Z")) private void addZombieVillagerCuredAmmount(ServerLevel level, CallbackInfo info) { System.out.println("The Mixin Worked!!! " + level); } // Lnet/minecraft/world/entity/LivingEntity;addEffect(Lnet/minecraft/world/effect/MobEffectInstance;)Z } I'm sure the issue lies in the @At cuz other @At values work fine. Its probably the fully qualified name thing. idk how to get it in VS code
    • TheGudBIAS
      Replace trader with custom mob when event is triggered

      By TheGudBIAS · Posted

      I'm wayy less skilled than you i bet, but maybe u could try to just convert one into the other?
    • TileEntity
      Mod discovery errors

      By TileEntity · Posted

      wildbackport is not working
    • Victoria Spencer
      Steps To Recover Stolen Funds From Blockchain web3

      By Victoria Spencer · Posted

      Through Betafort Recovery, Bitcoin scam victims can retrieve their money. I recommend Betafort Recovery to anyone who has fallen victim to a scam and has been looking for methods and techniques to recover their lost cryptocurrency or wallets. Betafort Recovery is a reliable cryptocurrency recovery firm that assists victims in recovering their stolen cryptocurrency and offers secure solutions to protect your wallets from online scammers. I must admit that I was deeply melancholy and had given up on life until these experts could restore my $23,400 to my wallet. If you've lost your cryptocurrency and you are helpless about it, contact Betafort Recovery to get your money back. One key aspect that makes Betafort Recovery stand out is its focus on providing secure solutions to protect wallets from online scammers. It's not just about recovering lost funds; it's also about preventing future incidents and ensuring that clients' digital assets are safeguarded against potential threats. This proactive approach demonstrates their commitment to the long-term financial security of their clients. Furthermore, for individuals who have lost their cryptocurrency and are feeling helpless, reaching out to Betafort Recovery could be a turning point in their situation. The reassurance that they are legitimate for seeking help and recovering lost funds can provide much-needed relief and a sense of empowerment. Betafort Recovery as a reliable cryptocurrency recovery firm is certainly well-founded. Their ability to assist scam victims in recovering stolen cryptocurrency, their focus on providing secure solutions, and their commitment to supporting clients through challenging situations make them a valuable resource for individuals navigating the complex world of digital currencies. If you or someone you know has fallen victim to a cryptocurrency scam, contacting Betafort Recovery could be the first step towards reclaiming lost funds and regaining peace of mind.  
    • Samaka
      Mod discovery errors

      By Samaka · Posted

      Idk how i didn't notice that, but I deleted it and fixed some other issues and now I get this https://mclo.gs/YsWacqq

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept