Search the Forums BEFORE making a new post.

[1.12.2] Saving NBT To Drops

Posted May 17, 20187 yr

Hello,

So my TE has some data that I would like to be transferred across breaking/placing. I have some base code, however, it does not work. When destroyed, no data tags are stored and nothing is saved.

Here is my current code:

Spoiler


    @Override
    public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {
    	TileEntity tile = world.getTileEntity(pos);
    	ItemStack drop = new ItemStack(ModBlocks.ENCHANTMENT_FAB);
    	
    	if(!drop.hasTagCompound())
    		drop.setTagCompound(new NBTTagCompound());
    	
    	if(tile != null) //fix
    	{
    		if(tile instanceof TileEntityEnchantmentFab)
    		{
    			if(!((TileEntityEnchantmentFab) tile).getKnownEnchants().isEmpty())
    			{
					NBTTagList enchantList = new NBTTagList();
					for(Enchantment e : ((TileEntityEnchantmentFab) tile).getKnownEnchants()) {
						NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
						enchantList.appendTag(eString);
					}
					drop.getTagCompound().setTag("enchantList", enchantList);
    			}
    			if(((TileEntityEnchantmentFab)tile).getEnchantEssence() > 0 ) 
    			{
    				drop.getTagCompound().setInteger("enchantmentEssence", ((TileEntityEnchantmentFab)tile).getEnchantEssence());
    			}
    		}
    	}
    	
    	drops.clear();
    	drops.add(drop);
    }
    
    @Override
    public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
    	TileEntity tile = worldIn.getTileEntity(pos);
    	if(!worldIn.isRemote) {
    		if(stack != null && tile != null)
    		{
    			if(stack.hasTagCompound() && tile instanceof TileEntityEnchantmentFab)
    			{
    				if(stack.getTagCompound().hasKey("enchantList"))
    				{
    					Set<Enchantment> eList = new HashSet<Enchantment>();
    					NBTTagList list = stack.getTagCompound().getTagList("enchantList", Constants.NBT.TAG_STRING);
    					for (int i = 0; i < list.tagCount(); i++) {
    						Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
    						eList.add(theEnch);
    					}
    					((TileEntityEnchantmentFab) tile).setEnchants(eList);
    				}
    				if(stack.getTagCompound().hasKey("enchantmentEssence"))
    				{
    					((TileEntityEnchantmentFab) tile).enchantmentEssence = stack.getTagCompound().getInteger("enchantmentEssence");
    				}
    			}
    		}
    	}
    }

Thank you.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

May 17, 20187 yr

Look at BlockShulkerBox.

It sets a tag on the item stack called "BlockEntityTag" which is automatically applied to the TE when the block is placed.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

May 19, 20187 yr

Author

Okay thanks, got it to work based on the shulkerbox. Point out any errors if you see any, but it works perfectly.

Spoiler


    @Override
    public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
    	TileEntity tile = worldIn.getTileEntity(pos);
    	if(tile != null)
    	{
    		if(tile instanceof TileEntityEnchantmentFab)
    		{
    			ItemStack item = new ItemStack(Item.getItemFromBlock(this));
    			NBTTagCompound compound = new NBTTagCompound();
    			
    			if(!((TileEntityEnchantmentFab) tile).getKnownEnchants().isEmpty())
    			{
					NBTTagList enchantList = new NBTTagList();
					for(Enchantment e : ((TileEntityEnchantmentFab) tile).getKnownEnchants()) {
						NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
						enchantList.appendTag(eString);
					}
					compound.setTag("enchantList", enchantList);
    			}
    			if(((TileEntityEnchantmentFab)tile).getEnchantEssence() > 0 ) 
    			{
    				compound.setInteger("enchantmentEssence", ((TileEntityEnchantmentFab)tile).getEnchantEssence());
    			}
    			
    			item.setTagCompound(compound);
    			
    			this.spawnAsEntity(worldIn, pos, item);
    		}
    	}
    }
    
    @Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune) {
    	return ItemStack.EMPTY.getItem();
    }
    
    @Override
    public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
    	TileEntity tile = worldIn.getTileEntity(pos);
    	if(!worldIn.isRemote) {
    		if(stack != null && tile != null)
    		{
    			if(stack.hasTagCompound() && tile instanceof TileEntityEnchantmentFab)
    			{
    				if(stack.getTagCompound().hasKey("enchantList"))
    				{
    					Set<Enchantment> eList = new HashSet<Enchantment>();
    					NBTTagList list = stack.getTagCompound().getTagList("enchantList", Constants.NBT.TAG_STRING);
    					for (int i = 0; i < list.tagCount(); i++) {
    						Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
    						eList.add(theEnch);
    					}
    					((TileEntityEnchantmentFab) tile).setEnchants(eList);
    				}
    				if(stack.getTagCompound().hasKey("enchantmentEssence"))
    				{
    					((TileEntityEnchantmentFab) tile).enchantmentEssence = stack.getTagCompound().getInteger("enchantmentEssence");
    				}
    			}
    		}
    	}
    }

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/64466-1122-saving-nbt-to-drops/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 9 hours ago9 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 17 hours ago17 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 17 hours ago17 hr
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · 22 hours ago22 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day

TileEntity

Sign In

[1.12.2] Saving NBT To Drops

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)