Help Changing the Player DisplayName Not Working Fully

[jredfox]

Code for nickname updating in tab still overrides vanilla team and only this code new mdk:

    	SPacketPlayerListItem item = new SPacketPlayerListItem();
        AddPlayerData apd = item.new AddPlayerData(player.getGameProfile(), player.ping, player.interactionManager.getGameType(), new TextComponentString(name.nick));
        ReflectionUtil.setObject(item, SPacketPlayerListItem.Action.UPDATE_DISPLAY_NAME, SPacketPlayerListItem.class, MCPMappings.getField(SPacketPlayerListItem.class, "action"));
        item.getEntries().add(apd);

        for(EntityPlayerMP p : player.mcServer.getPlayerList().getPlayers())
        {
        	p.connection.sendPacket(item);
        }

 

[jredfox]

  On 6/21/2018 at 6:23 PM, diesieben07 said:

Why do you still have this? If you sync the name to the client properly with a custom packet (like I explained a few posts above) this is not needed.

It requires however that you stop hacking shit with reflection and use the proper events (PlayerEvent.NameFormat) on both server and client.

Expand  

Like I said before most events you said for me to sync with are server only thus the need for a packet is needed either way. I will be using name format eventually just trying to get it fully working with only my mod now.

[jredfox]

  On 6/21/2018 at 6:39 PM, diesieben07 said:

Do you even understand what you are doing here? Do you even understand basic server-client infrastructure? Please, follow the instructions in this post. All of them. They will make it work.

 

NameFormat is the way to "get it fully working".

Expand  

Wrong NameFormat doesn't update the tab fresh mdk: 
 

	@SubscribeEvent
    public void nickName(PlayerEvent.NameFormat e)
    {
		e.setDisplayname("jredfox");
    }

in tab says player + int value

And what you told me to do earlier for the tab creates incompatibility with vanilla team system. I might need to create a patch on client side but, without knowing where it's improperly displaying in tab or what the vanilla team system is/isn't doing It's going to be hard to figure out

Edited June 21, 2018 by jredfox

[jredfox]

  On 6/21/2018 at 7:39 PM, diesieben07 said:

Please clarify.

Expand  

the multiplayer tab doesn't update with the code on both sides hard coded to be jredfox thus proving that the tab and name format are two different things. Tested on login shows Player906 rather then jredfox in the multi player tab

Edited June 21, 2018 by jredfox

[jredfox]

  On 6/21/2018 at 7:42 PM, diesieben07 said:

Did you even read what I quoted? What kind of incompatibility with the team system is there?

Yes, I guess the name in the tab menu doesn't update, you'll need the vanilla packet for that, in the same places that you send your custom one.

Expand  

"What kind of incompatibility with the team system is there?" there is no color when sending a my custom nick name to the client's tab and yes even when the commands for the team fire after player does /nick

you  quote only stated name format event and what events to update it on.

 

You told me earlier rather then sending the packet to just update display name for the multi player tab  send in the nick name and that does work but, it overrides the colors of the team on both players client sides even when the command block team fires after you do /nick thus the team isn't changing the tab for some reason when it should be.

 

I guess I could send player.getDisplayName() the entire string after updating it properly but, the point is that won't always work the team can change on tick or when the syncing events you told me about don't fire such as your staring at the player they run the team command block and yay no colors

Edited June 21, 2018 by jredfox

[jredfox]

  On 6/21/2018 at 8:35 PM, diesieben07 said:

Dude. Please work on your sentences. You just spew out words and it takes me minutes to decipher even one of them.

 

To work around the team coloring issue you will have to do the following (guesswork based on the code, not tested as always, testing is on you):

• Do not use the vanilla packet to update the name in the tab menu (SPacketPlayerListItem).
• Instead, from your already existing custom packet, update NetHandlerPlayClient#playerInfoMap (reflection needed, it's private) with a custom NetworkPlayerInfo implementation. In that implementation, override getDisplayName to return your custom name passed through ScorePlayerTeam.formatPlayerName. You get the Team (first parameter for formatPlayerName) from NetworkPlayerInfo#getTeam. You need this custom implementation so that the formatted name is kept up to date (and not just computed once).

Expand  

no I figured it out it's when the string of the display name isn't null it displays that on tab rather then getting it dynamically. Meaning if I send the packet for the tab at all it's going to mess up big time. 

What needs to happen is I need to replace net.minecraft.client.gui.GuiPlayerTabOverlay  how do I do that since gui open event never fires since it's not instance of gui screen?

 

your version would require a client tick handler(too many tick handlers = lag) to properly fix it and I would much rather just replace the gui and the one method causing issues

Edited June 21, 2018 by jredfox

[jredfox]

  On 6/21/2018 at 8:42 PM, diesieben07 said:

Yes. Read what I said above, it solves this problem.

 

No.

Expand  

it would but, again those values would need constant updates for teams that could change before or after respawn tracking etc....

[Draco18s]

Edited June 21, 2018 by Draco18s