Jump to content

Recommended Posts

Posted

Not sure if this is the right place to report something like this but it is a bug so it probably fits here.

Declining the personalised ads/cookies consent on the "files" page of this site requests non-personalised ads like it should BUT personalised ads are still requested and shown after refreshing the page.

Also, cookies are used for non-personalised ads too, so you might want to change the wording of the message a bit. Consent for using cookies and consent for personal data processing are 2 separate things.

Posted

Interesting i'll look into it, however from all of our tests that is not the case. Can you provide what exact version of your browser, you are using. And any possible addons you may have that are interfering with basic java-script functionality. As for the wording, we've had it vetted and it seems to be fine to most reasonable people. I'll see if Paleo can think of even more explicit terms.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted (edited)

I doubt it's my browser. It's the same on Chrome and Edge. On Firefox it says that I have adblock on, which isn't true. I guess that's another bug :D
EDIT: Accidentally posted lol. You should check the ad request URLs for whether the ads are personalised or not. If they don't contain "npa" then the ads are personalised. And I don't think any of my addons can affect this. Here's some info:

Google Chrome 67.0.3396.87 (Official Build) (64-bit) (cohort: 67_win_87)
OS Windows 10
JavaScript V8 6.7.288.46
Edited by Xaero
Posted (edited)

And I don't see 

(adsbygoogle=window.adsbygoogle||[]).requestNonPersonalizedAds=1;

called anywhere in the source or in the scripts that are loaded. It's only in the revokeConsent() and giveConsent() functions. And revokeConsent() isn't called anywhere either from what I've seen (excluding the decline button). Like I said, it's like this only after refreshing the page.

Edited by Xaero
Posted

I think I see where he screwed up. The cookies laws are just dumb, not even the EU's site regarding guidelines for cookies can be entered without storing at least one cookie.

How ever, I've changed the wording slightly, and made the theam code use the normal accept/decline methods. https://github.com/MinecraftForge/Web/commit/53e2919f90a43326e74e25deb3da49ab6d370936

This should be a good stop-gap until paleo can take a look at it.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted

Works like it should now. Good job :)

And I know that this law is pretty weird and confusing. I'm pretty sure a CDN can create cookies under the site's domain but it's not something you have control over. Hopefully such cookies are an exception as they are required to view the site. 

BTW, I know that you are not allowed to refuse services when consent to processing personal data was not given but I don't think it's the same for cookies. This means that you can "force" the user to make a choice before they can access the rest of the site. PlanetMinecraft have done it this way.

I've also read somewhere that if a user requests a service that requires the use of cookies, then no consent is needed: 

"Under the 2012 ePrivacy Directive, Cookie Consent is always required to set cookies, unless the cookies are strictly necessary to deliver a service requested by the individual".

Might fit your dark theme control but I've seen statements that say that all cookie use requires consent and that there will only be exceptions in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.