Keep Blocks Grass except for Block under player

[LittleOne]

Hello,

I'm attempting to change the block under the player, which works, from playerUPos. However, I'm trying to get the surrounding positions in relation to the player and set those blocks to grass. This code isn't working. I think I'm not getting the logic yet. Any help is greatly appreciated!

@SubscribeEvent
	public void onPlayerTickEvent(PlayerTickEvent event) {
		if(event.player instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.player;
			BlockPos playerUPos = player.getPosition().down();
			IBlockState playerUState = player.world.getBlockState(playerUPos);
			BlockPos playerOBPos = player.getPosition().add(5, 2, 5);
			BlockPos playerTBPos = player.getPosition().subtract(playerOBPos);
			Iterable<BlockPos> playerABPos = player.getPosition().getAllInBox(playerOBPos, playerTBPos);
			if(player.onGround && player.world.getBlockState(playerUPos).getBlock() == Blocks.GRASS) {
				player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
			for (BlockPos item : playerABPos) {
				IBlockState newItem = player.world.getBlockState(item);
				Block newItemBlock = newItem.getBlock();
				if(item == playerUPos) {
					player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
				}else {
					if(newItemBlock == Blocks.STONE.getDefaultState()) {
						player.world.setBlockState(item, Blocks.GRASS.getDefaultState());
						}
				}
				}
			}
		}
	}

Also I did try the method by taking each position individually and that worked. However, I feel it was too tedious and it actually didn't work when a player jumped off a bock.

Edited June 14, 2018 by LittleOne

[LittleOne]

Thanks for pointing that out. I changed it to

BlockPos playerTBPos = player.getPosition().add(-5, -2, -5);

However, the blocks are still not changing. Or did I mess up the initialization again?

[Draco18s]

  On 6/14/2018 at 5:54 PM, diesieben07 said:

  On 6/14/2018 at 5:33 PM, LittleOne said:

if(item == playerUPos) {

Expand  

 

This will never be true. == compares object identity. You want equals.

Expand  

I would also refrain from using the name item for this scope variable, as it looks like it refers to an Item (due to the nearby Block newItemBlock = newItem.getBlock();line) but is in fact a BlockPos. I would use pos, loc, location, or point, or similar.

Edited June 14, 2018 by Draco18s

[LittleOne]

Alright thank you! I changed a few things including the variable names and == to .equals(). I think there's something else though because the code still isn't doing what I want it to do. I'm wondering if the whole for loop is somehow being negated.

 

public void onPlayerTickEvent(PlayerTickEvent event) {
		if(event.player instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.player;
			BlockPos playerUPos = player.getPosition().down();
			IBlockState playerUState = player.world.getBlockState(playerUPos);
			BlockPos playerOBPos = player.getPosition().add(5, 2, 5);
			BlockPos playerTBPos = player.getPosition().add(-5, -2, -5);
			Iterable<BlockPos> playerABPos = player.getPosition().getAllInBox(playerOBPos, playerTBPos);
			if(player.onGround && player.world.getBlockState(playerUPos).getBlock() == Blocks.GRASS) {
				player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
			for (BlockPos pos : playerABPos) {
				IBlockState newPosState = player.world.getBlockState(pos);
				Block newPosBlock = newPosState.getBlock();
				if(pos.equals(playerUPos)) {
					player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
				}else {
					if(newPosBlock == Blocks.STONE.getDefaultState()) {
						player.world.setBlockState(pos, Blocks.GRASS.getDefaultState());
						}
				}
				}
			}
		}
	}

Or the part under else is not going through for some reason.

Edited June 14, 2018 by LittleOne