[Solved]Get Entities In Radius Failing

[jredfox]

Here is my code my goal is to get all entities withing the radius of 10,000

	public List<Entity> getEnts(World w,int x, int z,int radius) {
		return w.getEntitiesWithinAABB(Entity.class,  new AxisAlignedBB(x,0,z,x+radius,255,z+radius));
	}

There are lots of pigs and slimes yet it only outputed this list:
 

[06:48:25] [Server thread/INFO] [STDOUT]: [com.EvilNotch.lanessentials.commands.CommandButcher:execute:65]: [EntityPlayerMP['Player52'/298, l='New World', x=172.76, y=4.64, z=-1269.33], EntityItem['item.item.beetroot'/295, l='New World', x=202.14, y=4.94, z=-1258.86], EntityItem['item.item.beetroot_seeds'/296, l='New World', x=202.08, y=5.00, z=-1259.44], EntityItem['item.item.beetroot_seeds'/297, l='New World', x=201.01, y=5.00, z=-1259.89]]

Solved:

	public List<Entity> getEnts(World w,int x, int z,int radius) {
		return w.getEntitiesWithinAABB(Entity.class, new AxisAlignedBB(x,0,z,x+1,257,z+1).grow(radius));
	}

 

Edited July 6, 2018 by jredfox

[jredfox]

14 minutes ago, diesieben07 said:

You are not actually getting entities within a radius, since you are only expanding in the positive direction. You need to start at x-radius and go up to x+radius (radius is half the diameter).

is there a way to get the min and max y dynamically?

 

	public List<Entity> getEnts(World w,int x, int z,int radius) {
		return w.getEntitiesWithinAABB(Entity.class,  new AxisAlignedBB(x-radius,0,z-radius,x+radius,255,z+radius));
	}

 

Edited July 5, 2018 by jredfox

[jredfox]

nevermind

Edited July 5, 2018 by jredfox

[jredfox]

16 minutes ago, diesieben07 said:

You are not actually getting entities within a radius, since you are only expanding in the positive direction. You need to start at x-radius and go up to x+radius (radius is half the diameter).

Edit still not working I put 4 pigs beside me with a block radius of one did my butcher command and it only found 2 out of the 4 pigs in a 1 block radius:

it seems to occur going twords -x and postive z

[jredfox]

35 minutes ago, diesieben07 said:

Are you sure those pigs were actually within the radius? Use the debugger.

I did I printed it said on 0,0 with radius of one -x:-1 +x:1 -z:-1 +z:1

I think they were it's just it uses double values which was < -1 as double and which was > 1 as double. So I used -1.999 and 1.999 to get to the very edge of the block.

That seemed to fix all of my errors

Edited July 5, 2018 by jredfox

[jredfox]

3 hours ago, diesieben07 said:

Are you sure those pigs were actually within the radius? Use the debugger.

this isn't solved still now I am having the opposite problem with having the 0.999+ it's now killing stuff it shouldn't be. if I set it to anything like +0.1 it fixes it but then the older issue of it not killing stuff is back. I think w.getEntitiesWithinAABB() is bugged.

Steps to reproduce:
place armor stands all around you
place one inside of you
do /butcher armor_stand 0
it kills your one and several others a block a way
If you change the 0.9 to 0.1 then it won't kill them all in 1 block radius with /butcher armor_stand 1

Code:
https://github.com/jredfox/lanessentials/blob/master/src/main/java/com/EvilNotch/lanessentials/commands/CommandButcher.java

Edited July 5, 2018 by jredfox

[jredfox]

14 hours ago, diesieben07 said:

You should probably use the floating point entity position (Entity#pos[XYZ]) instead of truncating it to an int.

I copied and pasted the mob spawner code seemed to fix it although I don't understand why there is a +1 on everything. The only thing I changed was the y:
 

	public List<Entity> getEnts(World w,int x, int z,int radius) {
		return w.getEntitiesWithinAABB(Entity.class, new AxisAlignedBB(x,0,z,x+1,257,z+1).grow(radius));
	}

 

[DaemonUmbra]

JRed I have to ask, how did you learn Java?

[Cadiboo]

@jredfox You might not have learned this yet, but the first rule of programming is: Its ALWAYS your fault.

Minecraft is a lot of code by a lot of (mostly novice) programmers, there will be bugs in it. But I highly doubt that any code that gets a lot of use (like getEntitiesWithinAABB). You asked why there is a +1? It turns an AABB representing a point into an AABB with a size of one block.

[jredfox]

11 hours ago, Cadiboo said:

@jredfox You might not have learned this yet, but the first rule of programming is: Its ALWAYS your fault.

Minecraft is a lot of code by a lot of (mostly novice) programmers, there will be bugs in it. But I highly doubt that any code that gets a lot of use (like getEntitiesWithinAABB). You asked why there is a +1? It turns an AABB representing a point into an AABB with a size of one block.

if you read the code I was using what other people gave me and it should have made sense. And no it's not always my fault when it's broken or nobody knows how to use it or it's not made to be used that way.

my original code was x-radius 0,z-radius, x+radius,255,z+radius which should have worked but, for some reason bounding boxes need an extra +xz on their end or it won't work properly and will find entities where it shouldn't be finding them.

[jredfox]

16 hours ago, DaemonUmbra said:

JRed I have to ask, how did you learn Java?

read above if you read anything my original code should have worked it was x+-radius z+-radius and that's what everyone else said as well but, bounding boxes need an extra +1 because they are not meant to be in radius they are meant to be in a box so it doesn't quite work that way. So yes I know java but, the method doesn't do what everyone else said it does the way it said it did that's why I made this forum. I forgot about the mob spawner till the very last post and fixed mine

Edited July 7, 2018 by jredfox

[Cadiboo]

31 minutes ago, jredfox said:

it's not made to be used that way.

Hate to tell you this but this is exactly when it’s your fault. Basically, if your modding minecraft, everything is your fault because minecraft was definitely NOT made to be modded. All of us have to deal with this unfortunate fact everyday. Basically we’re dealing with a dozen other peoples half-written code. You’ve probably figured out by now that even with forge, the end result isn’t pretty. I’m not trying to give you shit but you seem to not understand a lot about how the internals of me work, maybe looking at the concepts that underly it would be a good idea? Who am I kidding your probably gonna have to learn all this through trial and error, as I said minecraft is full of quirks

Edited July 7, 2018 by Cadiboo

[jredfox]

3 minutes ago, Cadiboo said:

Hate to tell you this but this is exactly when it’s your fault. Basically, if your modding minecraft, everything is your fault because minecraft was definitely NOT made to be modded. All of us have to deal with this unfortunate fact everyday. Basically we’re dealing with a dozen other peoples half-written code. You’ve probably figured out by now that even with forge, the end result isn’t pretty.

has nothing to do with that. It wasn't half written it was the simple fact of java x method() doesn't work they way you thought it did because x method needs y() to happen first to your vars

Edited July 7, 2018 by jredfox

[Cadiboo]

4 minutes ago, jredfox said:

has nothing to do with that. It wasn't half written it was the simple fact of java x method() doesn't work they way you thought it did because x method needs y() to happen first to your vars

Um AABB was written by Notch it’s not just a normal java method