[1.12.2] Check if two items are equal [Closed]

[Legenes]

Hi all!

 

I overrided a method, which didn't has the player (so I can't get the item in the mainhand), so I made this ugly line to get it:

worldIn.getClosestPlayer(pos.getX(), pos.getY(), pos.getZ(), 10, false).getHeldItemMainhand().equals(Items.SHEARS)

,but there's something wrong with it, that I can't figure out. Somebody can have a look at it?

(It's in a if statement, and without it works, but not how I want it to.)

 

Thanks!

Edited July 19, 2018 by Legenes

[mirk]

This won't work because the item you're comparing it to isn't the exact pair of shears Minecraft has in mind.

 

You could try using the keyword "instanceof", or there's probably a smarter, Forge-friendly way of doing it that I don't know about.

[Animefan8888]

  On 7/18/2018 at 6:09 PM, mirk said:

This won't work because the item you're comparing it to isn't the exact pair of shears Minecraft has in mind.

 

You could try using the keyword "instanceof", or there's probably a smarter, Forge-friendly way of doing it that I don't know about.

Expand  

This is not true, all Items are singletons(there is only one shears).

  On 7/18/2018 at 5:41 PM, Legenes said:

Somebody can have a look at it?

Expand  

You are comparing and ItemStack to an Item you need to call ItemStack#getItem on your getItemInMainHand

[V0idWa1k3r]

  On 7/18/2018 at 6:09 PM, mirk said:

This won't work because the item you're comparing it to isn't the exact pair of shears Minecraft has in mind.

Expand  

What? Items are singletons.

 

  On 7/18/2018 at 5:41 PM, Legenes said:

worldIn.getClosestPlayer(pos.getX(), pos.getY(), pos.getZ(), 10, false).getHeldItemMainhand().equals(Items.SHEARS)

 

Expand  

EntityPlayer#getHeldItemMainhand returns an ItemStack. Items.SHEARS is an Item. ItemStack != Item. Use ItemStack#getItem

EDIT: Animefan8888 was a second faster I guess

Edited July 18, 2018 by V0idWa1k3r

[mirk]

  On 7/18/2018 at 6:12 PM, Animefan8888 said:

This is not true, all Items are singletons(there is only one shears).

You are comparing and ItemStack to an Item you need to call ItemStack#getItem on your getItemInMainHand

Expand  

 

  On 7/18/2018 at 6:12 PM, V0idWa1k3r said:

What? Items are singletons.

 

EntityPlayer#getHeldItemMainhand returns an ItemStack. Items.SHEARS is an Item. ItemStack != Item.

Expand  

Oh, my bad! I'm still very new to this. I'll stick to asking questions and lurking. ?

[jabelar]

ItemStack class has several methods specifically for checking different amounts of equivalence. You can just check for the same item, but can also check for same item and quantity, or even everything the same including NBT.

[Legenes]

Ok, thank you, it was my fault. But how can I show the help in the IDE? (I use Intellij Idea)

 

EDIT: Oh, I found it, thanks anyway :D.

Edited July 19, 2018 by Legenes