So I've overridden the vanilla strength potion and potion types however when I try to brew the potion the game crashes.

It's obviously because Minecraft is trying to add the brewing recipe for the normal strength potion, but the potion types are not in the registry. How can I fix this?

47 minutes ago, diesieben07 said:

Show what you did.

Registered a normal potion with this

public PotionBase(final boolean isBadEffect, final int liquidColor, final String name, boolean useGlint) {
        super(isBadEffect, liquidColor);
        setPotionName(name);
    }

public Potion setPotionName(final String potionName) {
        this.setRegistryName(potionName);
        final ResourceLocation registryName = Objects.requireNonNull(this.getRegistryName());
        super.setPotionName("effect." + registryName.toString());
        return this;
    }

Except instead of using my mod id I used minecraft

 

Then I registered the potion types like this

public static final PotionType STRENGTH;
public static final PotionType LONG_STRENGTH;
public static final PotionType STRONG_STRENGTH;

static {
      final String LONG_PREFIX = "long_";
      final String STRONG_PREFIX = "strong_";

      final int HELPFUL_DURATION_STANDARD = 3600;
      final int HELPFUL_DURATION_LONG = 9600;
      final int HELPFUL_DURATION_STRONG = 1800;

      final IForgeRegistry<Potion> potionRegistry = ForgeRegistries.POTIONS;
	  final Potion strength = RegistryHelper.getRegistryEntry(potionRegistry, RefPotionNames.STRENGTH);
      
      STRENGTH = createPotionType(new PotionEffect(strength, HELPFUL_DURATION_STANDARD));
      LONG_STRENGTH = createPotionType(new PotionEffect(strength, HELPFUL_DURATION_LONG), LONG_PREFIX);
      STRONG_STRENGTH = createPotionType(new PotionEffect(strength, HELPFUL_DURATION_STRONG, 1), STRONG_PREFIX);
}
        
private static PotionType createPotionType(final PotionEffect effect) {
     return createPotionType(effect, null);
}

private static PotionType createPotionType(final PotionEffect effect, @Nullable final String namePrefix) {
     final ResourceLocation potionName = effect.getPotion().getRegistryName();
     final ResourceLocation potionTypeName;

     if (namePrefix != null) {
         assert potionName != null;
         potionTypeName = new ResourceLocation(
                 potionName.getResourceDomain(), namePrefix + potionName.getResourcePath());
     } else
        potionTypeName = potionName;

        assert potionName != null;

        return new PotionType(potionName.toString(), effect).setRegistryName(potionTypeName);
    }

 

I of course registered both all of these using the RegistryEvent.Register event to register these.

25 minutes ago, diesieben07 said:

You cannot use PotionEffect like that, it is not it's intended purpose. Moreover do not do things like this in static initializers.

And what does this RegistryHelper thing do?

What isn't it's intended purpose? Please elaborate.

The RegistryHelper thing gets the potion from the registry.

39 minutes ago, robmart said:

What isn't it's intended purpose? Please elaborate.

PotionEffects are what get applied to entities.

22 minutes ago, Draco18s said:

PotionEffects are what get applied to entities.

Isn't what I'm doing the same as what vanilla does?

registerPotionType("strength", new PotionType(new PotionEffect[] {new PotionEffect(MobEffects.STRENGTH, 3600)}));

That's from vanilla.

I can see 3 differences:

1. I don't use an array.

2. I don't hardcode the names, I get them from the potion

3. I get the potions from the registry instead of getting them directly

 

What am I doing wrong?

Edited July 23, 20187 yr by robmart

12 minutes ago, diesieben07 said:

Surely it has to do more than that, otherwise you'd just be using IForgeRegistry#getValue.

 

Sorry, I wrote this in a rush and was not accurate.

Again, you must not do those things in a static initializer. Registry entries cannot be accessed properly before preInit and registry entries must be registered during the appropriate registry event.

 

Also please post your actual code where you register your overriding registry entry.

1

Alright, I'll get rid of the static initializer.

Here is the code for the register thingy

public static <T extends IForgeRegistryEntry<T>> T getRegistryEntry(
            final IForgeRegistry<T> registry, final String name) {
        final ResourceLocation key = new ResourceLocation(name);
        final T registryEntry = registry.getValue(key);
        return Preconditions.checkNotNull(registryEntry, "%s doesn't exist in registry %s", key,
                                          RegistryManager.ACTIVE.getName(registry));
    }

Basically just a slightly better IForgeRegistry#getValue

 

The code I use to register the potion types is the same as normal

@SubscribeEvent
    public static void registerPotionTypes(final RegistryEvent.Register<PotionType> event) {
        event.getRegistry().registerAll(
                STRENGTH,
                LONG_STRENGTH,
                STRONG_STRENGTH
      			);

 

1 hour ago, diesieben07 said:

Hm. I can't see too much wrong with that. 

Is it maybe because PotionUtils#addPotionToItemStack tries to get the name of the potion from the registry and since it isn't in the registry (overridden) it crashes?

 

E: And it never checks if it's null because that'd be a smart thing to do

Edited July 23, 20187 yr by robmart