Swim with LivingUpdateEvent [1.9.4]

[JeanMiecraft]

Hello, I create a custom Fluid with a custom material, but if I wrote this topic, it's because I don't know how create the swimming and the slow movements in the material. I sought in the EntityLivingBase in the moveEntityWithHeading and in the onLivingUpdate but it doesn't work. Can you help me for this problem?

Thank you so much for your help!

 

-JM

[Draco18s]

Its hard. :\

Vanilla handles water movement in the Entity class itself and checks for explicitly Material.WATER

You basically have to find that code and copy it to an event handler.

[jabelar]

It's pretty tough actually, you have to sort of replace a lot of vanilla movement code. I actually submitted a PR to add ability for custom fluids to automatically do this, but the Forge gods are really busy with 1.13 right now. Some day...

 

Here is how I did it using events though: http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-fluid-blocks.html

 

It is intrusive and a lot of coding but it is possible to make your custom fluids behave mostly like vanilla.

 

[JeanMiecraft]

For the player, I use this:

 

Minecraft mc = Minecraft.getMinecraft();
boolean jump = mc.gameSettings.keyBindJump.isKeyDown();

 if (jump == true)
 {
     entity.motionY = 0.10000001192092896D;
 }

 

 

The problem for the player is the speed, it's possible to slow down look like the slowness potion?

And for the other EntityLiving, I don't know because if I use:

 

 entity.motionY = 0.10000001192092896D;

It work, but they can't move. For example, if I have in my hand a carrot and the entity in my custom fluid is a pig. The motionX and motionZ equal 0;

Thank you for your answer!

 

- JM

[DaemonUmbra]

Please look into the concept of Sides and consider using a more modern version of Minecraft.

[JeanMiecraft]

Ah yes there are a little forgetfulness for my part... I corrige that.

For the version, I use forge 1.9.4 because for mi the newest version: 1.10, 1.11 and 1.12 don't work...

[TheMario]

Hi, have you resolved this topic?

[JeanMiecraft]

Hello, no this isn't resolved but with the help, I modified the respiration in the liquid.

 

On 8/18/2018 at 5:47 PM, jabelar said:

It's pretty tough actually, you have to sort of replace a lot of vanilla movement code. I actually submitted a PR to add ability for custom fluids to automatically do this, but the Forge gods are really busy with 1.13 right now. Some day...

 

Here is how I did it using events though: http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-fluid-blocks.html

 

It is intrusive and a lot of coding but it is possible to make your custom fluids behave mostly like vanilla.

 

 

With that, I add to my fluid the finishes as the drown and the bubbles.

Now the problem is the entity's motionY when she jump and the water or lava movement for the player.

In the EntityLivingBase for the entity I compare the levitation potion but it's doesn't work...

Can you tell me where is the class with the swimming for the entities and the player please.

It's very important for me!

 

- JM

[jabelar]

EntityLivingBase has two methods, handleJumpWater() and handleJumpLava() that simply adjust the motionY. These methods rely on the isInLiquid() method.

 

It might be difficult to intercept them though because they are buried inside the living update and update loops. For example, you could handle the LivingUpdateEvent, but you'd have to recreate a lot of the vanilla code I think.

[JeanMiecraft]

Hello...

Thank you for this answer!

I see, this method is in the PathNavigate, in the PathNavigateGround and in the PathNavigateSwimmer... In the EntityAISwimming, I found that:

 

((PathNavigateGround)entitylivingIn.getNavigator()).setCanSwim(true);

 

The "getNavigator" is register in the EntityLiving. It's possible to change the boolean value if an entity is in my fluid?

If yes, where I can place this method?

[Draco18s]

That is not what that does.

If you change that value, it means the entity can not swim in anything. And again, the concept of "swimming" as far as Minecraft is concerned is Material.WATER and only Material.WATER

Edited August 21, 2018 by Draco18s

[JeanMiecraft]

7 minutes ago, Draco18s said:

That is not what that does.

If you change that value, it means the entity can not swim in anything. And again, the concept of "swimming" as far as Minecraft is concerned is Material.WATER and only Material.WATER

We can "swim" in lava too. 

Okay, I understand... but it's possible to recreate with a event the swimming effect and the entity can move?

I want my custom material because with the Material.WATER or Material.LAVA, there are secondary effects...

Thank you for your help!

[Draco18s]

37 minutes ago, JeanMiecraft said:

We can "swim" in lava too. 

Its handled by separate code. You don't actually swim in lava.

 

Go look at EntityLivingBase lines 2572-2587 and lines 235-238 as well as Entity line 545.

 

Quote

Okay, I understand... but it's possible to recreate with a event the swimming effect and the entity can move?

I want my custom material because with the Material.WATER or Material.LAVA, there are secondary effects...

Thank you for your help!

Yes:

On 8/18/2018 at 11:22 AM, Draco18s said:

You basically have to find that code and copy it to an event handler.

On 8/18/2018 at 11:47 AM, jabelar said:

It is intrusive and a lot of coding but it is possible to make your custom fluids behave mostly like vanilla.

 

 

Edited August 21, 2018 by Draco18s

[TheMario]

You speak about the movement of water but it is the push if the liquid flow. I do not understand the relation with the swimming.

[Draco18s]

7 hours ago, TheMario said:

You speak about the movement of water but it is the push if the liquid flow. I do not understand the relation with the swimming.

Did you look at the code I mentioned?

One of them directly relates to what happens when you jump and are inside water/lava.

[JeanMiecraft]

23 hours ago, TheMario said:

You speak about the movement of water but it is the push if the liquid flow. I do not understand the relation with the swimming.

No, it is the swimming... The problem maintaining, it is to apply this method when the entity jumps or if the player presses the space key...