[1.12.2]aded NBT with Tile Entity is removed

[K10]

Hi.

 

I added forge 1.12.2 item which teleport any entity to specific position and block that determine the position. The data of teleportation is saved NBT of item.

However, NBT data is lost.

 

The scene is when I picked item on block's gui (without Shift).

 

additionally, an entity does not teleport to the place set without opening the inventory at once.

 

anyone help me ?

 

https://github.com/nihotamor/pipocraft/tree/master/

[Draco18s]

Various other things I'm noticing while looking for your problem:

1) These three classes are identical, you don't need three identical classes, you can call new() and just give them different names.

https://github.com/nihotamor/pipocraft/blob/master/src/main/java/doph/pipocraft/item/ItemGachaChip.java

https://github.com/nihotamor/pipocraft/blob/master/src/main/java/doph/pipocraft/item/ItemGoldGachaChip.java

https://github.com/nihotamor/pipocraft/blob/master/src/main/java/doph/pipocraft/item/ItemSilverGachaChip.java

 

2) Ditto all of these classes:

https://github.com/nihotamor/pipocraft/tree/master/src/main/java/doph/pipocraft/item/itemblock

Heck, what was wrong with the original ItemBlock class? Looks like you did this just so you could call your Utils.setName method (which I feel you don't need at all, see #3)

 

3) What is this nonsense:
https://github.com/nihotamor/pipocraft/blob/master/src/main/java/doph/pipocraft/system/Utils.java#L20-L26

You call this from inside the item or block class and it doesn't do anything particularly necessary. You could have at least had it use item.getRegistryName() instead of reconstructing it from string bits a second time. Besides, you don't need this at all, you can just call setRegistryName and setUnlocalized name from anywhere (as evidenced by how the utility function works), it doesn't need to call from inside the block or item.

 

4) Why does this class (and its compatriots) exist? Why are they not static if you insist?

https://github.com/nihotamor/pipocraft/blob/master/src/main/java/doph/pipocraft/init/register/BlockRegister.java

 

Code Style Issue #1

 

Now, your actual problem:

https://github.com/nihotamor/pipocraft/blob/master/src/main/java/doph/pipocraft/gui/GuiContainerTransferMachine.java#L44-L64

Congrats, you set the NBT on the client inside the GUI class. No wonder you have a problem. You need to send a packet to the server that tells the server "this button was clicked" and have the server add the NBT (after making sure the user was allowed to do that action!)

 

[K10]

Thanks for a lot of advices!

 

I tried them and it worked well!