Jump to content

[Solved] Screen blacking when rendering transparent entity as overlay


Recommended Posts

Posted (edited)

A mod I am working on tries to display mobs that are sneaking up behind you, by showing little versions on the sides of your screen. Here is how it's supposed to work:

2018-08-24_17_18_33.png.0be1c94bad6b3f1f7b1027acce8b1f39.png

The display code shown was copied from ToroCraft's ToroHealth (Source On GitHub) ToroHealth seems to have no problem with this, but whenever the display shows a slime(Or any other partially transparent entity i'm guessing) this happens:

2018-08-24_17_18_46.png.76ca27ea9c9a0a49e0c072e136e7d97a.png

Any idea why or how to fix it? Thanks. :)

Render Code:

Spoiler

@SubscribeEvent
	public void renderEntityWarnings(RenderGameOverlayEvent.Pre event) {
		EntityPlayer player = Minecraft.getMinecraft().player;
		if (event.getType() == ElementType.CHAT || player == null || player.world == null) return;
		List<Entity> ewl = player.world.getEntitiesWithinAABBExcludingEntity(player, player.getEntityBoundingBox().grow(Config.Warnings.range, 5, Config.Warnings.range));
		for (Entity e : ewl) {
			if (e instanceof EntityLivingBase) {
				EntityLivingBase entity = (EntityLivingBase) e;
				Frustum fr = new Frustum();
				fr.setPosition(player.posX, player.posY, player.posZ);
				if (!fr.isBoundingBoxInFrustum(e.getEntityBoundingBox())) {
					EntityDisplay ed = new EntityDisplay(Minecraft.getMinecraft());
					ed.setEntity(entity);
					ed.setPosition(0, 50);
					ed.draw();
				}
			} else {
				// do dis
			}
		}
	}
	
	public static class EntityDisplay {
		private static final int RENDER_HEIGHT = 30;
		private static final int RENDER_WIDTH = 18;
		private static final int PADDING = 2;
		private static final int WIDTH = 40;
		private static final int HEIGHT = WIDTH;

		private int y;

		private float glX;
		private float glY;

		private EntityLivingBase entity;
		private Entity leashedToEntity;
		private float prevYawOffset;
		private float prevYaw;
		private float prevPitch;
		private float prevYawHead;
		private float prevPrevYahHead;
		private int scale = 1;

		public EntityDisplay(Minecraft mc) {
		}

		public void setPosition(int x, int y) {
			this.y = y;
			glX = (float) x + WIDTH / 2;
			updateScale();
		}

		public void setEntity(EntityLivingBase entity) {
			this.entity = entity;
			updateScale();
		}

		public void draw() {
			try {
				pushEntityLeasedTo();
				pushEntityRotations();
				glDraw();
				popEntityRotations();
				popEntityLeasedTo();
			} catch (Throwable ignore) {
			}
		}

		private void updateScale() {
			if (entity == null) {
				glY = (float) y + HEIGHT - PADDING;
				return;
			}
			int scaleY = MathHelper.ceil(RENDER_HEIGHT / entity.height);
			int scaleX = MathHelper.ceil(RENDER_WIDTH / entity.width);
			scale = Math.min(scaleX, scaleY);
			glY = (float) y + (HEIGHT / 2 + RENDER_HEIGHT / 2);
			//if (entity instanceof EntityGhast) {
			//	glY -= 10;
			//}
		}

		private void glDraw() {
			GlStateManager.enableColorMaterial();
			GlStateManager.pushMatrix();

			GlStateManager.translate(glX, glY, 50.0F);
			GlStateManager.scale((float) (-scale), (float) scale, (float) scale);
			GlStateManager.rotate(180.0F, 0.0F, 0.0F, 1.0F);
			GlStateManager.rotate(135.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(-100.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(0.0f, 1.0F, 0.0F, 0.0F);

			RenderHelper.enableStandardItemLighting();

			GlStateManager.translate(0.0F, 0.0F, 0.0F);
			RenderManager rendermanager = Minecraft.getMinecraft().getRenderManager();
			rendermanager.setPlayerViewY(180.0F);
			rendermanager.setRenderShadow(false);
			rendermanager.renderEntity(entity, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
			rendermanager.setRenderShadow(true);

			GlStateManager.popMatrix();
			RenderHelper.disableStandardItemLighting();
			GlStateManager.disableRescaleNormal();
			GlStateManager.setActiveTexture(OpenGlHelper.lightmapTexUnit);
			GlStateManager.disableTexture2D();
			GlStateManager.setActiveTexture(OpenGlHelper.defaultTexUnit);
		}

		private void popEntityLeasedTo() {
			if (entity instanceof EntityLiving && leashedToEntity != null) {
				((EntityLiving) entity).setLeashHolder(leashedToEntity, false);
				leashedToEntity = null;
			}
		}

		private void pushEntityLeasedTo() {
			if (entity instanceof EntityLiving) {
				if (((EntityLiving) entity).getLeashed()) {
					leashedToEntity = ((EntityLiving) entity).getLeashHolder();
					((EntityLiving) entity).setLeashHolder(null, false);
				}
			}
		}

		private void popEntityRotations() {
			entity.renderYawOffset = prevYawOffset;
			entity.rotationYaw = prevYaw;
			entity.rotationPitch = prevPitch;
			entity.rotationYawHead = prevYawHead;
			entity.prevRotationYawHead = prevPrevYahHead;
		}

		private void pushEntityRotations() {
			prevYawOffset = entity.renderYawOffset;
			prevYaw = entity.rotationYaw;
			prevPitch = entity.rotationPitch;
			prevYawHead = entity.rotationYawHead;
			prevPrevYahHead = entity.prevRotationYawHead;
			entity.renderYawOffset = 0.0f;
			entity.rotationYaw = 0.0f;
			entity.rotationPitch = 0.0f;
			entity.rotationYawHead = 0.0f;
			entity.prevRotationYawHead = 0.0f;
		}
	}

 

Edit: Happens with wither skeletons too

Edited by GiantNuker
Posted

The slime is likely changing rendering flags and your code doesn't correctly account for it. Namely, slimes are transparent.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
13 hours ago, Draco18s said:

The slime is likely changing rendering flags and your code doesn't correctly account for it. Namely, slimes are transparent.

Thank you, I will look into this.

Posted

I checked ToroHealth and Can't seem to find anything. The mod does render a skin into the background though.

It uses:

private void drawSkin() {
		if (ConfigurationHandler.skin.equals("NONE")) {
			return;
		}
		
		if (ConfigurationHandler.skin.equals("HEAVY")) {
			mc.getTextureManager().bindTexture(SKIN_HEAVY);
		}else{
			mc.getTextureManager().bindTexture(SKIN_BASIC);
		}
		
		GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
		Gui.drawModalRectWithCustomSizedTexture(screenX - 10, screenY - 10, 0.0f, 0.0f, 160, 60, 160, 60);
	}

I am not very good with OpenGL, but I don't think this has anything. The render entity code is exactly the same, I had something else, but now I'm using the same renderer to try to get rid of this.

Entity render code:

Spoiler

public static class EntityDisplay {
		private static final int RENDER_HEIGHT = 30;
		private static final int RENDER_WIDTH = 18;
		private static final int PADDING = 2;
		private static final int WIDTH = 40;
		private static final int HEIGHT = WIDTH;

		private int y;

		private float glX;
		private float glY;

		private EntityLivingBase entity;
		private Entity leashedToEntity;
		private float prevYawOffset;
		private float prevYaw;
		private float prevPitch;
		private float prevYawHead;
		private float prevPrevYahHead;
		private int scale = 1;

		public EntityDisplay(Minecraft mc) {
		}

		public void setPosition(int x, int y) {
			this.y = y;
			glX = (float) x + WIDTH / 2;
			updateScale();
		}

		public void setEntity(EntityLivingBase entity) {
			this.entity = entity;
			updateScale();
		}

		public void draw() {
			try {
				pushEntityLeasedTo();
				pushEntityRotations();
				glDraw();
				popEntityRotations();
				popEntityLeasedTo();
			} catch (Throwable ignore) {
			}
		}

		private void updateScale() {
			if (entity == null) {
				glY = (float) y + HEIGHT - PADDING;
				return;
			}
			int scaleY = MathHelper.ceil(RENDER_HEIGHT / entity.height);
			int scaleX = MathHelper.ceil(RENDER_WIDTH / entity.width);
			scale = Math.min(scaleX, scaleY);
			glY = (float) y + (HEIGHT / 2 + RENDER_HEIGHT / 2);
			//if (entity instanceof EntityGhast) {
			//	glY -= 10;
			//}
		}

		private void glDraw() {
			GlStateManager.enableColorMaterial();
			GlStateManager.pushMatrix();

			GlStateManager.translate(glX, glY, 50.0F);
			GlStateManager.scale((float) (-scale), (float) scale, (float) scale);
			GlStateManager.rotate(180.0F, 0.0F, 0.0F, 1.0F);
			GlStateManager.rotate(135.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(-100.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(0.0f, 1.0F, 0.0F, 0.0F);

			RenderHelper.enableStandardItemLighting();

			GlStateManager.translate(0.0F, 0.0F, 0.0F);
			RenderManager rendermanager = Minecraft.getMinecraft().getRenderManager();
			rendermanager.setPlayerViewY(180.0F);
			rendermanager.setRenderShadow(false);
			rendermanager.renderEntity(entity, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
			rendermanager.setRenderShadow(true);

			GlStateManager.popMatrix();
			RenderHelper.disableStandardItemLighting();
			GlStateManager.disableRescaleNormal();
			GlStateManager.setActiveTexture(OpenGlHelper.lightmapTexUnit);
			GlStateManager.disableTexture2D();
			GlStateManager.setActiveTexture(OpenGlHelper.defaultTexUnit);
		}

		private void popEntityLeasedTo() {
			if (entity instanceof EntityLiving && leashedToEntity != null) {
				((EntityLiving) entity).setLeashHolder(leashedToEntity, false);
				leashedToEntity = null;
			}
		}

		private void pushEntityLeasedTo() {
			if (entity instanceof EntityLiving) {
				if (((EntityLiving) entity).getLeashed()) {
					leashedToEntity = ((EntityLiving) entity).getLeashHolder();
					((EntityLiving) entity).setLeashHolder(null, false);
				}
			}
		}

		private void popEntityRotations() {
			entity.renderYawOffset = prevYawOffset;
			entity.rotationYaw = prevYaw;
			entity.rotationPitch = prevPitch;
			entity.rotationYawHead = prevYawHead;
			entity.prevRotationYawHead = prevPrevYahHead;
		}

		private void pushEntityRotations() {
			prevYawOffset = entity.renderYawOffset;
			prevYaw = entity.rotationYaw;
			prevPitch = entity.rotationPitch;
			prevYawHead = entity.rotationYawHead;
			prevPrevYahHead = entity.prevRotationYawHead;
			entity.renderYawOffset = 0.0f;
			entity.rotationYaw = 0.0f;
			entity.rotationPitch = 0.0f;
			entity.rotationYawHead = 0.0f;
			entity.prevRotationYawHead = 0.0f;
		}
	}

 

 

Posted
On 8/25/2018 at 11:11 AM, Draco18s said:

The slime is likely changing rendering flags and your code doesn't correctly account for it. Namely, slimes are transparent.

 

13 hours ago, GiantNuker said:

I checked ToroHealth and Can't seem to find anything. The mod does render a skin into the background though.

Have you tried playing around and making sure transparency is off/on and texture2d is off/on? those probably aren't the rendering flags that you want, but their a good start

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
11 hours ago, Cadiboo said:

 

Have you tried playing around and making sure transparency is off/on and texture2d is off/on? those probably aren't the rendering flags that you want, but their a good start

How would i turn transparency on and off?

 

Also, i think there might be a difference between whatever version had "doRenderEntity" and 1.12.2 "renderEntity" I'm retty sure ToroCraft just hasnt updated the github repositiory. That is the only difference I can see codewise so far. :(

Posted

That's what happens when you bind a texture and don't rebind what Minecraft was already using.

 

In this case, you bound the font texture (which the FontRenderer class does for you, automatically) during the rendering of non-font UI objects.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
52 minutes ago, Draco18s said:

That's what happens when you bind a texture and don't rebind what Minecraft was already using.

 

In this case, you bound the font texture (which the FontRenderer class does for you, automatically) during the rendering of non-font UI objects.

Thank you. How do I rebind the previous texture though?

 

Edit: this stops screen blacking, but still dosent render the transparency:

GL11.glPushAttrib(GL11.GL_ALL_ATTRIB_BITS);
rendermanager.renderEntity(entity, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
GL11.glPopAttrib();

Source: http://www.minecraftforge.net/forum/topic/32488-1710-rendering-semi-transparent-mobs/?do=findComment&comment=171749

Rendering issues with this method:

Spoiler

 

2018-08-26_11_57_28.thumb.png.309c77501ccfb53338795597c39fd144.png

Issues:Transparency (See : slime, boots, text, glint)

 

Edited by GiantNuker
Posted
6 hours ago, GiantNuker said:

Thank you. How do I rebind the previous texture though?

 

Edit: this stops screen blacking, but still dosent render the transparency:


GL11.glPushAttrib(GL11.GL_ALL_ATTRIB_BITS);
rendermanager.renderEntity(entity, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
GL11.glPopAttrib();

Source: http://www.minecraftforge.net/forum/topic/32488-1710-rendering-semi-transparent-mobs/?do=findComment&comment=171749

Rendering issues with this method:

  Reveal hidden contents

 

2018-08-26_11_57_28.thumb.png.309c77501ccfb53338795597c39fd144.png

Issues:Transparency (See : slime, boots, text, glint)

 

Don’t use GL directly, use GLStateManager

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
3 hours ago, GiantNuker said:

I am sorry, but I just found out the root cause of my problem.

I used RenderGameOverlay.Pre instead of Post.

 

With a little bit of tweaking, now it works :D

 

If you would like to use it:

Highlighter[1.0-1.12.2].jar - Download

Highlighter[1.0-1.12.2]-source.jar - Sources

 

Thank you @Draco18s @Cadiboo

Great! But make sure you are making GL calls to GLStateManager and not GL11.

https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/modification-development/2231761-opengl-calls-glstatemanager

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
10 minutes ago, Cadiboo said:
GlStateManager.enableColorMaterial();
			GlStateManager.pushMatrix();

			GlStateManager.translate(glX, glY, 50.0F);
			GlStateManager.scale((float) (-scale * scaleM), (float) scale * scaleM, (float) scale * scaleM);
			GlStateManager.rotate(180.0F, 0.0F, 0.0F, 1.0F);
			GlStateManager.rotate(135.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(-100.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(0.0f, 1.0F, 0.0F, 0.0F);

			RenderHelper.enableStandardItemLighting();

			GlStateManager.translate(0.0F, 0.0F, 0.0F);
			RenderManager rendermanager = Minecraft.getMinecraft().getRenderManager();
			rendermanager.setPlayerViewY(180.0F);
			rendermanager.setRenderShadow(false);
			GlStateManager.pushMatrix();
			GlStateManager.disableLighting();
			OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, 240f, 240f);
			GlStateManager.popMatrix();
			rendermanager.renderEntity(entity, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
			GlStateManager.pushMatrix();
			GlStateManager.enableLighting();
			OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, 240f, 240f);
			GlStateManager.popMatrix();
			rendermanager.setRenderShadow(true);

			GlStateManager.popMatrix();
			RenderHelper.disableStandardItemLighting();
			GlStateManager.disableRescaleNormal();
			GlStateManager.setActiveTexture(OpenGlHelper.lightmapTexUnit);
			//GlStateManager.disableTexture2D();
			GlStateManager.setActiveTexture(OpenGlHelper.defaultTexUnit);

Do i still need the calls to OpenGlHelper?

Posted
6 minutes ago, GiantNuker said:

GlStateManager.enableColorMaterial();
			GlStateManager.pushMatrix();

			GlStateManager.translate(glX, glY, 50.0F);
			GlStateManager.scale((float) (-scale * scaleM), (float) scale * scaleM, (float) scale * scaleM);
			GlStateManager.rotate(180.0F, 0.0F, 0.0F, 1.0F);
			GlStateManager.rotate(135.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(-100.0F, 0.0F, 1.0F, 0.0F);
			GlStateManager.rotate(0.0f, 1.0F, 0.0F, 0.0F);

			RenderHelper.enableStandardItemLighting();

			GlStateManager.translate(0.0F, 0.0F, 0.0F);
			RenderManager rendermanager = Minecraft.getMinecraft().getRenderManager();
			rendermanager.setPlayerViewY(180.0F);
			rendermanager.setRenderShadow(false);
			GlStateManager.pushMatrix();
			GlStateManager.disableLighting();
			OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, 240f, 240f);
			GlStateManager.popMatrix();
			rendermanager.renderEntity(entity, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
			GlStateManager.pushMatrix();
			GlStateManager.enableLighting();
			OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, 240f, 240f);
			GlStateManager.popMatrix();
			rendermanager.setRenderShadow(true);

			GlStateManager.popMatrix();
			RenderHelper.disableStandardItemLighting();
			GlStateManager.disableRescaleNormal();
			GlStateManager.setActiveTexture(OpenGlHelper.lightmapTexUnit);
			//GlStateManager.disableTexture2D();
			GlStateManager.setActiveTexture(OpenGlHelper.defaultTexUnit);

Do i still need the calls to OpenGlHelper?

The one that sets a high brightness? Yes if you still want that, otherwise your code looks good but could do with a little bit of cleanup

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.