Custom Furnace is not smelting

[CrashCZ]

Hello my custom furnace with two inputs does not smelt

Here is link to GitHub: https://github.com/nickname-crash/minerals

Please Help

[Draco18s]

I love how you have this flag:

boolean flag = this.isBurning();

And then keep doing this:

if(this.isBurning() || ...

if(this.isBurning())

if(this.isBurning() && ...

Also don't use IInventory, use ItemStackHandler and Capabilities instead.

Also don't use ITileEntityProvider, override the hasTileEntity and getTileEntity methods present in the Block class.

You haven't overridden shouldRefresh, which likely causes your TE to get deleted and recreated when your block changes from not-lit to lit (and back). This is because you went the dumb vanilla route of using two blocks instead of a block state property to store that particular value.

[CrashCZ]

45 minutes ago, Draco18s said:

I love how you have this flag:

boolean flag = this.isBurning();

And then keep doing this:

if(this.isBurning() || ...

if(this.isBurning())

if(this.isBurning() && ...

Also don't use IInventory, use ItemStackHandler and Capabilities instead.

Also don't use ITileEntityProvider, override the hasTileEntity and getTileEntity methods present in the Block class.

You haven't overridden shouldRefresh, which likely causes your TE to get deleted and recreated when your block changes from not-lit to lit (and back). This is because you went the dumb vanilla route of using two blocks instead of a block state property to store that particular value.

OK I chnged it and now it does some weired stuff...

[Draco18s]

I can't diagnose weird.

[CrashCZ]

Just now, Draco18s said:

I can't diagnose weird.

When I place items and fuel in it, it takes them, changes the flame texture in gui but that's all. When I do it again it works how it should but only once and no more.

[Draco18s]

Use the debugger. Set some breakpoints and figure it out.

[Cadiboo]

9 hours ago, Draco18s said:

This is because you went the dumb vanilla route of using two blocks instead of a block state property to store that particular value

Don’t copy the vanilla furnace, it’s code that’s existed for many (6?) years without much change while everything else has changed substantially. Forge also provides additional systems that make stuff like furnaces very easy to create such as the ItemStackHandler. Use it instead of IInventory.