Jump to content

[1.12.2] [Solved] Possible to disable MusicTicker?


FireController1847

Recommended Posts

So I've been working on a mod that completely overhauls the music system in Minecraft, but I have one issue that I don't want to let my little "hack" 'fix'.

Basically, I have my own MusicTicker that handles its own randoms, but while mine runs the Minecraft music ticker runs in the background as well. Is there a way to disable it outright, or somehow override it, or is the code below the only way of "handling" it?

The code below is how I am handling this right now...
 

@SubscribeEvent
  public void onSoundPlayed(PlaySoundEvent event) {
  if (AdvancedMusic.musicTicker == null)
    return;
  if (event.getSound().getCategory() == SoundCategory.MUSIC) {
    System.out.println("SONG MUSIC");
    if (!(event.getSound() instanceof Song)) {
      event.setResultSound(null);
      return;
    }
    if (AdvancedMusic.musicTicker.getCurrentMusic() == null)
      return;
    System.out.println("CUSTOM SONG MUSIC");
    System.out.println("CURRENT SONG: " + AdvancedMusic.musicTicker.getCurrentMusic().getName());
  }
}

 

Edited by FireController1847

I am on my journey of making a remake of matmos, as explained here.

Link to comment
Share on other sites

I don't know, just the fact that there's another listener constantly checking for songs every client tick in the background. It's like having two full music systems running. But I have no problem doing it this way, I was just wondering if there was a better way I didn't know about :)

I am on my journey of making a remake of matmos, as explained here.

Link to comment
Share on other sites

In modern computing having something that is checked occasionally isn't going to be a performance problem. Even every tick there are literally 10's of thousands (maybe more) checks going on. The only things that will really bog down a computer nowadays are things like large loops or recursions especially if they include expensive operations. But just doing a couple straight-forward checks for value and/or type on the occasion where the music attempts to start won't be a problem.

 

When programming it is good to think about performance optimization but you should always start with trying to make your code well-structured logically. This helps prevent bugs and aids maintenance and collaboration. If you think there is a possible performance concern then profile your code and see what is really causing problems and focus on that. There is no point fretting over the little stuff when performance is going to be dominated by a couple big offenders.

  • Thanks 1

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi I have an issue with a server it solved deleting the ice and fire but my friends and me really want to use it does any of these mods are causing the issue due to incompatibility  Security craft Aquaculture Architectury Artifacts Astikorcarts Baubles BetterCaves yungs BetterStrongholds yungs BetterMineshafts yungs Bountiful Byg  Callablehorses Carry on Chococraft Citadel Clumps Collective Comforts Corailrecycler Craftable horse armor Comes alive Curios forge Decocraft Dungeonsarise  Open blocks elevator Expandability Farlanders Goblin traders Hwyla  Ice and fire Infernal expansion Jei Jump over fences Mantle  Macaws bridges Macaws doors Macaws fences Macaws furniture  Macaws fencesbyg Morpheus Mouse tweaks Mowzies mobs Obfuscate Paraglider Patchouli  Pick up notifier Random village names Spartan shields Small ships Sophisticated backpacks Spartan weaponry Storage drawers straw golem Structure gel Twilight forest  Tinkers construct Two players one horse  Valhesia core  Valhesia structures  Way stones  Vehicle mod  Wall jump Wings Wolves with armor Xptome  Xaeros minimap  Yungsapi  
    • { "type": "magic_overhaul:rune_inscribing", "base": { "item": "//base item" }, "template": { "item": "//template item" }, "output": { "count": 1, "item": "//output item" } } ^ Ok, where is your recipe JSON placed in your file structure? What's it called? And paste the actual JSON you're testing with, because it needs to be valid.
    • I'm trying to run Forge 1.12.2 on Minecraft  so I can use certain mods, but this error popped up. I've seen multiple errors but I just can't figure this one out. Unable to locate the Java runtime. Error details: 0x00000000 - system: The operation completed successfully. Filename on disk:  Path: . Exists: Directory
    • https://mclo.gs/b422RFc
    • Плагин и Приват
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.