ForeGradle 3.+ isn't found on forge Maven... - How to create a PR to 1.13-pre then?

[Major Tuvok]

Hello guys, so I just intended to start working on my PR for #5060 but when trying to setup a new workspace on my from 1.13-pre pulled 1.13 branch I ran into the following error;

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'Forge'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find any version that matches net.minecraftforge.gradle:ForgeGradle:3.+.
     Versions that do not match:
       - 2.3-SNAPSHOT
       - 2.2-SNAPSHOT
       - 2.1-SNAPSHOT
       - 2.0.2
       - 2.0.1
       - + 16 more
     Searched in the following locations:
       - file:/C:/Users/[NameOmmitted]/.m2/repository/net/minecraftforge/gradle/ForgeGradle/maven-metadata.xml
       - file:/C:/Users/[NameOmmitted]/.m2/repository/net/minecraftforge/gradle/ForgeGradle/
       - http://files.minecraftforge.net/maven/net/minecraftforge/gradle/ForgeGradle/maven-metadata.xml
       - https://jcenter.bintray.com/net/minecraftforge/gradle/ForgeGradle/maven-metadata.xml
       - https://jcenter.bintray.com/net/minecraftforge/gradle/ForgeGradle/
       - https://repo.maven.apache.org/maven2/net/minecraftforge/gradle/ForgeGradle/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/net/minecraftforge/gradle/ForgeGradle/
       - https://plugins.gradle.org/m2/net/minecraftforge/gradle/ForgeGradle/maven-metadata.xml
       - https://plugins.gradle.org/m2/net/minecraftforge/gradle/ForgeGradle/
     Required by:
         project :

So my conclusion was that he wasn't able to fetch it from forge's maven-repo. I therefore downloaded the ForeGradle Release directly from github and (after changing the ending from .zip to .jar) put it in a lib folder directly below .gradle (resulting in [project-root]/.gradle/lib/ForgeGradle-3.0.jar)) and changed forge's build.gradle buildscript block to 

buildscript {
    repositories {
        mavenLocal()
        maven { url = 'http://files.minecraftforge.net/maven' }
        jcenter()
        mavenCentral()
    }
    dependencies {
        classpath files('.gradle/lib/ForgeGradle-3.0.jar')
    }
}

(the only change is swapping out

classpath 'net.minecraftforge.gradle:ForgeGradle:3.+'

with the one described above)

 

This now produces a different error (it seems to recognize it as a dependency at least, but can't use it)

FAILURE: Build failed with an exception.

* Where:
Build file 'D:\Daten\Briefe\[NameOmmitted]\Minecraft\MinecraftForge\build.gradle' line: 22

* What went wrong:
A problem occurred evaluating root project 'Forge'.
> Plugin with id 'net.minecraftforge.gradle.forgedev.mcp' not found.

The Project block looks as follows (I didn't change anything besides the classpath thing shown above, this is only here for easier lookup of the build.gradle) :

project(':mcp') {
    apply plugin: 'net.minecraftforge.gradle.forgedev.mcp'
    mcp {
        config = 'de.oceanlabs.mcp:mcp_config:1.13-2018.09.12.04.11.00@zip'
        pipeline = 'joined'
    }
}

Where the conflicting line is the apply plugin in one.

 

So I guess he doesn't recognize the 'ForeGradle-jar' I supplied him with - and after looking into it I saw it doesn't contain any class Files, but only .java ones... Which might be a Problem (I have no idea about gradle - If I get something to work with it in any way, I just happily leave it leave it like it is, and never touch it again...)?

So should I compile these src-sets contained in the 'jar'? Or is there some way to get the maven repository behave like it should? 

For reference here us tge gradle folder... Some reading made me think that in order to recognize plugins, gradle would need to see these META-INF files shown below: (?)

(For reference, I was doing what the documentation guide for IntelliJ said... And failed with the described Problem at step 6)

 

Any help would be appreciated... Thanks...

[Major Tuvok]

Btw. the maven-metadata.xml doesn't list ForgeGradle 3.0...?

[Cadiboo]

I don't think its publicly out yet

[Major Tuvok]

17 hours ago, Cadiboo said:

I don't think its publicly out yet

Oh, ok...

[Cadiboo]

Sorry, here it is https://github.com/MinecraftForge/ForgeGradle/tree/FG_3.0

and heres a post by Lex

 

[Major Tuvok]

I just tested out, that manually compiling ForgeGradle and then adding required dependencies to the build classpath, as defined in the ForgeGradle build.gradle works

[Major Tuvok]

5 minutes ago, Cadiboo said:

Sorry, here it is https://github.com/MinecraftForge/ForgeGradle/tree/FG_3.0

and heres a post by Lex

 

So this means, that what I did is ok?

(Should I include what exactly is necessary to get ForgeGradle 3 running?)

Edited September 22, 2018 by Major Tuvok
Incomplete

[Cadiboo]

22 hours ago, Major Tuvok said:

So this means, that what I did is ok?

If it works I'm guessing it's ok, no idea if its the recommended method of getting it to work though.

22 hours ago, Major Tuvok said:

Should I include what exactly is necessary to get ForgeGradle 3 running?

Yes please, that would be appreciated

[Major Tuvok]

As of the most recent changes to forge - this is no longer necessary (I jus took a look at it again, and after pulling from forge again, their changes to the build.gradle resolved this - ForgeGradle is now reachable without compiling it manually (though it took me a few min to realize that, after the changes my manually compiled ForgeGradle didn't do it's job any longer, but switching back to the normal maven dep. works now))

 

Edit:

I just noticed, that changes were applied on Saturday evening (my time) and a few hours ago - It might very well already have worked if I tried again on Saturday

Edited September 24, 2018 by Major Tuvok

[Major Tuvok]

Ah Lex changed something - I would need to recompile, but no need for that...

 

Thanks Lex