[1.12.2] Using OreDictionary and ignoring damage

[Tschipp]

I've made an item that acts as a water bucket but is damageable. I added it to the ore dictionary entry "listAllwater", added by Pam's harvestcraft.

However, when I craft something, it only works when the item is undamaged. I registred the item to oredict like this:

OreDictionary.registerOre("listAllwater", new ItemStack(ItemList.waterTalisman, 1, OreDictionary.WILDCARD_VALUE));
OreDictionary.registerOre("listAllwater", ItemList.waterTalisman);

Both methods don't seem to work when the item is damaged. What am I doing wrong?

 

(btw, I'm crafting this recipe from Pam's Harvestcraft):

{
  "result": {
    "item": "harvestcraft:saltitem"
  },

  "ingredients": [
    {
      "type": "forge:ore_dict",
      "ore": "toolPot"
    },
    {
      "type": "forge:ore_dict",
      "ore": "listAllwater"
    }
  ],
  "type": "forge:ore_shapeless"
}

 

[Tschipp]

Anybody?

[Cadiboo]

On 9/30/2018 at 2:27 AM, Tschipp said:

{  "type": "forge:ore_dict", "ore": "listAllwater" }

You might want to try adding the data wildcard value

 

..."ore": "listAllWater", "data": 32767 }

((2^(16-1))-1)

[Tschipp]

Thing is, it's not my recipe. It's from pam's harvestcraft.

[Cadiboo]

Can you just have your own recipe override theirs?

[Tschipp]

5 hours ago, Cadiboo said:

You might want to try adding the data wildcard value

 

..."ore": "listAllWater", "data": 32767 }

((2^(16-1))-1)

I just tested it by changing the recipe in pam's assets, but it still only crafts when the item is undamaged...

Is this a limitation by oredict?

[Tschipp]

3 hours ago, diesieben07 said:

Looking at the code, this should work fine. If the ItemStack registered with the OreDictionary has a metadata of OreDictionary.WILDCARD_VALUE, any metadata should be accepted.

That's what I also was thinking... well I guess I'll just stick around for the OreDictionary rewrite for 1.13

[LexManos]

That is incorrect, due to Mojang's re-write of the recipe system, the wildcard is just a shortcut to for(ItemStack subitem : item.getSubItems())
Damageable items do not work in simple recipes as the auto fill and matching system Mojang wrote doesn't support them.

 

Recipes have to explicitly state they want to use a damageable item.

[Tschipp]

I see.