blockstate contaner? im not sure help plx

[monkeybee]

after getting this error me had to go out so cant remember 100% word for word what the error is when im back home ill post the crash log im making the thread now incase it slips my mind when me do get home
 

 

im trying to make a bunch of bananas that grow on a jungle tree like how cocoa pods do after 2 days or trial ive finerly got eclips to stop giving me errors but now the testMC crashes with a something about blockstate contaner and AGE 0 1 2

 

crashlog
https://pastebin.com/2CVjRLzD

 

my code

https://github.com/monkeybee11/monkeysmod/blob/master/src/main/java/com/monkeybee11/monkeysmod/block/bananabunch.java

ive really got no clue whats wrong my blockstate.json looks the same as the cocoa (apart from north east south west but thats bc this is ment to be under the leaves not next to the log)

 

Edited October 5, 2018 by monkeybee

[Draco18s]

15 minutes ago, monkeybee said:

when im back home ill post the crash log

Yeah, do that.

 

16 minutes ago, monkeybee said:

something about blockstate contaner

Your block does not override createBlockState() and yet it tries to have properties.

[monkeybee]

55 minutes ago, Draco18s said:

Yeah, do that.

 

Your block does not override createBlockState() and yet it tries to have properties.

ive posted my crashlog and update my github (forgot to do it befor being rushed out the house >.< )

[Draco18s]

2 hours ago, Draco18s said:

Your block does not override createBlockState() and yet it tries to have properties.

 

[monkeybee]

3 minutes ago, Draco18s said:

 

sry im a durp uploaded the right file this time XD
good news no more crashing
the block isnot in game tho must of messed something up in registering it (me know its not listed in the lang files im gonna do that after ive got it working) 

[Cadiboo]

Please observe java conventions. (Packages must be lowercase, classes must be CamelCase) I.E. Entities->entity and bananabunch -> BlockBananaBunch

You should remove your SoundType parameter from your bananabunch block, you never use, pass it in as null & it will also crash a dedicated server as (I think) SoundTypes don’t exist there.

Your not registering an ItemBlock for your bananabunch block

your registry names should be in snake_case format (bananabunch->banana_bunch & rainbowwater->rainbow_water)

 

Well done for using @ObjectHolder and registry events!!

 

Edited October 6, 2018 by Cadiboo

[monkeybee]

8 hours ago, Cadiboo said:

Please observe java conventions. (Packages must be lowercase, classes must be CamelCase) I.E. Entities->entity and bananabunch -> BlockBananaBunch

You should remove your SoundType parameter from your bananabunch block, you never use, pass it in as null & it will also crash a dedicated server as (I think) SoundTypes don’t exist there.

Your not registering an ItemBlock for your bananabunch block

your registry names should be in snake_case format (bananabunch->banana_bunch & rainbowwater->rainbow_water)

 

Well done for using @ObjectHolder and registry events!!

 

ignore rainbowwater thats nolonger in my eclips for now ive scrapted it and gonna have a nother try at adding fluids at some other point ¬.¬ (no idea how to delete it off github) 

 

but if me removed soundtype from the bananabunch it gives me 

Duplicate method BlockBananaBunch(Material, String, String) in type BlockBananaBunch

 

Edited October 6, 2018 by monkeybee
forgot something

[Draco18s]

1 hour ago, monkeybee said:

ignore rainbowwater thats nolonger in my eclips for now ive scrapted it and gonna have a nother try at adding fluids at some other point ¬.¬ (no idea how to delete it off github) 

You delete the file in your local repository, push a commit, and sync.

1 hour ago, monkeybee said:

but if me removed soundtype from the bananabunch it gives me 

Duplicate method BlockBananaBunch(Material, String, String) in type BlockBananaBunch

So remove the method you don't need. If they're identical, you don't need one of them.

 

This is like having a shopping list that says:
Milk

Bread

Milk

[monkeybee]

oh really

ok there both in Cubicoder's modding tutorial so just assumed both of them was needed 

[Draco18s]

1 hour ago, monkeybee said:

oh really

ok there both in Cubicoder's modding tutorial so just assumed both of them was needed 

Functions aren't magic. They do things.

There's plenty of reasons to have more than one constructor, but they're not required.

[Cadiboo]

7 hours ago, monkeybee said:

no idea how to delete it off github

Install a git client (Eclipse has one, but from memory it’s not straightforward to use), GitHub Desktop (easy to use, the official client from GitHub, it lacks a lot of functionality though) if you must. This solves everything for you. It makes sure you have a constant backup of everything with version control.