Search the Forums BEFORE making a new post.

[1.12.2]What is wrong with my worldgen?

Posted October 7, 20186 yr

Could some body tell me why this

Quote

[11:51:38] [Server thread/WARN] [FML]: Cruelars Triforcemod loaded a new chunk [-40, -49] in dimension 0 (overworld) while populating chunk [-39, -48], causing cascading worldgen lag.
[11:51:38] [Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

happens and how to fix it.

My generation code

public class WorldGen implements IWorldGenerator {
    @Override
    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
        if (world.provider.getDimension()==0){
            generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
        }
    }

    private void generateOverworld(Random random, int chunkX,int chunkZ, World world,IChunkGenerator chunkGenerator,IChunkProvider chunkProvider){
        generateHyruleHerb(world, random, new BlockPos(chunkX * 16 - 8, 128, chunkZ * 16 - 8));
        generateOreDepositOverGround(world,random,new BlockPos(chunkX * 16 - 8, 128, chunkZ * 16 - 8));
        for (int i=1 ;i*16<=64;i++){
            generateOreDepositUnderGround( world,random,new BlockPos(chunkX * 16-8, i*16-8, chunkZ * 16-8));
        }
    }

    public boolean generateHyruleHerb(World worldIn, Random rand, BlockPos position) {
        for (IBlockState iblockstate = worldIn.getBlockState(position); (iblockstate.getBlock().isAir(iblockstate, worldIn, position) || iblockstate.getBlock().isLeaves(iblockstate, worldIn, position)) && position.getY() > 0; iblockstate = worldIn.getBlockState(position))
        {
            position = position.down();
        }
        for (int i = 0; i < 4; ++i)
        {
            BlockPos blockpos = position.add(rand.nextInt(8) - rand.nextInt(8), rand.nextInt(4) - rand.nextInt(4), rand.nextInt(8) - rand.nextInt(8));

            if (worldIn.isAirBlock(blockpos) && Blocks.TALLGRASS.canBlockStay(worldIn, blockpos, ModBlocks.hyrule_herb_block.getDefaultState()))
            {
                worldIn.setBlockState(blockpos, ModBlocks.hyrule_herb_block.getDefaultState(), 2);
            }
        }
        return true;
    }

    public boolean generateOreDepositOverGround(World worldIn, Random rand, BlockPos position) {
        for (IBlockState iblockstate = worldIn.getBlockState(position); (iblockstate.getBlock().isAir(iblockstate, worldIn, position) || iblockstate.getBlock().isLeaves(iblockstate, worldIn, position)) && position.getY() > 0; iblockstate = worldIn.getBlockState(position))
        {
            position = position.down();
        }
        if (worldIn.getBiome(position)== Biomes.EXTREME_HILLS||worldIn.getBiome(position)== Biomes.EXTREME_HILLS_EDGE||worldIn.getBiome(position)== Biomes.EXTREME_HILLS_WITH_TREES||worldIn.getBiome(position)== Biomes.MESA||worldIn.getBiome(position)== Biomes.MESA_CLEAR_ROCK){
            for (int i = 0; i < 4; ++i)
            {
                BlockPos blockpos = position.add(rand.nextInt(8) - rand.nextInt(8), rand.nextInt(4) - rand.nextInt(4), rand.nextInt(8) - rand.nextInt(8));

                if (worldIn.isAirBlock(blockpos) && (Blocks.TALLGRASS.canBlockStay(worldIn, blockpos, ModBlocks.hyrule_herb_block.getDefaultState())||Blocks.DEADBUSH.canBlockStay(worldIn, blockpos, Blocks.DEADBUSH.getDefaultState() )))
                {
                    worldIn.setBlockState(blockpos.down(), ModBlocks.ore_deposit.getDefaultState(), 2);
                    if (rand.nextFloat()>0.8){
                        worldIn.setBlockState(blockpos,ModBlocks.rare_ore_deposit.getDefaultState(),2);
                    }else{
                        worldIn.setBlockState(blockpos,ModBlocks.ore_deposit.getDefaultState(),2);
                    }
                }
            }
        }else
        for (int i = 0; i < 1; ++i)
        {
            BlockPos blockpos = position.add(rand.nextInt(8) - rand.nextInt(8), rand.nextInt(4) - rand.nextInt(4), rand.nextInt(8) - rand.nextInt(8));

            if (worldIn.isAirBlock(blockpos)&&(Blocks.TALLGRASS.canBlockStay(worldIn, blockpos, ModBlocks.hyrule_herb_block.getDefaultState())||Blocks.DEADBUSH.canBlockStay(worldIn, blockpos, Blocks.DEADBUSH.getDefaultState() )))
            {
                if (rand.nextFloat()>0.75) {
                    worldIn.setBlockState(blockpos, ModBlocks.ore_deposit.getDefaultState(), 2);
                    if (rand.nextFloat() > 0.9) {
                        worldIn.setBlockState(blockpos.up(), ModBlocks.rare_ore_deposit.getDefaultState(), 2);
                    } else {
                        worldIn.setBlockState(blockpos.up(), ModBlocks.ore_deposit.getDefaultState(), 2);
                    }
                }
            }
        }
        return true;
    }

    public boolean generateOreDepositUnderGround(World worldIn, Random rand, BlockPos position) {
        for (IBlockState iblockstate = worldIn.getBlockState(position); (iblockstate.getBlock().isAir(iblockstate, worldIn, position)  && position.getY() > 0); iblockstate = worldIn.getBlockState(position))
        {
            position = position.down();
        }
        double deepmultiplicator=1;
        if (position.getY()<=48) {
            deepmultiplicator = 1.5;
        }
        if (position.getY()<=32) {
            deepmultiplicator = 2;
        }
        if (position.getY()<=16) {
            deepmultiplicator = 3;
        }
        if (worldIn.getBiome(position)== Biomes.EXTREME_HILLS||worldIn.getBiome(position)== Biomes.EXTREME_HILLS_EDGE||worldIn.getBiome(position)== Biomes.EXTREME_HILLS_WITH_TREES||worldIn.getBiome(position)== Biomes.MESA||worldIn.getBiome(position)== Biomes.MESA_CLEAR_ROCK){
            for (double i = 0; i < 8*deepmultiplicator; ++i)
            {
                BlockPos blockpos = position.add(rand.nextInt(8) - rand.nextInt(8), rand.nextInt(4) - rand.nextInt(4), rand.nextInt(8) - rand.nextInt(8));

                if (worldIn.getBlockState(blockpos).getBlock()==Block.getBlockFromName("minecraft:stone"))
                {
                    if (rand.nextFloat()>0.8){
                        worldIn.setBlockState(blockpos,ModBlocks.rare_ore_deposit.getDefaultState(),2);
                    }else{
                        worldIn.setBlockState(blockpos,ModBlocks.ore_deposit.getDefaultState(),2);
                    }
                }
            }
        }else
            for (double i = 0; i < 2*deepmultiplicator; ++i)
            {
                BlockPos blockpos = position.add(rand.nextInt(8) - rand.nextInt(8), rand.nextInt(4) - rand.nextInt(4), rand.nextInt(8) - rand.nextInt(8));

                if (worldIn.getBlockState(blockpos).getBlock()==Block.getBlockFromName("minecraft:stone"))
                {
                    if (rand.nextFloat()>0.9){
                        worldIn.setBlockState(blockpos,ModBlocks.rare_ore_deposit.getDefaultState(),2);
                    }else{
                        worldIn.setBlockState(blockpos,ModBlocks.ore_deposit.getDefaultState(),2);
                    }
                }
            }
        return true;
    }

They are all causing this and make creating a new World lasting an extreme long time. What I found out so far is that the Underground Oredeposit generation causes less Worldgen lags than the others.

Using them all brings me over 500 cacading world gen lags during world creation, not counted what he loads after spawn.

Any help would be appreciated.

My Projects:

Cruelars Triforcemod (1.12 release; 1.14 alpha soon coming)

Important:

As my mod is on at least 10 different third party sites without my permission, I want to warn you about that with a link to StopModReposts

Quote

October 7, 20186 yr

short version - act as if the coordinates (where you are deciding whether to generate things and where you will generate things) are offset by +8, +8. i.e. do offset them by +8,+8 both when checking the terrain and when generating your stuff.

the thing is - if you overflow to the east or south, you're okay. no problem. but if you overflow towards north or west, more chunks need to be created (which will among others call your terrain generators again, likely causing more chunks to be generated...).

Quote

October 9, 20186 yr

Heres an in-depth explanation from Mezz

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/66764-1122what-is-wrong-with-my-worldgen/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 15 hours ago15 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 23 hours ago23 hr
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Yesterday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted Tuesday at 08:42 PM1 day

Sign In

[1.12.2]What is wrong with my worldgen?

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)