I thought I did this just how I did last time, but for some reason when I run this code, the register items and renders events in the item class come before the preInit event from my main class. What did I do wrong?

 

showing the order:

[13:37:42] [main/INFO] [FML]: Applying holder lookups
[13:37:42] [main/INFO] [FML]: Holder lookups applied
[13:37:42] [main/INFO]: [STDOUT]: SIGN VARIETY registerItems() <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[13:37:42] [main/INFO] [FML]: Applying holder lookups
[13:37:42] [main/INFO] [FML]: Holder lookups applied
[13:37:42] [main/INFO] [FML]: Applying holder lookups
[13:37:42] [main/INFO] [FML]: Holder lookups applied
[13:37:42] [main/INFO]: [STDOUT]: SIGN VARIETY registerRenders() <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[13:37:42] [main/INFO] [FML]: Applying holder lookups
[13:37:42] [main/INFO] [FML]: Holder lookups applied
[13:37:42] [main/INFO] [FML]: Injecting itemstacks
[13:37:42] [main/INFO] [FML]: Itemstack injection complete
[13:37:42] [Forge Version Check/INFO] [ForgeVersionCheck]: [forge] Found status: UP_TO_DATE Target: null
[13:37:42] [Thread-3/INFO] [FML]: Using sync timing. 200 frames of Display.update took 53019200 nanos
[13:37:43] [Sound Library Loader/INFO]: Starting up SoundSystem...
[13:37:43] [Thread-5/INFO]: Initializing LWJGL OpenAL
[13:37:43] [Thread-5/INFO]: (The LWJGL binding of OpenAL.  For more information, see http://www.lwjgl.org)
[13:37:43] [Thread-5/INFO]: OpenAL initialized.
[13:37:43] [Sound Library Loader/INFO]: Sound engine started
[13:37:45] [main/INFO] [FML]: Max texture size: 16384
[13:37:45] [main/INFO]: Created: 512x512 textures-atlas
[13:37:46] [main/INFO]: [STDOUT]: signvariety:init
[13:37:46] [main/INFO]: [STDOUT]: signvariety:preInit
[13:37:46] [main/INFO]: [STDOUT]: SIGN VARIETY init() <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
[13:37:46] [main/INFO] [FML]: Injecting itemstacks

 

main java file:

 

package signvariety;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;

@Mod(modid = signvariety.MODID, version = signvariety.VERSION)
public class signvariety
{
    public static final String MODID = "signvariety";
    public static final String VERSION = "1.0.0";

    @EventHandler
    public void preInit(FMLInitializationEvent event) {
        Items.init();
    }
}

 

items java file

 

package signvariety;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod.EventBusSubscriber(modid="signvariety")
public class Items {


    private static Item mySign;

    public static void init () {
        System.out.println("SIGN VARIETY init() <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<");

        mySign = new SignItem("mySign");
    }

    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
        System.out.println("SIGN VARIETY registerItems() <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<");

        //event.getRegistry().registerAll(mySign);

    }


    @SubscribeEvent
    public static void registerRenders(ModelRegistryEvent event) {

        System.out.println("SIGN VARIETY registerRenders() <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<");

        //ModelLoader.setCustomModelResourceLocation(mySign, 0, new ModelResourceLocation(mySign.getRegistryName(), "inventory"));
    }
}

13 minutes ago, skeddles said:

public void preInit(FMLInitializationEvent event)

Even though this is named preInit it actually fires during init due to the parameter you've specified.

 

13 minutes ago, skeddles said:

public static void init () {  mySign = new SignItem("mySign"); }

Don't do this. Instantinate your items in the appropriate registry event and there only.

 

 

Edited October 9, 20186 yr by V0idWa1k3r

3 minutes ago, V0idWa1k3r said:

Even though this is named preInit it actually fires during init due to the parameter you've specified.

 

Don't do this. Instantinate your items in the appropriate registry event and there only. 

 

 

Is that registerItems? I moved it there and it seems to work.  I was following this guide which tells you to do it the other way.

6 minutes ago, skeddles said:

Is that registerItems?

Yeah. In general anything that is a part of the registry should be instantinated in the appropriate registry event. If you need a reference to that object later you can use ObjectHolders.

Okay, thanks

1 hour ago, V0idWa1k3r said:

If you need a reference to that object later you can use ObjectHolders.

Or you could just instantiate the object directly. IE

RegistryEvent()

Object o = new Object()

Event.register(o)

 

Obviously you could add all of the objects into a set via their constructor for the simplicity of registering. Plus ObjectHolder is broken in Java 9 and will probably not be in the 1.13 release of forge.

On 10/10/2018 at 6:31 AM, Animefan8888 said:

Or you could just instantiate the object directly. IE

RegistryEvent()

Object o = new Object()

Event.register(o)

 

Obviously you could add all of the objects into a set via their constructor for the simplicity of registering. Plus ObjectHolder is broken in Java 9 and will probably not be in the 1.13 release of forge.

Why won’t they be in 1.13? I think that they’re a great addition, and are vital due to their potential for adding & removing mods ingame

47 minutes ago, Cadiboo said:

Why won’t they be in 1.13? I think that they’re a great addition, and are vital due to their potential for adding & removing mods ingame

The modules added in java 9, ObjectHolder uses reflection to populate the variables.

Just now, Animefan8888 said:

The modules added in java 9, ObjectHolder uses reflection to populate the variables.

I don’t understand, I’ll make a new topic