How to iterate through my actual chunk?

[HenryFoster]

I would like to find all sign-blocks and their position in the chunk at my player position. My problem is that I dont know how to iterate through the blocks in the chunk.

 

EntityPlayer player = Minecraft.getMinecraft().player;
World world = player.getEntityWorld();
Chunk chunk  = world.getChunkFromBlockCoords(player.getPosition());

Map<BlockPos, TileEntity> myMap = chunk.getTileEntityMap();
for(double x = 0; x <= 16; x++) {
		 System.out.println(chunk.getBlockState(new BlockPos(x+player.posX, player.posY , player.posZ)));  
}  

What I dont understand is how do I get the blocks of exactly the chunk where myPlayerPosition is. I can use loops with offsets but I dont understand how the coordinations work. because for "chunk.getBlockState() I need to set a blockposition but how do I get the position of the first/last block in that actual chunk?

 

I'm looking for something like :

for(double x = 0; x <= 16; x++) {
		 System.out.println(chunk.getBlockState(new BlockPos(x+offset,blablabla)));  
}  

I know its only one dimensional but I want to get it right first before I go on for the other axis. I need to understand how I can turn this relative chunk coordinations into real worldcoordination.

 

I already found this but the topic is more about blockproperties then the iterating.

 

Edited October 14, 2018 by HenryFoster

[HenryFoster]

Edit:

 

I got it:

 

@SubscribeEvent
	public void onKeyInput(InputEvent.KeyInputEvent event) 
	{
	  if(KeyBindings.myKey.isPressed())
	  {
		   System.out.println("KEY K");
	   
		   EntityPlayer player = Minecraft.getMinecraft().player;
		   World world = player.getEntityWorld();
		   Chunk chunk  = world.getChunkFromBlockCoords(player.getPosition());
	
		   int a = chunk.x*16;
		   int b = chunk.z*16;
		   System.out.println("Chunk starts at: "+ a*16 + " " + b*16);
		   for(double x = 0; x <= 15; x++) 
		   {  
			   for(double y = player.posY-2; y <= player.posY+10; y++)
			   {
				   for(double z = 0; z <= 15; z++)
				   {
					   //System.out.println(chunk.getBlockState(new BlockPos(a+x,player.posY , b+z)));  
					   BlockPos actualPosition = new BlockPos(a+x,y, b+z);
					   IBlockState state = chunk.getBlockState(actualPosition);
					   if(state.getBlock() instanceof BlockSign) 
					   {
						   for(ITextComponent i: ((TileEntitySign)world.getTileEntity(actualPosition)).signText) 
						   {
							   System.out.println(i.getUnformattedComponentText());
						   }
					   }
				   }
			   }
			   
				   
		   }
		   
	  	}
	}

I use the Chunk coordiantes a and b (yes I know bad names I will change them) and multiply them with 16 to get the start coordinates of the chunk where my player is. Later I define the position of the block "I'm looking at" with the starting position of the chunk + x/z to get the global-coordinates of that block.

[Cadiboo]

20 hours ago, HenryFoster said:

multiply them

Don’t multiply, use bit shifting. The results are different (integer multiplication rounds down)

[Draco18s]

Multiplying works out the same. Its dividing that causes problems.

(You should still bitshift)

[Cadiboo]

Theres also a performance gain with bitshifting

[HenryFoster]

10 hours ago, Draco18s said:

Multiplying works out the same. Its dividing that causes problems.

(You should still bitshift)

I will look into this thanks for the help.