Jump to content

[1.12.2] Help with modifying block drops


Trhod177

Recommended Posts

I've been trying to change the onHarvestBlock event to change what sand and red sand drops when you mine it, normal sand works fine but i cant get red sand to drop the proper item.

 

Here is my code


@Mod.EventBusSubscriber
public class PocketSandEventHandler {
	
    
     
	@SubscribeEvent
	public void onHarvestBlock(BlockEvent.HarvestDropsEvent event)
	{
		final EntityPlayer PLAYER = event.getHarvester();
		if(null == PLAYER || null == PLAYER.getHeldItemMainhand()) return;

		if(ConfigHandler.overridesanddrops == true) {
		
		if(event.getState().getBlock() == Blocks.SAND)
		{
			event.getDrops().add(new ItemStack(ItemInit.sandpile, 4));
			event.getDrops().remove(0);
			
            
			
		}

		}
		
		if(ConfigHandler.overrideredsanddrops == true) {
			
			   if(event.getState().getBlock() == Blocks.SAND.getStateFromMeta(1)) {
					
					event.getDrops().add(new ItemStack(ItemInit.redsandpile, 4));
					event.getDrops().remove(1);
				}
		}
		
		
	}
	}
	

 

Edited by Trhod177
Link to comment
Share on other sites

if(event.getState().getBlock() == Blocks.SAND.getStateFromMeta(1)) {

Block != IBlockState. ever

30 minutes ago, Trhod177 said:

event.getDrops().remove(1);

How do you know there are 2 items in the list. how do you even know that the list isnt empty?

 

31 minutes ago, Trhod177 said:

@Mod.EventBusSubscriber

Static subscriber annotation but 

 

32 minutes ago, Trhod177 said:

@SubscribeEvent public void onHarvestBlock(BlockEvent.HarvestDropsEvent event)

non-static subscriber methods?? why??

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

2 hours ago, Trhod177 said:

event.getState().getBlock()

Returns an instance of the Block class.

2 hours ago, Trhod177 said:

Blocks.SAND.getStateFromMeta(1)

Returns an instance of the IBlockState class.

 

A block is never an IBlockState and an IBlockState is never a Block.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

8 minutes ago, Trhod177 said:

Ok then how do distinguish between sand and redsand

You must compare the states. Or the properties of the IBlockState.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Something like if( state == Blocks.SAND.getDefaultState().withProperty( whateverPropertySandHasThatCausesItToBeRed, whateverValueMakesSandBeRed)) //I’m a red sand block!

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.