Efficiency Regarding Checking Two Objects

[Lumby]

Hi, after a bit of time I've realized that minecraft mods involve a lot of checking whether two objects are equal or not, be it items, blocks, biomes, etc. Since my mod performs so many of these checks, I'm starting to worry that if these comparisons are not coded efficiently, it would start slowing down minecraft a lot. Most of the time, I just use the good ol' Object#equals() method to check whether an object is the same (same as in #getBlock() is Blocks.DIRT or something like that). Is this the most efficient method? Or is there a better way to do things like this, specifically for checking Items, Blocks, and Biomes? Thanks in advance for the help. 

[Animefan8888]

1 minute ago, Lumby said:

Hi, after a bit of time I've realized that minecraft mods involve a lot of checking whether two objects are equal or not, be it items, blocks, biomes, etc. Since my mod performs so many of these checks, I'm starting to worry that if these comparisons are not coded efficiently, it would start slowing down minecraft a lot. Most of the time, I just use the good ol' Object#equals() method to check whether an object is the same (same as in #getBlock() is Blocks.DIRT or something like that). Is this the most efficient method? Or is there a better way to do things like this, specifically for checking Items, Blocks, and Biomes? Thanks in advance for the help. 

Quite a lot of objects in Minecraft are are singletons, objects where there is only one instance. IE there is only one IRON_INGOT. So instead of using Object#equals just use "==". And you shouldn't worry about comparison checks you can do millions potentially billions of them per second.

[Lumby]

Thanks for the help! Is there any case where the objects are not singletons that I should look out for then? I'm guessing players obviously aren't, but is there anything else?

Edited October 20, 2018 by Lumby

[V0idWa1k3r]

14 minutes ago, Lumby said:

Is there any case where the objects are not singletons that I should look out for then?

It is easier to list objects that ARE singletons. As a rule of thumb anything that is a IForgeRegistryEntry is a singleton.