[1.12.2] Tile entity surroundings

[Merthew]

How would I get all the entites within a box around my custom block with a ticking tileentity? I am currently trying this:

public class TileEntityBloodCollector extends TileEntity implements ITickable{
	
	private final EobItemHandler itemHandler;
	
	int blood;
	int cap = 10000;
	
	public TileEntityBloodCollector() {
		super();
		itemHandler = new EobItemHandler(1);
	}

	@Override
	public void update() {
		BlockPos pos = this.getPos();
		boolean isChanged = false;
		int ticks = 0;
		
		ItemStack stack0 = itemHandler.getStackInSlot(0);
		
		if(!this.world.isRemote) {
			if(stack0.hasTagCompound()) {
				ItemStack stack = itemHandler.getStackInSlot(2);
				NBTTagCompound nbt;
			    if (stack.hasTagCompound()) {
			        nbt = stack.getTagCompound();
			    }
			    else {
			        nbt = new NBTTagCompound();
			    }
			    if(nbt.hasKey("blood")) {
			    	int currBlood = nbt.getInteger("blood");
				    int possBlood = nbt.getInteger("cap") - currBlood;
				    if(possBlood <= blood) {
				    	nbt.setInteger("blood", possBlood + currBlood);
				    	blood -= possBlood;
				    }
				    else {
				    	nbt.setInteger("blood", blood + currBlood);
				    	blood = 0;
				    }
				    stack.setTagCompound(nbt);
			    }
			    isChanged = true;
			}
			
			List<Entity> entitys = this.getWorld().getEntitiesWithinAABB(EntityLiving.class, new AxisAlignedBB(pos.getX()-5, pos.getY()-2, pos.getZ()-5, pos.getX()+5, pos.getY()+2, pos.getZ()+5));
			
			for(Entity e : entitys) {
				if(!(e instanceof AbstractSkeleton) && !(e instanceof EntitySlime) && !(e instanceof EntityMagmaCube) && (e instanceof EntityCreature) && ticks >= 21) {
					blood += 10;
					e.attackEntityFrom(DamageSource.MAGIC, 1);
					isChanged = true;
					ticks = 0;
				}
			}
			ticks ++;
		}
		
		
		
		if(isChanged) {
			this.updateTile();
		}
		
	}
	
	@Override
	public void readFromNBT(NBTTagCompound nbtTagCompound)
	{
		super.readFromNBT(nbtTagCompound);
		itemHandler.deserializeNBT(nbtTagCompound.getCompoundTag("ItemHandler"));
		this.cap = nbtTagCompound.getInteger("cap");
		this.blood = nbtTagCompound.getInteger("blood");

	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound nbtTagCompound)
	{
		super.writeToNBT(nbtTagCompound);
		nbtTagCompound.setTag("ItemHandler", itemHandler.serializeNBT());
		nbtTagCompound.setDouble("cap", cap);
		nbtTagCompound.setDouble("blood", blood);
		
		return nbtTagCompound;
	}
	
	void updateTile(){
		world.notifyBlockUpdate(pos, world.getBlockState(pos), world.getBlockState(pos), 3);
		world.scheduleBlockUpdate(pos,this.getBlockType(),0,0);
		markDirty();
	}
	
	public EobItemHandler getItemHandler()
	{
		return itemHandler;
	}
	
	@SuppressWarnings("unchecked")
	@Override
	public <T> T getCapability(Capability<T> capability, @Nullable EnumFacing facing)
	{
		if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
		{
			return (T) itemHandler;
		}

		return super.getCapability(capability, facing);
	}

	@Override
	public boolean hasCapability(Capability<?> capability, @Nullable EnumFacing facing)
	{
		return capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY || super.hasCapability(capability, facing);
	}

	@Override
	public SPacketUpdateTileEntity getUpdatePacket()
	{
		return new SPacketUpdateTileEntity(pos, 0, getUpdateTag());
	}

	@Override
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt)
	{
		readFromNBT(pkt.getNbtCompound());
	}

	@Override
	public NBTTagCompound getUpdateTag()
	{
		return this.writeToNBT(new NBTTagCompound());
	}

 

Code: https://github.com/Merthew/Empire-Of-Blood/

Currently working on: BlockBloodCollector

[Draco18s]

And your problem is..?

 

What you're already doing is correct.

[V0idWa1k3r]

10 minutes ago, Merthew said:

ticks >= 21

This will never be true because ticks is a local variable assigned to 0:

10 minutes ago, Merthew said:

int ticks = 0;

 

World#getEntitiesWithinAABB is the perfect way to get all entities of a given type in a box around some point. The only thing I could advice is to use EntityCreature as the base class instead of EntityLiving since you are already checking if the entity is an EntityCreature, put the other conditions into the predicate of World#getEntitiesWithinAABB and invoke the method when this condition is satisfied:

10 minutes ago, Merthew said:

ticks >= 21

Otherwise you are just doing extra work that is not necessary.

[Merthew]

Thanks