[1.12] Giving player items / checking for item in world

[TheGoldenProof]

The way I want this to work:

You throw the dragon bone ax on top of a Gigas Cedar Log and right-click the log with an empty hand and it gives you a Gigas Cedar Branch if you are above y = 200.

 

Log method

@Override
	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		
		AxisAlignedBB above = new AxisAlignedBB(pos.up());
		boolean hasAxe = false;
		List<EntityItem> entities = worldIn.getEntitiesWithinAABB(EntityItem.class, above);
		
		for(EntityItem ei : entities) {
			if (ei.getItem().getItem().equals(ModItems.DRAGON_BONE_AXE)) {
				hasAxe = true;
			}
		}
		
		if (pos.getY() > 200 && playerIn.inventory.getCurrentItem() == ItemStack.EMPTY && hasAxe) {
			playerIn.addItemStackToInventory(new ItemStack(ModItems.GIGAS_CEDAR_BRANCH, 1));
		}
		return false;
	}

 

Dragon Bone Ax code (unnecessary variables and stuff excluded)

public class ModItems {
	
	public static final List<Item> ITEMS = new ArrayList<Item>();
	
	//Tooltips
	
	//Object Priorities
	public static final int P_DRAGON_BONE_AXE = 10;
	
	//Materials
	public static final ToolMaterial M_DRAGON_BONE = EnumHelper.addToolMaterial("m_dragon_bone", P_DRAGON_BONE_AXE, P_DRAGON_BONE_AXE*60, P_DRAGON_BONE_AXE/4.0f, P_DRAGON_BONE_AXE/3.0f, 10);
	
	//Tools
	public static final ItemAxe DRAGON_BONE_AXE = new ToolAxe("dragon_bone_axe", M_DRAGON_BONE, P_DRAGON_BONE_AXE, SAOM.saoModTab);
	
	//Items
	
}

 

but it doesn't work

[V0idWa1k3r]

17 minutes ago, TheGoldenProof said:

playerIn.inventory.getCurrentItem() == ItemStack.EMPTY

Don't do this, use ItemStack#isEmpty instead. An item stack may be empty but not equal to ItemStack.EMPTY.

 

17 minutes ago, TheGoldenProof said:

public static final ItemAxe DRAGON_BONE_AXE = new ToolAxe("dragon_bone_axe", M_DRAGON_BONE, P_DRAGON_BONE_AXE, SAOM.saoModTab);

Don't ever use static initializers. Instantinate your stuff directly in the appropriate registry event.

 

Apart from that use the debugger to see which items are actually selected within the AABB specified and whether ut contains your axe item. You might need to extend it a bit. Also consider using java 8's streams instead of loops in cases like this one.

[TheGoldenProof]

5 minutes ago, V0idWa1k3r said:

Don't ever use static initializers. Instantinate your stuff directly in the appropriate registry event.

I'm new at modding (you can tell) and so I don't know what registry events are or how to instantiate my objects in them

 

5 minutes ago, V0idWa1k3r said:

Apart from that use the debugger to see which items are actually selected within the AABB specified and whether ut contains your axe item. You might need to extend it a bit. Also consider using java 8's streams instead of loops in cases like this one.

Also somewhat new to java and eclipse. I've never used Eclipse's debugger and I have heard of streams but I don't really know what they are.

 

I'll look into streams and try the debugger but if you could explain how to do the registry thing a little more that would be great

[V0idWa1k3r]

4 minutes ago, TheGoldenProof said:

so I don't know what registry events are

Yes you do. Registry events are events where you register your things. RegistryEvent.Register<? extends IForgeRegistryEntry>. If you have any items/blocks present in your mod you are using registry events.

 

5 minutes ago, TheGoldenProof said:

how to instantiate my objects in them

Yes you do. You are currently instantinating your objects in static initializers. Just do the same in the registry event instead.

 

6 minutes ago, TheGoldenProof said:

I've never used Eclipse's debugger

Well maybe it is time to start. You can't really solve issues without a debugger and you can't write pretty much anything above a hello world application if you can't solve issues.

 

6 minutes ago, TheGoldenProof said:

I have heard of streams but I don't really know what they are.

They are a java feature. If you don't know java then you need to learn it before making a mod otherwise you are constructing a rocket without any instructions.

[TheGoldenProof]

1 minute ago, V0idWa1k3r said:

If you don't know java then you need to learn it before making a mod otherwise you are constructing a rocket without any instructions.

k i guess ill just stop and think about how many hours of my life i just wasted

[Cadiboo]

If you know any other Object Oriented Programming already, it won’t be impossible to go straight into modding, and all you really need is a basic java tutorial. It shouldn’t take very long at all to learn java, and that time is definitely not “wasted”

[Draco18s]

Someone's been watching Sword Art Online season 3. ?

[TheGoldenProof]

1 minute ago, Cadiboo said:

If you know any other Object Oriented Programming already, it won’t be impossible to go straight into modding, and all you really need is a basic java tutorial. It shouldn’t take very long at all to learn java, and that time is definitely not “wasted”

Thanks, I didn't really mean what I said, I was just frustrated. I have a decent understanding of java stuff but I definitely don't know everything, because there is SO much to learn.

 

2 minutes ago, Draco18s said:

Someone's been watching Sword Art Online season 3. ?

In fact I am, however I was impatient and started reading the alicization books (9+) and now I'm on 12

[Daeruin]

You can also use println statements to see what is going on during runtime. Just print out the list of entities to the console to check whether your axe is in the list. Perhaps not as fancy as using the debugger, but it often gets the job done. You should still take the time to learn how to use the debugger. There are times when it's super helpful, particularly when you need to see the details of what vanilla code is doing.

 

5 minutes ago, TheGoldenProof said:

Thanks, I didn't really mean what I said, I was just frustrated. I have a decent understanding of java stuff but I definitely don't know everything, because there is SO much to learn.

You can make mods perfectly fine without knowing what Java 8 streams are or how to use them. You do, however, need to know Java basics well.

 

29 minutes ago, V0idWa1k3r said:

Don't ever use static initializers. Instantinate your stuff directly in the appropriate registry event.

I've heard this a few times, but never with any reason given. What's so horrific about using static initializers?

[Draco18s]

1 minute ago, Daeruin said:

I've heard this a few times, but never with any reason given. What's so horrific about using static initializers?

Because you can't control when it executes and Forge may not have done all the things it needs to for the Registries, so your item is missing a key bit of information and won't register correctly.

[TheGoldenProof]

It was because I wasn't using ItemStack#isEmpty() so It's working now.

[Cadiboo]

1 minute ago, Daeruin said:

I've heard this a few times, but never with any reason given. What's so horrific about using static initializers?

What draco18s said as well as

You can’t control the order of when they are instantiated. This poses a problem for items with creative tabs, and creative tabs with item icons, either the item will have a null creative tab, or the creative tab will have a null item, and you can’t control which one it is.

 

Also, you should use @ObjectHolder so people can override your objects

[V0idWa1k3r]

13 minutes ago, Daeruin said:

What's so horrific about using static initializers?

In addition to what everyone else said I've seen people say that people using static initializers is the only thing that prevents registries from being reloadable during runtime.

[Cadiboo]

On 10/30/2018 at 2:32 PM, V0idWa1k3r said:

registries being reloadable during runtime

^ This would allow mods to be added and removed without restarting the game