Block texture not showing up

[Ghost20000]

Hello!

I am following this tutorial and for some reason the block's texture isn't showing up (not placed or in inventory).

Here is a small temporary git repo of my code.

Can anyone help?

[TheGoldenProof]

I'm kindof new to this but I think every block is also an item and so you have to have an item json in the right places

[Ghost20000]

9 minutes ago, TheGoldenProof said:

I'm kindof new to this but I think every block is also an item and so you have to have an item json in the right places

I don't think so, I've looked at other mods and it doesn't look like I need more than the 2 jsons I have...

[nov4e]

blocks need 3 json files. 

assets/modid/models/block  > example_block.json

assets/modid/models/item  > example_block.json

assets/modid/blockstates  > example_block.json

 

(1.12.2)

Edited November 2, 2018 by nov4e

[Draco18s]

ItemBase (and BlockBase) are an antipattern.

https://github.com/tamirco2003/temporary-modding/blob/master/java/my/ghost20000/first/item/ItemBase.java

 

Do this like the block tutorial does:

this.setUnlocalizedName(this.getRegistryName())

Ditto here.

 

 

[Ghost20000]

6 minutes ago, Draco18s said:

ItemBase (and BlockBase) are an antipattern.

https://github.com/tamirco2003/temporary-modding/blob/master/java/my/ghost20000/first/item/ItemBase.java

 

Do this like the block tutorial does:

this.setUnlocalizedName(this.getRegistryName())

Ditto here.

 

 

Wait, I'm confused. Why do I need to set the unlocalized name to the registry name?

[Cadiboo]

4 hours ago, Ghost20000 said:

Wait, I'm confused. Why do I need to set the unlocalized name to the registry name?

What else would you set it to? the unlocalised name is used for translation. It makes pretty much no sense not to use the registry name. You might want to take a look at https://github.com/Cadiboo/Example-Mod, It's a base workspace that you can just download and start modding in. Here's an excerpt from the README of the repository.

 

Modding with Minecraft Forge is pretty simple, but it has quite a few conventions & pre-requisites that are unique to it and are actually pretty important and vital to having your mod work properly. I’ve been Modding for a little while, and have been programming & coding for a few years now so I’ve put together an Example Mod to help new modders start Modding (in the correct way, using the right conventions etc) as fast as possible, with as little hassle as possible and with as few problems as possible.

[Ghost20000]

5 hours ago, Cadiboo said:

What else would you set it to? the unlocalised name is used for translation. It makes pretty much no sense not to use the registry name. You might want to take a look at https://github.com/Cadiboo/Example-Mod, It's a base workspace that you can just download and start modding in. Here's an excerpt from the README of the repository.

 

Modding with Minecraft Forge is pretty simple, but it has quite a few conventions & pre-requisites that are unique to it and are actually pretty important and vital to having your mod work properly. I’ve been Modding for a little while, and have been programming & coding for a few years now so I’ve put together an Example Mod to help new modders start Modding (in the correct way, using the right conventions etc) as fast as possible, with as little hassle as possible and with as few problems as possible.

Ok, I'll start to follow the tutorial less and look at the example mod more. Thanks!

[KoolKd]

Thank you Thank you Thank you!!!!!! I've spent days trying to fix my block issue, and what luck, I found this post and realized I forgot the blockstates file! Thank you so much again!