[1.12] LivingDeathEvent not firing

[TheGoldenProof]

I'm trying to do something whenever I kill the Wither boss using LivingDeathEvents and as far as I can tell, the wither boss is an EntityLivingBase, but the event never fires.

@SubscribeEvent
public static void onLivingDeath(LivingDeathEvent event) {
	if (event.getEntity() instanceof EntityWither || event.getEntityLiving() instanceof EntityWither) {
		SAOM.info("IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII"); //Testing if its firing when I kill it, prints to the console
	}
}

Also, I'm not sure the difference between event.getEntity() and event.getEntityLiving(). Is one the thing that killed it and one the thing that was killed, or are they both the same thing?

[Laike_Endaril]

If you're sure the event itself is not firing, maybe your class isn't registered on the event bus?  My preferred method is to put this line in the constructor of my class:

MinecraftForge.EVENT_BUS.register(YourClassNameHere.class);

But there is also a tag that does the same thing.  I just can't remember what it is right now.

 

To make absolutely sure you know whether the event is even firing or not (it should fire any time something dies, not just the wither, as you seem to understand already), maybe add a println before your if statement and see if it outputs to console when you kill eg. a pig (if you haven't already tested this)

[Cadiboo]

They’ve got “public static void” so I assume they’re correctly using the @Mod.EventBusSubscriber annotation. Check your imports (its highly unlikely that there’s another LivingDeathEvent, but it’s possible)

[Laike_Endaril]

21 hours ago, TheGoldenProof said:

Also, I'm not sure the difference between event.getEntity() and event.getEntityLiving(). Is one the thing that killed it and one the thing that was killed, or are they both the same thing?

I just started making a combat tagging mod, so I'm currently dealing with event.getEntity() and getEntityLiving().  I looked at the source code and, at least without other mods being involved somehow, they both return the exact same value (one returns a field named "entity" and the other a field named "entityLiving", and the "entityLiving" field is only set once, in a constructor, and is set to "entity", so they're redundant afaik).

 

Edit 1 ================================================================

I just realized the "entityLiving" field I mentioned is NOT directly being set to the same value as the "entity" field. It is being set by a CONSTRUCTOR ARGUMENT named "entity".  That being said, in my case, at least, they still both return the same thing.

Edited November 4, 2018 by Laike_Endaril

[Animefan8888]

24 minutes ago, Laike_Endaril said:

I just realized the "entityLiving" field I mentioned is NOT directly being set to the same value as the "entity" field. It is being set by a CONSTRUCTOR ARGUMENT named "entity".  That being said, in my case, at least, they still both return the same thing.

The thing is that it extends from the basic EntityEvent so it must have those methods, but since it only fires when a Living entity dies it also provides an EntityLiving(Base) this also makes it so you do not have to cast it yourself.

[TheGoldenProof]

Thanks for the help I got it fixed but I forgot to post it. I forgot the @Mod.EventBusSubscriber tag on the class

[Laike_Endaril]

40 minutes ago, TheGoldenProof said:

Thanks for the help I got it fixed but I forgot to post it. I forgot the @Mod.EventBusSubscriber tag on the class

Great!  Thought that might be the case