Questions About My Mod.

[nov4e]

 

Hello. I've got some questions about the mod I'm developing.

The first thing is why this string appears in my log?

Potentially Dangerous alternative prefix `minecraft` for name `clock`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.

Basically I maked a json recipe with output minecraft:clock, it works but i want to remove this string from the log because with a lot of crafting can be result annoying.

This is the json recipe file:

NEX is The Mod ID(Yeah, I'm going to change it)

Spoiler

{
    "type": "forge:ore_shaped",
    "mirror": true,
    
    "pattern":
    [
        " I ",
        "IOI",
        " I "
    ],
    
    "key":
    {
        "O":
        {
           "item": "minecraft:redstone"
        },
        
        "I":
        {
           "item": "nex:gold_plate"
        }
       
    },
    
    "result":
    {
        "item": "minecraft:clock",
        "count": 1
    }
}

 

I've got another question about my mod. 

public static final ToolMaterial WOOD_KNIFE = EnumHelper.addToolMaterial("knife_wood", 1, 29, 3F, -3F, 6);

public static final ItemSword woodenKnife = new BasicKnife("wooden_knife", WOOD_KNIFE, CreativeTabs.COMBAT);

Is this the best way to set the damage of a sword?

 

Thanks for your reply. - Nov4e

[Cadiboo]

3 hours ago, nov4e said:

The first thing is why this string appears in my log?

Can you post the entire log? It looks like your registering an override for Minecraft clock. If you could post your code as a GitHub repo that would be nice.

3 hours ago, nov4e said:

Is this the best way to set the damage of a sword?

Overriding getAttackDamage (or similarly named) will give you more control over the damage, there’s nothing wrong with your way though.

3 hours ago, nov4e said:

public static final ItemSword woodenKnife = new BasicKnife("wooden_knife", WOOD_KNIFE, CreativeTabs.COMBAT);

Don’t use static initialisers! Instantiate your items in the registry event. If you need static references to your items, use @ObjectHolder

[nov4e]

11 hours ago, Cadiboo said:

Can you post the entire log?

Spoiler

[10:29:49] [main/INFO] [GradleStart]: Extra: []
[10:29:49] [main/INFO] [GradleStart]: Running with arguments: [--userProperties, {}, --assetsDir, C:/Users/Utente/.gradle/caches/minecraft/assets, --assetIndex, 1.12, --accessToken{REDACTED}, --version, 1.12.2, --tweakClass, net.minecraftforge.fml.common.launcher.FMLTweaker, --tweakClass, net.minecraftforge.gradle.tweakers.CoremodTweaker]
[10:29:49] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[10:29:49] [main/INFO] [LaunchWrapper]: Using primary tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[10:29:49] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.gradle.tweakers.CoremodTweaker
[10:29:49] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLTweaker
[10:29:49] [main/INFO] [FML]: Forge Mod Loader version 14.23.5.2772 for Minecraft 1.12.2 loading
[10:29:49] [main/INFO] [FML]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_181, running on Windows 10:amd64:10.0, installed at C:\Program Files\Java\jre1.8.0_181
[10:29:49] [main/ERROR] [FML]: Apache Maven library folder was not in the format expected. Using default libraries directory.
[10:29:50] [main/ERROR] [FML]: Full: C:\Users\Utente\.gradle\caches\modules-2\files-2.1\org.apache.maven\maven-artifact\3.5.3\7dc72b6d6d8a6dced3d294ed54c2cc3515ade9f4\maven-artifact-3.5.3.jar
[10:29:50] [main/ERROR] [FML]: Trimmed: c:/users/utente/.gradle/caches/modules-2/files-2.1/org.apache.maven/maven-artifact/3.5.3/
[10:29:50] [main/INFO] [FML]: Managed to load a deobfuscated Minecraft name- we are in a deobfuscated environment. Skipping runtime deobfuscation
[10:29:50] [main/INFO] [FML]: Detected deobfuscated environment, loading log configs for colored console logs.
2018-11-16 10:29:52,363 main WARN Disabling terminal, you're running in an unsupported environment.
[10:29:52] [main/INFO] [FML]: Ignoring missing certificate for coremod FMLCorePlugin (net.minecraftforge.fml.relauncher.FMLCorePlugin), we are in deobf and it's a forge core plugin
[10:29:52] [main/INFO] [FML]: Ignoring missing certificate for coremod FMLForgePlugin (net.minecraftforge.classloading.FMLForgePlugin), we are in deobf and it's a forge core plugin
[10:29:52] [main/INFO] [FML]: Searching C:\Users\Utente\Desktop\Quest For Perfection [1.12.2]\Workspace QFP\run\.\mods for mods
[10:29:52] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.gradle.tweakers.CoremodTweaker
[10:29:52] [main/INFO] [GradleStart]: Injecting location in coremod net.minecraftforge.fml.relauncher.FMLCorePlugin
[10:29:52] [main/INFO] [GradleStart]: Injecting location in coremod net.minecraftforge.classloading.FMLForgePlugin
[10:29:52] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[10:29:52] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLDeobfTweaker
[10:29:52] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.gradle.tweakers.AccessTransformerTweaker
[10:29:52] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[10:29:52] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[10:29:52] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.relauncher.CoreModManager$FMLPluginWrapper
[10:29:55] [main/ERROR] [FML]: FML appears to be missing any signature data. This is not a good thing
[10:29:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.relauncher.CoreModManager$FMLPluginWrapper
[10:29:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLDeobfTweaker
[10:29:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.gradle.tweakers.AccessTransformerTweaker
[10:29:55] [main/INFO] [GradleStart]: Remapping AccessTransformer rules...
[10:29:55] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.TerminalTweaker
[10:29:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.TerminalTweaker
[10:29:55] [main/INFO] [LaunchWrapper]: Launching wrapped minecraft {net.minecraft.client.main.Main}
[10:29:56] [main/INFO] [minecraft/Minecraft]: Setting user: Player858
[10:29:59] [main/WARN] [minecraft/GameSettings]: Skipping bad option: lastServer:
[10:29:59] [main/INFO] [minecraft/Minecraft]: LWJGL Version: 2.9.4
[10:30:01] [main/INFO] [FML]: -- System Details --
Details:
	Minecraft Version: 1.12.2
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 1.8.0_181, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 804239672 bytes (766 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)
	JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
	IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
	FML: 
	Loaded coremods (and transformers): 
	GL info: ' Vendor: 'NVIDIA Corporation' Version: '4.6.0 NVIDIA 399.24' Renderer: 'GeForce GTX 1050 Ti/PCIe/SSE2'
[10:30:01] [main/INFO] [FML]: MinecraftForge v14.23.5.2772 Initialized
[10:30:01] [main/INFO] [FML]: Starts to replace vanilla recipe ingredients with ore ingredients.
[10:30:01] [main/INFO] [FML]: Replaced 1036 ore ingredients
[10:30:01] [main/INFO] [FML]: Searching C:\Users\Utente\Desktop\Quest For Perfection [1.12.2]\Workspace QFP\run\.\mods for mods
[10:30:03] [Thread-3/INFO] [FML]: Using sync timing. 200 frames of Display.update took 46849003 nanos
[10:30:03] [main/INFO] [FML]: Forge Mod Loader has identified 6 mods to load
[10:30:03] [main/INFO] [FML]: Attempting connection with missing mods [minecraft, mcp, FML, forge, nex, jei] at CLIENT
[10:30:03] [main/INFO] [FML]: Attempting connection with missing mods [minecraft, mcp, FML, forge, nex, jei] at SERVER
[10:30:04] [main/INFO] [minecraft/SimpleReloadableResourceManager]: Reloading ResourceManager: Default, FMLFileResourcePack:Forge Mod Loader, FMLFileResourcePack:Minecraft Forge, FMLFileResourcePack:Nov4e's Experience, FMLFileResourcePack:Just Enough Items
[10:30:04] [main/INFO] [FML]: Processing ObjectHolder annotations
[10:30:05] [main/INFO] [FML]: Found 1168 ObjectHolder annotations
[10:30:05] [main/INFO] [FML]: Identifying ItemStackHolder annotations
[10:30:05] [main/INFO] [FML]: Found 0 ItemStackHolder annotations
[10:30:05] [main/INFO] [FML]: Configured a dormant chunk cache size of 0
[10:30:05] [Forge Version Check/INFO] [forge.VersionCheck]: [forge] Starting version check at http://files.minecraftforge.net/maven/net/minecraftforge/forge/promotions_slim.json
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `iron_sword`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `iron_shovel`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `iron_pickaxe`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `iron_hoe`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `iron_axe`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `golden_sword`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `golden_shovel`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `golden_pickaxe`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `golden_hoe`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `golden_axe`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `compass`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [main/WARN] [FML]: Potentially Dangerous alternative prefix `minecraft` for name `clock`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.
[10:30:05] [Forge Version Check/INFO] [forge.VersionCheck]: [forge] Found status: OUTDATED Target: 14.23.5.2775
[10:30:05] [main/INFO] [FML]: Applying holder lookups
[10:30:05] [main/INFO] [FML]: Holder lookups applied
[10:30:05] [main/INFO] [FML]: Applying holder lookups
[10:30:05] [main/INFO] [FML]: Holder lookups applied
[10:30:05] [main/INFO] [FML]: Applying holder lookups
[10:30:05] [main/INFO] [FML]: Holder lookups applied
[10:30:05] [main/INFO] [FML]: Applying holder lookups
[10:30:05] [main/INFO] [FML]: Holder lookups applied
[10:30:05] [main/INFO] [FML]: Injecting itemstacks
[10:30:05] [main/INFO] [FML]: Itemstack injection complete
[10:30:12] [Sound Library Loader/INFO] [minecraft/SoundManager]: Starting up SoundSystem...
[10:30:12] [Thread-5/INFO] [minecraft/SoundManager]: Initializing LWJGL OpenAL
[10:30:12] [Thread-5/INFO] [minecraft/SoundManager]: (The LWJGL binding of OpenAL.  For more information, see http://www.lwjgl.org)
[10:30:12] [Thread-5/INFO] [minecraft/SoundManager]: OpenAL initialized.
[10:30:12] [Sound Library Loader/INFO] [minecraft/SoundManager]: Sound engine started
[10:30:24] [main/INFO] [FML]: Max texture size: 16384
[10:30:25] [main/INFO] [minecraft/TextureMap]: Created: 512x512 textures-atlas
[10:30:26] [main/INFO] [FML]: Applying holder lookups
[10:30:26] [main/INFO] [FML]: Holder lookups applied
[10:30:26] [main/INFO] [FML]: Injecting itemstacks
[10:30:26] [main/INFO] [FML]: Itemstack injection complete
[10:30:26] [main/INFO] [jei]: Starting JEI...
[10:30:27] [main/INFO] [jei]: Registering recipe categories...
[10:30:27] [main/INFO] [jei]: Registering recipe categories took 55.78 ms
[10:30:27] [main/INFO] [jei]: Registering mod plugins...
[10:30:27] [main/INFO] [jei]: Registering mod plugins took 297.1 ms
[10:30:27] [main/INFO] [jei]: Building recipe registry...
[10:30:27] [main/INFO] [jei]: Building recipe registry took 105.5 ms
[10:30:27] [main/INFO] [jei]: Building ingredient list...
[10:30:27] [main/INFO] [jei]: Building ingredient list took 45.67 ms
[10:30:27] [main/INFO] [jei]: Building ingredient filter...
[10:30:27] [main/INFO] [jei]: Building ingredient filter took 301.7 ms
[10:30:27] [main/INFO] [jei]: Building runtime...
[10:30:28] [main/INFO] [jei]: Building runtime took 174.3 ms
[10:30:28] [main/INFO] [jei]: Starting JEI took 1.314 s
[10:30:28] [main/INFO] [FML]: Forge Mod Loader has successfully loaded 6 mods
[10:30:28] [main/WARN] [minecraft/GameSettings]: Skipping bad option: lastServer:
[10:30:28] [main/INFO] [mojang/NarratorWindows]: Narrator library for x64 successfully loaded
[10:30:29] [Realms Notification Availability checker #1/INFO] [mojang/RealmsClient]: Could not authorize you against Realms server: Invalid session id

 

 

12 hours ago, Cadiboo said:

Overriding getAttackDamage (or similarly named) will give you more control over the damage, there’s nothing wrong with your way though.

getAttackDamage not exists. Maybe is getDamage?

@Override
    public int getDamage(ItemStack stack) {
    	return 3;
    }

 

[Cadiboo]

32 minutes ago, nov4e said:

Maybe is getDamage?

Sounds about right.

12 hours ago, Cadiboo said:

Don’t use static initialisers! Instantiate your items in the registry event. If you need static references to your items, use @ObjectHolder

Can you post your code as a GitHub repository?

[nov4e]

6 minutes ago, Cadiboo said:

Can you post your code as a GitHub repository?

No, I can't sorry. You need the code for 

 

16 hours ago, nov4e said:

Potentially Dangerous alternative prefix `minecraft` for name `clock`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.

this?

[Cadiboo]

I need the code (everything related to insantiating & registering loot tables and items) and preferably your entire debug log. Why can't you post your code as a GitHub repository?

Edited November 16, 2018 by Cadiboo

[nov4e]

3 minutes ago, Cadiboo said:

I need the code (everything related to insantiating & registering loot tables and items) and preferably your entire debug log. Why can you post your code as a GitHub repository?

Can i send the code here via spoilers?

[Animefan8888]

5 hours ago, nov4e said:

Can i send the code here via spoilers?

Use both spoilers and the code tag the button looks like this  <>

[nov4e]

ItemList:

Spoiler

public static final List<Item> modItems = new ArrayList<Item>();
  
  //Example
  public static final ItemSword woodenKnife = new BasicKnife("wooden_knife", WOOD_KNIFE, CreativeTabs.COMBAT);

 

ItemRegistry:

Spoiler

    @SubscribeEvent(priority=EventPriority.HIGH)
	public static void onItemRegister
	(RegistryEvent.Register<Item> evRegisterItem) 
	{
		evRegisterItem.getRegistry().registerAll(ItemList.modItems.toArray(new Item[0]));
	}
	
	@SubscribeEvent(priority=EventPriority.HIGH)
	public static void onModelRegister
	(ModelRegistryEvent evModelRegistry) 
	{
		for(Item stItem : ItemList.modItems) {
			if(stItem instanceof IHasModel) {
				((IHasModel)stItem).registerModels();
			}
		}
	}

 

IHasModel:

Spoiler

public void registerModels();

 

Client Proxy Registry:

Spoiler

    public void registerItemRenderer(Item strItem, int int1, String str1) {
		ModelLoader.setCustomModelResourceLocation(strItem, int1, new ModelResourceLocation(strItem.getRegistryName(), str1));
	}

 

Item Class Example:

Spoiler

public class BasicItem extends Item implements IHasModel {

	public BasicItem
	(String strName, CreativeTabs strCreativeTab) 
	{
		this.setRegistryName(strName);
		this.setUnlocalizedName(strName);
		this.setCreativeTab(strCreativeTab);
		ItemList.modItems.add(this);
	}
	
	@Override
	public boolean canDestroyBlockInCreative
	(World strWorld, BlockPos strBlockPos, ItemStack strItemStack, EntityPlayer strEntityPlayer) 
	{
		return true;
	}
	
	@Override 
	public void registerModels() 
	{
		Dreams.proxy.registerItemRenderer(this, 0, "inventory");
	}


	
}

 

 

[nov4e]

On 11/15/2018 at 6:55 PM, nov4e said:

Potentially Dangerous alternative prefix `minecraft` for name `clock`, expected `nex`. This could be a intended override, but in most cases indicates a broken mod.

So for fix that i have to register recipes that has a vanilla item output in code?

[Animefan8888]

On 11/16/2018 at 8:35 AM, nov4e said:

public static final ItemSword woodenKnife = new 

Stop doing this, dont use static initializers.

 

On 11/16/2018 at 8:35 AM, nov4e said:

public static void onModelRegister

This needs to be in it's own class otherwise it will crash the dedicated server.

 

Dont use IHasModel.

 

And could you post a picture of your directories.

Edited November 20, 2018 by Animefan8888

[Animefan8888]

@nov4e Do you have an Item with the registry name nex:clock.

[nov4e]

1 minute ago, Animefan8888 said:

Stop doing this, dont use static initializers.

Yes but i need the item string beacuse if i have to add a smelting recipe it needs a itemstack

 

2 minutes ago, Animefan8888 said:

This needs to be in it's own class otherwise it will crash the dedicated server.

It has to be in client proxy?

[nov4e]

2 minutes ago, Animefan8888 said:

Do you have an Item with the registry name nex:clock.

no the recipe return minecraft:clock.

[Animefan8888]

31 minutes ago, nov4e said:

It has to be in client proxy?

You can put it there yes.

 

31 minutes ago, nov4e said:

Yes but i need the item string beacuse if i have to add a smelting recipe it needs a itemstack

Use @ObjectHolder or initialize them in the registry event.

 

36 minutes ago, Animefan8888 said:

And could you post a picture of your directories.

 

[nov4e]

50 minutes ago, Animefan8888 said:

Use @ObjectHolder or initialize them in the registry event.

How?

 

50 minutes ago, Animefan8888 said:

And could you post a picture of your directories.

The directory of the json recipes?

[Animefan8888]

29 minutes ago, nov4e said:

The directory of the json recipes?

Yes.

30 minutes ago, nov4e said:

How?

@ObjectHolder("modid:registryName")

public static final Item ITEM = null;

 

Or 

onRegistry()

     ModItems.ITEM = new Item().set...

     register(ModItems.ITEM)

[nov4e]

2 hours ago, Animefan8888 said:

Yes.

assets/nex/recipes/vanilla/clock.json example

[Animefan8888]

52 minutes ago, nov4e said:

assets/nex/recipes/vanilla/clock.json example

Try renaming it something else.

[nov4e]

17 hours ago, Animefan8888 said:

Try renaming it something else.

i renamed the file and the "vanilla" folder but not work.

[Animefan8888]

1 hour ago, nov4e said:

i renamed the file and the "vanilla" folder but not work.

Can you upload your files to github so we can take a look at the whole thing.

[nov4e]

42 minutes ago, Animefan8888 said:

Can you upload your files to github so we can take a look at the whole thing.

github

[nov4e]

you need also the code?

[Animefan8888]

23 minutes ago, nov4e said:

you need also the code?

Yes 

[Cadiboo]

What’s your resistance to uploading your code? We’re not going to steal it...