So if I have, lets say, a stack of 10 bottles, when I right click to milk a cow, it deletes the whole stack and replaces it with a filled bottle, whereas it needs to just add a filled bottle to the inventory and not delete the stack. I looked through EntityCow code in the milking event, but it's not working. Not sure what concept I'd have to add to the code below.

Spoiler

@SubscribeEvent
public void onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {
    World world = event.getWorld();
    EntityPlayer player = event.getEntityPlayer();
    ItemStack itemstack = player.inventory.getCurrentItem();

    if (!world.isRemote) {
        if (event.getTarget() instanceof EntityCow) {

            if (itemstack.getItem() == MyItems.BOTTLE && !event.getEntityPlayer().capabilities.isCreativeMode) {

                player.inventory.setInventorySlotContents(event.getEntityPlayer().inventory.currentItem, new ItemStack(MyItems.MILK));
                player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
            }
        }
    }
}

 

1 hour ago, Siqhter said:

event.getEntityPlayer()

First off this is a little repetitive you created a variable for this.

1 hour ago, Siqhter said:

setInventorySlotContents

This method sets the slots contents whereas you just want to decrease the stack size. Use ItemStack#setCount to set the count. Then call InventoryPlayer#addItemStackToInventory or similar

I understand now why I should use addItemStackToInventory, but I'm just not clear on the set count.

1 minute ago, Siqhter said:

but I'm just not clear on the set count.

An ItemStack has a count of how many "items" are in it. So if you fill one you need to set the count to the count - 1.

Ok, that makes sense, but for some reason I'm crashing when I initialize the variable player that I defined at the top of my class.

20 minutes ago, Siqhter said:

Ok, that makes sense, but for some reason I'm crashing when I initialize the variable player that I defined at the top of my class.

Post the whole class file.

public class MainEvents {

    
    @SubscribeEvent
    public void inventoryif isRemoteif instanceof if EMPTY_BOTTLE capabilitiesisCreativeModeinventorynew BOTTLED_MILKENTITY_COW_MILK1.0F1.0F

Spoiler

public class MainEvents {

   
    EntityPlayer player;

    @SubscribeEvent
    public void onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {
        World world = event.getWorld();
        ItemStack itemstack = player.inventory.getCurrentItem();

        if (!world.isRemote) {
            if (event.getTarget() instanceof EntityCow) {

                if (itemstack.getItem() == ModItems.EMPTY_BOTTLE && !player.capabilities.isCreativeMode) {

                    itemstack.setCount(-1);
                    player.inventory.addItemStackToInventory(new ItemStack(ModItems.BOTTLED_MILK));
                    player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
                }
            }
        }
        }
    }

If I define player locally it works, but I'm not sure why. Also I posted what I originally had, I know the .setCount isn't correct.

Edited November 20, 20186 yr by Siqhter

13 minutes ago, Siqhter said:

public class MainEvents {

    
    @SubscribeEvent
    public void inventoryif isRemoteif instanceof if EMPTY_BOTTLE capabilitiesisCreativeModeinventorynew BOTTLED_MILKENTITY_COW_MILK1.0F1.0F

That doesnt even compile.

13 minutes ago, Siqhter said:

EntityPlayer player;

You never instantiate it, so it is null. Basic Java.

Well, I know, like I said it was the code I originally had, I tried reposting because the formatting got screwed up. Let me repost in a second.

16 minutes ago, Siqhter said:

itemstack.setCount(-1)

This sets the count of how many items are in the stack. So when this is called you know have -1 bottles. Use ItemStack#getCount

Ah, I see. I debugged my code and can confirm it is running twice. e.g. Instead of subtracting 1 bottle from the stack, it takes 2. Aside from that it it working. Here is the correct class.

Spoiler

public class MainEvents {

    EntityPlayer player;

    @SubscribeEvent
    public void onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {
        World world = event.getWorld();
        player = event.getEntityPlayer();
        ItemStack itemstack = player.inventory.getCurrentItem();
        int stackCount = itemstack.getCount();

        if (!world.isRemote) {
            if (event.getTarget() instanceof EntityCow) {

                if (itemstack.getItem() == MyItems.BOTTLE && !player.capabilities.isCreativeMode) {

                    player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
                    player.inventory.addItemStackToInventory(new ItemStack(MyItems.MILK));

                    itemstack.setCount(stackCount-1);
                }
            }
        }
    }

I added this so it would add the final bottled item to the players current hand when the stack of empty bottles is depleted.

Spoiler

if (itemstack.isEmpty()) {
    player.setHeldItem(player.getActiveHand(), new ItemStack(MyItems.MILK));
}

 

Edited November 20, 20186 yr by Siqhter

Well, I realized if I return true then it doesn't allow both hands (from EnumHand) to be fired. But it still runs the addItemStackToInventory code twice.

Spoiler

EntityPlayer player;

@SubscribeEvent
public boolean onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {

    World world = event.getWorld();
    player = event.getEntityPlayer();
    ItemStack itemstack = player.inventory.getCurrentItem();
    int stackCount = itemstack.getCount();
    EnumHand hand = EnumHand.MAIN_HAND;

    if (!world.isRemote) {
        if (event.getTarget() instanceof EntityCow) {

            if (itemstack.getItem() == MyItems.BOTTLE && !player.capabilities.isCreativeMode) {
                player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
                itemstack.setCount(stackCount-1);
                System.out.println("break_1");

                if (itemstack.isEmpty()) {

                    System.out.println("break_2");

                    player.setHeldItem(hand, new ItemStack(MyItems.MILK));
                } else if (!player.inventory.addItemStackToInventory(new ItemStack(MyItems.MILK))) {
                    System.out.println("break_3");
                    player.dropItem(new ItemStack(MyItems.MILK), false);
                }
            }
        }
    }
    return true;
}

 

Try checking if the hand from the event is the hand holding the ItemStack. You can also use ItemStack#shrink()

On 11/20/2018 at 11:07 PM, Cadiboo said:

Try checking if the hand from the event is the hand holding the ItemStack.

Well I tried making a conditional like this, but I'm not sure if I'm following you. I understand the idea.

Spoiler

if (player.getHeldItemMainhand().equals(MyItems.MILK)) { }

 

If event.getHand == player.getActiveHand

Got it, thanks.